Spec URL: http://fedorapeople.org/~jskarvad/dhex/dhex.spec SRPM URL: http://fedorapeople.org/~jskarvad/dhex/dhex-0.68-1.fc20.src.rpm Description: DHEX is a more than just another hex editor: It includes a diff mode, which can be used to easily and conveniently compare two binary files. Since it is based on ncurses and is themeable, it can run on any number of systems and scenarios. With its utilization of search logs, it is possible to track changes in different iterations of files easily. Fedora Account System Username: jskarvad Upstream was notified about the following problem: dhex.x86_64: E: incorrect-fsf-address /usr/share/doc/dhex/gpl.txt
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 28 files have unknown license. Detailed output of licensecheck: Unknown or generated -------------------- dhex_0.68/buffers.c dhex_0.68/buffers.h dhex_0.68/config.h dhex_0.68/configfile.c dhex_0.68/configfile.h dhex_0.68/correlation.c dhex_0.68/correlation.h dhex_0.68/datatypes.h dhex_0.68/gpl.c dhex_0.68/gpl.h dhex_0.68/hexcalc.c dhex_0.68/hexcalc.h dhex_0.68/input.c dhex_0.68/input.h dhex_0.68/machine_type.c dhex_0.68/machine_type.h dhex_0.68/main.c dhex_0.68/markers.c dhex_0.68/markers.h dhex_0.68/menu.c dhex_0.68/menu.h dhex_0.68/mkrelease.sh dhex_0.68/output.c dhex_0.68/output.h dhex_0.68/search.c dhex_0.68/search.h dhex_0.68/ui.c dhex_0.68/ui.h [!]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: dhex-0.68-1.fc21.i686.rpm dhex-0.68-1.fc21.src.rpm dhex.i686: W: spelling-error Summary(en_US) Ncurses -> Curses, N curses, Nurses dhex.i686: W: spelling-error %description -l en_US ncurses -> nurses, curses, n curses dhex.i686: W: spelling-error %description -l en_US themeable -> theme able, theme-able, permeable dhex.i686: E: incorrect-fsf-address /usr/share/doc/dhex/gpl.txt dhex.src: W: spelling-error Summary(en_US) Ncurses -> Curses, N curses, Nurses dhex.src: W: spelling-error %description -l en_US ncurses -> nurses, curses, n curses dhex.src: W: spelling-error %description -l en_US themeable -> theme able, theme-able, permeable 2 packages and 0 specfiles checked; 1 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint dhex dhex.i686: W: spelling-error Summary(en_US) Ncurses -> Curses, N curses, Nurses dhex.i686: W: spelling-error %description -l en_US ncurses -> nurses, curses, n curses dhex.i686: W: spelling-error %description -l en_US themeable -> theme able, theme-able, permeable dhex.i686: E: incorrect-fsf-address /usr/share/doc/dhex/gpl.txt 1 packages and 0 specfiles checked; 1 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- dhex (rpmlib, GLIBC filtered): libc.so.6 libncurses.so.5 libtinfo.so.5 rtld(GNU_HASH) Provides -------- dhex: dhex dhex(x86-32) Source checksums ---------------- http://www.dettus.net/dhex/dhex_0.68.tar.gz : CHECKSUM(SHA256) this package : 126c34745b48a07448cfe36fe5913d37ec562ad72d3f732b99bd40f761f4da08 CHECKSUM(SHA256) upstream package : 126c34745b48a07448cfe36fe5913d37ec562ad72d3f732b99bd40f761f4da08 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/bin/fedora-review -rvn dhex-0.68-1.fc20.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ----------------------------------- 1. LDFLAGS need be to set with %{?__global_ldflags} 2. -std=c99 shouldn't be overwritten IMO. 3. Your patch should also take into account the timestamp of those files, patch cp with install -pm(755/644) should be better. Others are fine.
Forget 4: Makefile contains strip, this is not allowed, the debug info package will be useless. Please patch it off.
(In reply to Christopher Meng from comment #1) Thanks for the review. > 1. LDFLAGS need be to set with %{?__global_ldflags} > This makes sense, but needs to be documentend in the guidelines. Hopefully I fixed all mentioned problems, new versions: Spec URL: http://fedorapeople.org/~jskarvad/dhex/dhex.spec SRPM URL: http://fedorapeople.org/~jskarvad/dhex/dhex-0.68-2.fc20.src.rpm
PACKAGE APPROVED.
(In reply to Christopher Meng from comment #4) > PACKAGE APPROVED. Thanks.
New Package SCM Request ======================= Package Name: dhex Short Description: Ncurses based hexadecimal editor with a diff mode Upstream URL: http://www.dettus.net/dhex/ Owners: jskarvad Branches: f20
Git done (by process-git-requests).
(In reply to Jon Ciesla from comment #7) > Git done (by process-git-requests). Thanks.
dhex-0.68-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/dhex-0.68-2.fc20
dhex-0.68-2.fc20 has been pushed to the Fedora 20 stable repository.