Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kinit.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kinit-4.100.0-1.fc20.src.rpm Description: kdeinit is a process launcher somewhat similar to the famous init used for booting UNIX. It launches processes by forking and then loading a dynamic library which should contain a 'kdemain(...)' function. Fedora Account System Username: dvratil
1) License - src/kdeinit/proctitle.{h,cpp} are under BSD license. 2) Shouldn't be libkdeinit5_klauncher.so in -devel subpackage? If not, then the library should be versioned. 3) Rpmlint error - kf5-kinit.i686: E: missing-call-to-setgroups /usr/libexec/kf5/start_kdeinit - this is the same issue which was present in kf5-kcrash, it's not a blocking issue, but should be reported and fixed in upstream.
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kinit.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kinit-4.100.0-2.fc20.src.rpm > 1) License - src/kdeinit/proctitle.{h,cpp} are under BSD license. Fixed > 2) Shouldn't be libkdeinit5_klauncher.so in -devel subpackage? If not, then the > library should be versioned. Nope, it's technically a plugin, see for instance /usr/lib(64)/libkdeinit_*. > 3) Rpmlint error - kf5-kinit.i686: E: missing-call-to-setgroups /usr/libexec > /kf5/start_kdeinit - this is the same issue which was present in kf5-kcrash, > it's not a blocking issue, but should be reported and fixed in upstream. Submitted patch to upstream (https://git.reviewboard.kde.org/r/119011/)
Ok, looks good now, approved.
New Package SCM Request ======================= Package Name: kf5-kinit Short Description: KDE Frameworks 5 tier 3 solution for process launching Upstream URL: http://www.kde.org Owners: dvratil jgrulich ltinkl rdieter kkofler than Branches: InitialCC:
Git done (by process-git-requests).
Package Change Request ======================= Package Name: kf5-kinit New Branches: f20 Owners: dvratil ltinkl jgrulich kkofler rdieter than