Bug 1111983
| Summary: | Unselected disks for custom preview will remove after commit | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Retired] oVirt | Reporter: | Raz Tamir <ratamir> | ||||
| Component: | ovirt-engine-webadmin | Assignee: | Daniel Erez <derez> | ||||
| Status: | CLOSED UPSTREAM | QA Contact: | Raz Tamir <ratamir> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 3.5 | CC: | acanan, amureini, bugs, derez, ecohen, gklein, iheim, mgoldboi, rbalakri, yeylon | ||||
| Target Milestone: | --- | Keywords: | Reopened, Triaged | ||||
| Target Release: | 3.5.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | storage | ||||||
| Fixed In Version: | ovirt-3.5.0_rc2 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-09-22 07:53:27 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Daniel, haven't we seen a similar BZ before? (In reply to Allon Mureinik from comment #1) > Daniel, haven't we seen a similar BZ before? Yes, it's a duplicate of bug 1095808 which requesting for a UX improvement. *** This bug has been marked as a duplicate of bug 1095808 *** Guys, this issue is about losing the disk, it removes it from the setup - means that the disk is not exist anymore the dup bug is talking about something else. The problem is that if we uncheck the check box for some disks (in the custom preview dialog box), the expected behaviour is, that the unselected disks will continue to exist. The selected disks will be restored to the point in time that the snapshot was taken but the other disks should remain part of the vm in their current point of time. There is nothing to do with removing the disk from the setup when I don't want to commit this disk. The solution, as decided with Sean, is to delete this feature. The new custom preview dialog box will contain only the snapshot that were taken by the user, which means that the first line that used to be the Active VM will no longer be displayed. In this case, the unchecked disks will be part of the vm after committing the previewed snapshot . (In reply to ratamir from comment #4) > The problem is that if we uncheck the check box for some disks (in the > custom preview dialog box), the expected behaviour is, that the unselected > disks will continue to exist. > The selected disks will be restored to the point in time that the snapshot > was taken but the other disks should remain part of the vm in their current > point of time. > There is nothing to do with removing the disk from the setup when I don't > want to commit this disk. > > The solution, as decided with Sean, is to delete this feature. Hardly. This is an important part of the feature, as was always discussed, and acked. The only reasonable improvement here is to add a warning in such a case. |
Created attachment 911144 [details] vdsm and engine logs Description of problem: Setup with 1 vm, 3 disks Taking a snapshot with all disks (3) included, and then custom preview the snapshot and selecting only the first disk will cause that the other 2 disks will remove from the setup. Version-Release number of selected component (if applicable): ovirt-engine-3.5.0-0.0.master.20140605145557.git3ddd2de.el6.noarch How reproducible: 100% Steps to Reproduce: 1. take a snapshot for all vm's disks 2. custom preview and select only 1 disk 3. commit the previewed snapshot Actual results: The disks that were not included in the custom preview will remove from the setup Expected results: * The disk that were selected for preview will be restore (After committing) to the time the snapshot was taken. * The other disks should remain Additional info: