Created attachment 911145[details]
vdsm and engine logs
Description of problem:
After committing a custom previewed snapshot, the disk's status, that were not selected in the preview phase, will change to illegal in the snapshot's disks tab
Version-Release number of selected component (if applicable):
ovirt-engine-3.5.0-0.0.master.20140605145557.git3ddd2de.el6.noarch
How reproducible:
100%
Steps to Reproduce:
1. custom preview snapshot - select only 1 disk for pewview
2. commit the previewed snapshot
3.
Actual results:
The unselected disks statuses will change to illegal
Expected results:
the disks statuses should remain ok
Additional info:
Deselecting a disk from a customized preview is essentially the same as removing a disk snapshot; hence, the behavior is by design. To keep the disk in its current state, select the appropriate checkbox in the 'Active VM' row of the 'custom preview snapshot' dialog. See related request for UX improvement bug 1095808.
Hi Daniel,
After speaking with you I'm reopening this bug.
As we spoke, the expected results for this scenario is that the unselected disks of the custom preview will remain to be ok, since they still part of the snapshot.
The disks that were selected for committing will be restore to the point of time that the snapshot was taken, and the other will remain as is
(In reply to Allon Mureinik from comment #3)
> The disk WAS removed. What other state would you have it in?
I understand a scenario where an admin makes a human error by unselecting the wrong disks hence resulting in a removed state.
I guess we can simply add a warning notification that unselecting the disk from the preview will result in disk removal.
I don't think we should change our design, just explain it.
Sean
Created attachment 911145 [details] vdsm and engine logs Description of problem: After committing a custom previewed snapshot, the disk's status, that were not selected in the preview phase, will change to illegal in the snapshot's disks tab Version-Release number of selected component (if applicable): ovirt-engine-3.5.0-0.0.master.20140605145557.git3ddd2de.el6.noarch How reproducible: 100% Steps to Reproduce: 1. custom preview snapshot - select only 1 disk for pewview 2. commit the previewed snapshot 3. Actual results: The unselected disks statuses will change to illegal Expected results: the disks statuses should remain ok Additional info: