Spec URL: http://ankursinha.fedorapeople.org/vit/vit.spec SRPM URL: http://ankursinha.fedorapeople.org/vit/vit-1.2-0.1.beta1.fc21.src.rpm Description: Features: * Vim key bindings * uncluttered display * no mouse * speed Fedora Account System Username: ankursinha There's an rpmlint error about a man page. I checked the man page using `man -l` and it looks just fine, though.
Note: this review is unofficial/preliminary. > rpmlint: > vit.noarch: W: manual-page-warning /usr/share/man/man5/vitrc.5.gz 61: cannot use character `*' as a starting delimiter This seems to be an actual error in the man page. I would suggest this, which seems to give me the correct output: -.B map c=:! task %TASKID rc.defaultwidth:200 | grep -o -P -m 1 "(ftp|http)s?://\S*" | tr -d '\n' | xsel -b<Return> +.B map c=:! task %TASKID rc.defaultwidth:200 | grep -o -P -m 1 "(ftp|http)s?://\\\\S*" | tr -d '\n' | xsel -b<Return> Did you submit the Makefile.in patch upstream? If yes, please add a link to the bug report. If not, please do that, it will make maintenance easier down the line. Same for the man page. The final 1.2 release seems to be out (http://taskwarrior.org/news/news.20140406.html).
(In reply to Benedikt Morbach from comment #1) > Note: this review is unofficial/preliminary. > > > rpmlint: > > vit.noarch: W: manual-page-warning /usr/share/man/man5/vitrc.5.gz 61: cannot use character `*' as a starting delimiter > > This seems to be an actual error in the man page. > I would suggest this, which seems to give me the correct output: > -.B map c=:! task %TASKID rc.defaultwidth:200 | grep -o -P -m 1 > "(ftp|http)s?://\S*" | tr -d '\n' | xsel -b<Return> > +.B map c=:! task %TASKID rc.defaultwidth:200 | grep -o -P -m 1 > "(ftp|http)s?://\\\\S*" | tr -d '\n' | xsel -b<Return> > > Did you submit the Makefile.in patch upstream? > If yes, please add a link to the bug report. > If not, please do that, it will make maintenance easier down the line. > Same for the man page. > > The final 1.2 release seems to be out > (http://taskwarrior.org/news/news.20140406.html). Hi Benedikt, Thanks for the comments and the fix for the man page. I'm already in communication with upstream via e-mail, but I've gone ahead and filed bugs too. Updated spec/srpm: http://ankursinha.fedorapeople.org/vit/vit.spec http://ankursinha.fedorapeople.org/vit/vit-1.2-1.fc21.src.rpm No rpmlint warnings any more. Thanks, Warm regards, Ankur
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 16 files have unknown license. Detailed output of licensecheck: Unknown or generated -------------------- vit-1.2/args.pl vit-1.2/cmdline.pl vit-1.2/cmds.pl vit-1.2/color.pl vit-1.2/curses.pl vit-1.2/draw.pl vit-1.2/env.pl vit-1.2/exec.pl vit-1.2/getch.pl vit-1.2/misc.pl vit-1.2/prompt.pl vit-1.2/read.pl vit-1.2/screen.pl vit-1.2/search.pl vit-1.2/vit.pl vit-1.2/vitrc.pl [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: vit-1.2-1.fc21.noarch.rpm vit-1.2-1.fc21.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint vit 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- vit (rpmlib, GLIBC filtered): /usr/bin/perl config(vit) perl(Curses) perl(Time::HiRes) perl(strict) task Provides -------- vit: config(vit) vit Source checksums ---------------- http://taskwarrior.org/download/vit-1.2.tar.gz : CHECKSUM(SHA256) this package : a78dee573130c8d6bc92cf60fafac0abc78dd2109acfba587cb0ae202ea5bbd0 CHECKSUM(SHA256) upstream package : a78dee573130c8d6bc92cf60fafac0abc78dd2109acfba587cb0ae202ea5bbd0 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/bin/fedora-review -rvn vit-1.2-1.fc21.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG --------------------------------------- 1. Should list the perl BRs in perl style perl(Curses). 2. Drop rm -rf $RPM_BUILD_ROOT 3. Drop VERSION file in %doc, it's useless.
Thanks for the review Christopher. I'll update the package in a few days when I get back to Sydney. My internet connection here at the hotel isn't good enough for builds etc. Warm regards, Ankur
Welcome to China! XD
Hi Christopher: Updated URLs: http://ankursinha.fedorapeople.org/vit/vit.spec http://ankursinha.fedorapeople.org/vit/vit-1.2-1.fc21.src.rpm * Fri Jul 11 2014 Ankur Sinha <ankursinha AT fedoraproject DOT org> 1.2-1 - Update as per reviewer comments - rhbz1112072 Thanks, Warm regards, Ankur
PACKAGE APPROVED.
Thanks for the review Christopher! New Package SCM Request ======================= Package Name: vit Short Description: A minimalist Taskwarrior full-screen terminal interface with Vim key bindings Upstream URL: http://taskwarrior.org Owners: ankursinha Branches: f20 f21 InitialCC:
Git done (by process-git-requests).
vit-1.2-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/vit-1.2-1.fc20
Package vit-1.2-1.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing vit-1.2-1.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-8319/vit-1.2-1.fc20 then log in and leave karma (feedback).
vit-1.2-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.