Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1112175

Summary: Redact secrets present in useradd statements in kickstarts in sos anaconda plugin
Product: Red Hat Enterprise Linux 7 Reporter: David Kutálek <dkutalek>
Component: sosAssignee: Bryn M. Reeves <bmr>
Status: CLOSED ERRATA QA Contact: David Kutálek <dkutalek>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.0CC: agk, lmiksik
Target Milestone: rcKeywords: Patch, Upstream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: sos-3.2-11.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-03-05 11:23:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description David Kutálek 2014-06-23 09:36:59 UTC
Description of problem:

Kickstarts since RHEL-7 can contain user account entries with hashed passwords like this:

useradd --password 'xxx' user

Please redact it in anaconda sos plugin.


Version-Release number of selected component (if applicable):

sos-3.0-23.el7

How reproducible:

Always

Steps to Reproduce:
1. Prepare a kickstart with line as shown above
2. run sos -o anaconda
3. 

Actual results:

hashed password present in sos tarball

Expected results:

Password not present
Additional info:

Comment 1 Bryn M. Reeves 2014-06-24 10:01:15 UTC
commit 772a953a30c75a0f4aa4e0554ab840ea54670d33
Author: Bryn M. Reeves <bmr>
Date:   Sat Jun 21 16:45:59 2014 +0100

    [anaconda] elide passwords in kickstart user directives
    
    E.g.:
    
    useradd --password '$6$oIW3o2Mr$XbWZKaM7nA.cQqudfDJScupXOia5h1u517t6Htx/Q/MgXm82Pc/OcytatTeI4ULNWOMJzvpCigWiL4xKP9PX4.' test
    
    Signed-off-by: Bryn M. Reeves <bmr>

Comment 6 Bryn M. Reeves 2015-01-13 15:05:58 UTC
Fixed upstream with a very slight change:

commit 5a97e0e2571b948f1f7bc602e6f190976de99eee
Author: Bryn M. Reeves <bmr>
Date:   Tue Jan 13 16:31:58 2015 +0000

    [anaconda] make useradd password regex tolerant of whitespace
    
    Signed-off-by: Bryn M. Reeves <bmr>

diff --git a/sos/plugins/anaconda.py b/sos/plugins/anaconda.py
index 08d300b..aea3300 100644
--- a/sos/plugins/anaconda.py
+++ b/sos/plugins/anaconda.py
@@ -54,7 +54,7 @@ class Anaconda(Plugin, RedHatPlugin):
         )
         self.do_file_sub(
             "/root/anaconda-ks.cfg",
-            r"(user.*--password=*)(\S*)",
+            r"(user.*--password=*\s*)\s*(\S*)",
             r"\1********"
         )
 

This passed with the following useradd directives:

# grep ^useradd /root/anaconda-ks.cfg
useradd --password='$6$oIW3o2Mr$XbWZKaM7nA.cQqudfDJScupXOia5h1u517t6Htx/Q/MgXm82Pc/OtatycTeI4ULNWOMJzvpCigWiL4xKP9PX4.' test
useradd --password=$6$oIW3o2Mr$XbWZKaM7nA.cQqudfDJScupXOia5h1u517t6Htx/Q/MgXm82Pc/OtatycTeI4ULNWOMJzvpCigWiL4xKP9PX4. test
useradd --password '$6$oIW3o2Mr$XbWZKaM7nA.cQqudfDJScupXOia5h1u517t6Htx/Q/MgXm82Pc/OtatycTeI4ULNWOMJzvpCigWiL4xKP9PX4.' test
useradd --password $6$oIW3o2Mr$XbWZKaM7nA.cQqudfDJScupXOia5h1u517t6Htx/Q/MgXm82Pc/OtatycTeI4ULNWOMJzvpCigWiL4xKP9PX4. test

# grep ^useradd sosreport-bmr-rhel7-vm1*/root/anaconda-ks.cfg 
useradd --password=******** test
useradd --password=******** test
useradd --password ******** test
useradd --password ******** test

The extra '\s*' within the first capture group means we preserve whitespace (rather than change 'password foo' into 'password***').

Comment 9 errata-xmlrpc 2015-03-05 11:23:23 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0532.html