Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1112446

Summary:	oo-accept-node will still check the apache configs for mod_rewrite frontend when using vhost frontend plugin
Product:	OpenShift Container Platform	Reporter:	Yanping Zhang <yanpzhan>
Component:	Containers	Assignee:	Scott Dodson <sdodson>
Status:	CLOSED ERRATA	QA Contact:	libra bugs <libra-bugs>
Severity:	medium	Docs Contact:
Priority:	high
Version:	2.2.0	CC:	adellape, bleanhar, bmeng, jialiu, jokerman, libra-onpremise-devel, lmeyer, mmccomas, sdodson
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openshift-origin-node-util-1.22.20.1-1.el6op	Doc Type:	Bug Fix
Doc Text:	Previously, the oo-accept-node tool incorrectly performed mod_rewrite configuration checks on nodes which were configured to use the apache-vhost front-end plug-in. These checks were unnecessary because the apache-mod-rewrite and apache-vhost plug-ins are mutually exclusive. This bug fix updates the tool to only perform the mod_rewrite checks when the apache-mod-rewrite plug-in is in use.	Story Points:	---
Clone Of:	1059105	Environment:
Last Closed:	2014-09-11 20:06:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1059105, 1132963
Bug Blocks:

Description Yanping Zhang 2014-06-24 01:47:17 UTC

+++ This bug was initially created as a clone of Bug #1059105 +++

Description of problem:
Run oo-accept-node on node to check the apache config issue on node, it will only return the issues when the node using mod_rewrite plugin.
That means for nodes which running with vhost plugin will never failed the httpd config check by oo-accept-node.

Version-Release number of selected component (if applicable):
devenv_4295

How reproducible:
always

Steps to Reproduce:
1. Launch instance and let it using vhost frontend plugin
2. Make the httpd config mismatch with gear
eg, 
copy the 52e89ec6070b084933000006_bmengdev_0_php1.conf and 52e89ec6070b084933000006_bmengdev_php1/ back after gear deleted.
or
delete the existing config files for running gear.
3. Run oo-accept-node -v

Actual results:
It will pass the checking.

Expected results:
Should fail since the http config does not match the gear.

Additional info:
The bug exsits on ose 2.1.z/2014-06-12.2,openshift-origin-node-util-1.22.9.1-1.el6op.noarch

Comment 1 Brenton Leanhardt 2014-08-25 14:37:24 UTC

*** Bug 1132963 has been marked as a duplicate of this bug. ***

Comment 2 Scott Dodson 2014-09-02 19:19:10 UTC

Per the upstream bug I've adjusted this bug to only address checking mod_rewrite files when using the vhost frontend

Fixed in this puddle http://etherpad.corp.redhat.com/puddle-2-1-2014-09-02

Comment 4 Yanping Zhang 2014-09-03 02:43:51 UTC

Test on http://etherpad.corp.redhat.com/puddle-2-1-2014-09-02, when node is using vhost, run oo-accept-node will pass.But when node is using mod_rewrite, run oo-accept-node, it displays:
/usr/sbin/oo-accept-node:649:in `check_system_httpd_configs': undefined local variable or method `http_plugins' for main:Object (NameError)
	from /usr/sbin/oo-accept-node:986:in `<main>'
Seems that the `http_plugins' not defined first.

Comment 11 errata-xmlrpc 2014-09-11 20:06:33 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-1183.html