Bug 1112446 - oo-accept-node will still check the apache configs for mod_rewrite frontend when using vhost frontend plugin
Summary: oo-accept-node will still check the apache configs for mod_rewrite frontend w...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Containers
Version: 2.2.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ---
: ---
Assignee: Scott Dodson
QA Contact: libra bugs
URL:
Whiteboard:
: 1132963 (view as bug list)
Depends On: 1059105 1132963
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-24 01:47 UTC by Yanping Zhang
Modified: 2016-05-25 13:26 UTC (History)
9 users (show)

Fixed In Version: openshift-origin-node-util-1.22.20.1-1.el6op
Doc Type: Bug Fix
Doc Text:
Previously, the oo-accept-node tool incorrectly performed mod_rewrite configuration checks on nodes which were configured to use the apache-vhost front-end plug-in. These checks were unnecessary because the apache-mod-rewrite and apache-vhost plug-ins are mutually exclusive. This bug fix updates the tool to only perform the mod_rewrite checks when the apache-mod-rewrite plug-in is in use.
Clone Of: 1059105
Environment:
Last Closed: 2014-09-11 20:06:33 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2014:1183 0 normal SHIPPED_LIVE Red Hat OpenShift Enterprise 2.1.6 bug fix and enhancement update 2014-09-12 00:06:21 UTC

Description Yanping Zhang 2014-06-24 01:47:17 UTC
+++ This bug was initially created as a clone of Bug #1059105 +++

Description of problem:
Run oo-accept-node on node to check the apache config issue on node, it will only return the issues when the node using mod_rewrite plugin.
That means for nodes which running with vhost plugin will never failed the httpd config check by oo-accept-node.

Version-Release number of selected component (if applicable):
devenv_4295

How reproducible:
always

Steps to Reproduce:
1. Launch instance and let it using vhost frontend plugin
2. Make the httpd config mismatch with gear
eg, 
copy the 52e89ec6070b084933000006_bmengdev_0_php1.conf and 52e89ec6070b084933000006_bmengdev_php1/ back after gear deleted.
or
delete the existing config files for running gear.
3. Run oo-accept-node -v

Actual results:
It will pass the checking.

Expected results:
Should fail since the http config does not match the gear.

Additional info:
The bug exsits on ose 2.1.z/2014-06-12.2,openshift-origin-node-util-1.22.9.1-1.el6op.noarch

Comment 1 Brenton Leanhardt 2014-08-25 14:37:24 UTC
*** Bug 1132963 has been marked as a duplicate of this bug. ***

Comment 2 Scott Dodson 2014-09-02 19:19:10 UTC
Per the upstream bug I've adjusted this bug to only address checking mod_rewrite files when using the vhost frontend

Fixed in this puddle http://etherpad.corp.redhat.com/puddle-2-1-2014-09-02

Comment 4 Yanping Zhang 2014-09-03 02:43:51 UTC
Test on http://etherpad.corp.redhat.com/puddle-2-1-2014-09-02, when node is using vhost, run oo-accept-node will pass.But when node is using mod_rewrite, run oo-accept-node, it displays:
/usr/sbin/oo-accept-node:649:in `check_system_httpd_configs': undefined local variable or method `http_plugins' for main:Object (NameError)
	from /usr/sbin/oo-accept-node:986:in `<main>'
Seems that the `http_plugins' not defined first.

Comment 11 errata-xmlrpc 2014-09-11 20:06:33 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-1183.html


Note You need to log in before you can comment on or make changes to this bug.