RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1113177 - Reply with selection can lose white-spaces
Summary: Reply with selection can lose white-spaces
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: evolution
Version: 7.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Matthew Barnes
QA Contact: Desktop QE
URL:
Whiteboard:
Depends On:
Blocks: 1113520
TreeView+ depends on / blocked
 
Reported: 2014-06-25 14:46 UTC by Simo Sorce
Modified: 2015-03-05 06:37 UTC (History)
4 users (show)

Fixed In Version: evolution-3.8.5-25
Doc Type: Bug Fix
Doc Text:
Cause: Reply to a message when there's some text selected in it Consequence: the selected text is used as the new message's body, but any preformatted style or basically whitespaces are lost in the new message Fix: use preformatted style in the reply when the selection is part of the preformatted text Result: the preformatted style (and whitespaces in it) are preserved from the selection to the new message
Clone Of:
Environment:
Last Closed: 2015-03-05 06:37:23 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:0305 0 normal SHIPPED_LIVE evolution bug fix update 2015-03-05 11:36:15 UTC

Description Simo Sorce 2014-06-25 14:46:31 UTC
Description of problem:
I often select a part of a patch sent as an attachment and then reply so that the reply only contain the relevant part I am interested in.

With the new evolution version in RHEL7 this breaks in 2 ways:
1. if I click the reply or reply group buttons all formatting is lost (see later).
2. If I press ctrl+L to reply to a list the selection is ignored and the message is included quote in the reply instead.

Actual results:
The formatting issue gives me this:

+ +/* Wrapper around ldb_search to ensure that if zero results are found then + * ENOENT is returned + */ +errno_t sss_ldb_search(struct ldb_context *ldb, TALLOC_CTX *mem_ctx, + struct ldb_result **_result, struct ldb_dn *base, + enum ldb_scope scope, const char * const *attrs, + const char *exp_fmt, ...) +{ + char *s; + int lret; + va_list ap; + errno_t ret; + TALLOC_CTX *tmp_ctx = NULL; + + if (exp_fmt != NULL) { + tmp_ctx = talloc_new(NULL); + if (tmp_ctx == NULL) { + ret = ENOMEM; + goto done; + } + + va_start(ap, exp_fmt); + s = talloc_vasprintf(tmp_ctx, exp_fmt, ap); + va_end(ap); + + if (s == NULL) { + DEBUG(SSSDBG_MINOR_FAILURE, "Failed to process filter.\n"); + ret = ENOMEM; + goto done; + } + lret = ldb_search(ldb, mem_ctx, _result, base, scope, attrs, "%s", s); + } else { + lret = ldb_search(ldb, mem_ctx, _result, base, scope, attrs, NULL); + } + + ret = sysdb_error_to_errno(lret); + if (ret != EOK) { + goto done; + } + + if ((*_result)->count == 0) { + ret = ENOENT; + goto done; + } + +done: + talloc_free(tmp_ctx); + return ret; +} +
> 

Expected results:

+
+/* Wrapper around ldb_search to ensure that if zero results are found then
+ * ENOENT is returned
+ */
+errno_t sss_ldb_search(struct ldb_context *ldb, TALLOC_CTX *mem_ctx,
+                       struct ldb_result **_result, struct ldb_dn *base,
+                       enum ldb_scope scope, const char * const *attrs,
+                       const char *exp_fmt, ...)
+{
+    char *s;
+    int lret;
+    va_list ap;
+    errno_t ret;
+    TALLOC_CTX *tmp_ctx = NULL;
+
+    if (exp_fmt != NULL) {
+        tmp_ctx = talloc_new(NULL);
+        if (tmp_ctx == NULL) {
+            ret = ENOMEM;
+            goto done;
+        }
+
+        va_start(ap, exp_fmt);
+        s = talloc_vasprintf(tmp_ctx, exp_fmt, ap);
+        va_end(ap);
+
+        if (s == NULL) {
+            DEBUG(SSSDBG_MINOR_FAILURE, "Failed to process filter.\n");
+            ret = ENOMEM;
+            goto done;
+        }
+        lret = ldb_search(ldb, mem_ctx, _result, base, scope, attrs, "%s", s);
+    } else {
+        lret = ldb_search(ldb, mem_ctx, _result, base, scope, attrs, NULL);
+    }
+
+    ret = sysdb_error_to_errno(lret);
+    if (ret != EOK) {
+        goto done;
+    }
+
+    if ((*_result)->count == 0) {
+        ret = ENOENT;
+        goto done;
+    }
+
+done:
+    talloc_free(tmp_ctx);
+    return ret;
+}
+

Additional info:

Comment 3 Milan Crha 2014-06-27 08:32:03 UTC
Thanks for a bug report. I fixed the first part upstream [1], but I cannot reliably reproduce the second. It happened to me once that regardless I had selected some text in one subpart I've got reply to the main message body, but it was only once and I was not able to reproduce it again. if you figure out the steps, then please open a separate bug report for it. There is also no difference between replying to one recipient or to the list.

I would unset the blocker flag, because there is a workaround. Just click into the formatted body with a left-mouse button, then right-click and select Format as->Plain Text (it's the first item in the submenu). Then you'll see the text will be just black&white, no pretty-printing. Selecting this text and replying to it will work like before. If you do not care of the pretty-printing in general, then simply remove
   /usr/lib64/evolution/3.8/modules/module-text-highlight.so
and everything will be working like before. Another option is to remove 'highlight' binary (you might not be able to uninstall it, because evolution depends on it).

[1] https://git.gnome.org/browse/evolution/commit/?id=586ab6e

Comment 4 Simo Sorce 2014-06-27 15:22:15 UTC
Ah thank you soo much for the "format as" workaround, that works just fine.

And although I was able to repro yesterday, today (I have restarted evo in the meanwhile) I cannot reproduce #2. So I will just ignore it, and open a new bug report only if I can find a reliable way to reproduce.

Comment 8 errata-xmlrpc 2015-03-05 06:37:23 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0305.html


Note You need to log in before you can comment on or make changes to this bug.