Spec URL: http://pwu.fedorapeople.org/ibus/ibus-libzhuyin/ibus-libzhuyin.spec SRPM URL: http://pwu.fedorapeople.org/ibus/ibus-libzhuyin/ibus-libzhuyin-1.6.99.20140626-1.fc20.src.rpm Description: It includes a Chinese Zhuyin (Bopomofo) input method based on libzhuyin for IBus. Fedora Account System Username: pwu
suggestions: 1) Package should add either BR: python2-devel or python3-devel 2) rpmlint output on rpms gave ibus-libzhuyin.src: E: description-line-too-long C It includes a Chinese Zhuyin (Bopomofo) input method based on libzhuyin for IBus. ibus-libzhuyin.src:42: W: macro-in-comment %find_lang ibus-libzhuyin.src:42: W: macro-in-comment %{name} ibus-libzhuyin.src:44: W: macro-in-comment %files ibus-libzhuyin.src:44: W: macro-in-comment %{name} ibus-libzhuyin.src: W: file-size-mismatch ibus-libzhuyin-1.6.99.20140626.tar.gz = 458962, http://downloads.sourceforge.net/libzhuyin/ibus-libzhuyin/ibus-libzhuyin-1.6.99.20140626.tar.gz = 458946 ibus-libzhuyin.x86_64: E: description-line-too-long C It includes a Chinese Zhuyin (Bopomofo) input method based on libzhuyin for IBus. ibus-libzhuyin.x86_64: E: zero-length /usr/share/doc/ibus-libzhuyin/NEWS ibus-libzhuyin.x86_64: W: install-file-in-docs /usr/share/doc/ibus-libzhuyin/INSTALL 3 packages and 0 specfiles checked; 3 errors, 6 warnings. Fix the above rpmlint messages 3) If this package is only for Fedora then remove lines Group: System Environment/Libraries rm -rf $RPM_BUILD_ROOT %defattr(-,root,root,-) 4) Change make DESTDIR=${RPM_BUILD_ROOT} install to make install DESTDIR=${RPM_BUILD_ROOT} INSTALL="install -p" 5) No option available "--enable-opencc" to ./configure as its default enabled 6) Looks like package is failing to build for F20 but passed on F21.
Spec URL: http://pwu.fedorapeople.org/ibus/ibus-libzhuyin/ibus-libzhuyin.spec SRPM URL: http://pwu.fedorapeople.org/ibus/ibus-libzhuyin/ibus-libzhuyin-1.6.99.20140626-2.fc20.src.rpm Please review it again, thanks.
1) You missed to address issue1 in comment#1 , Please add BuildRequires: python2-devel and NOT BuildRequires: python-devel 2) you don't need following %exclude %{_docdir}/ibus-libzhuyin/NEWS %exclude %{_docdir}/ibus-libzhuyin/INSTALL These are not getting installed using makefile that you want to exclude them. Only listed files to %docs are installed.
you can do above changes at the time of import of this package also. APPROVED.
New Package SCM Request ======================= Package Name: ibus-libzhuyin Short Description: New Zhuyin engine based on libzhuyin for IBus Upstream URL: https://github.com/libzhuyin/ibus-libzhuyin Owners: pwu Branches: f20 f19 InitialCC: i18n-team petersen
Git done (by process-git-requests).
Built for rawhide and F21, close bug.