Spec URL: http://people.redhat.com/dhowells/xtrace/x11trace.spec SRPM URL: http://people.redhat.com/dhowells/xtrace/x11trace-1.3.1-6.fc20.src.rpm Description: What strace is for system calls, xtrace is for X11 connections: you hook it between one or more X11 clients and an X server and it prints the requests going from client to server and the replies, events and errors going the other way. Fedora Account System Username:dhowells
The package and its components have been renamed from xtrace (which clashes with a glibc utility) to x11trace.
Review: + mock build is successful for rawhide + rpmlint output on rpms gave x11trace.src: W: spelling-error %description -l en_US strace -> trace, traces, strafe x11trace.src: W: spelling-error %description -l en_US xtrace -> trace, x trace, extract x11trace.src: W: strange-permission xtrace_1.3.1.orig.tar.gz 0444L x11trace.x86_64: W: spelling-error %description -l en_US strace -> trace, traces, strafe x11trace.x86_64: W: spelling-error %description -l en_US xtrace -> trace, x trace, extract 3 packages and 0 specfiles checked; 0 errors, 5 warnings. + Source verified with upstream as (sha256sum) srpm tarball : b22ca970efe24fcedff44f38075c5f34e0893f66abb419f3180ff92adf9e2a22 upstream tarball : b22ca970efe24fcedff44f38075c5f34e0893f66abb419f3180ff92adf9e2a22 + License "GPLv2" is valid and included in source files. suggestions: 1) Package must own all directories that it creates. Note: Directories without known owners: /usr/share/x11trace ==> fix this by changing %{_datadir}/x11trace/*.proto to %{_datadir}/x11trace 2) you can change source tarball permission to 0644 before packaging to srpm 3) I see you have following which can be removed from spec echo hello2 4) all your patche prefix names should start with package name i.e. change xtrace to x11trace 5) Now the most important thing for a Rename package review is to follow http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages you will then need in your spec Provides: xtrace = %{version}-%{release} Obsoletes: xtrace < 1.3.1-7 also use the master branch spec only while renaming package. You should use release number 7 and not 6 Fix above issues and submit new package for review.
Spec URL: http://people.redhat.com/dhowells/xtrace/x11trace.spec SRPM URL: http://people.redhat.com/dhowells/xtrace/x11trace-1.3.1-7.fc20.src.rpm
now rpmlint only complains x11trace.x86_64: W: obsolete-not-provided xtrace which is okay as glibc-utils provides /usr/bin/xtrace APPROVED.
New Package SCM Request ======================= Package Name: x11trace Short Description: A program for X11 protocol tracing Owners: dhowells Branches: f20 InitialCC:
I have reset the fedora-cvs+ to fedora-cvs? flag as its what you need.
Git done (by process-git-requests).
x11trace is now built for rawhide. Should I build it for F20 also?
yes you should :)
Okay, build for F20.
Built for F20, that is
Thanks. We can close this review then.