Bug 1113588 - On host creation with no environment UI displays no error, but silently fails
Summary: On host creation with no environment UI displays no error, but silently fails
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: WebUI
Version: 6.0.3
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: Unspecified
Assignee: Brad Buckingham
QA Contact: Kedar Bidarkar
URL: http://projects.theforeman.org/issues...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-26 13:12 UTC by Adam Saleh
Modified: 2019-09-26 14:33 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-09-11 12:18:51 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
puppet environment can't be blank (55.37 KB, image/png)
2014-08-20 12:07 UTC, Kedar Bidarkar
no flags Details
Puppet Environment : error shown on Satellite 6.1.1 UI (68.82 KB, image/png)
2015-08-17 17:47 UTC, Brad Buckingham
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 6919 0 None None None 2016-04-22 15:06:29 UTC

Description Adam Saleh 2014-06-26 13:12:40 UTC
Description of problem:
After submitting new host creation form, with empty environment, no error is shown, but host fails to get created.

After looking into logs I find:

  Parameters: {"utf8"=>"✓", "authenticity_token"=>"qyy7jFS8ZLGfIxcYb39p/4z7sBMzogO4wkyLbxrDQaI=", "host"=>{"name"=>"test0", "organization_id"=>"1", "location_id"=>"2", "hostgroup_id"=>"", "compute_resource_id"=>"", "environment_id"=>"", "content_source_id"=>"", "puppet_ca_proxy_id"=>"", "puppet_proxy_id"=>"", "managed"=>"true", "progress_report_id"=>"[FILTERED]", "type"=>"Host::Managed", "domain_id"=>"1", "realm_id"=>"", "mac"=>"AA:AA:AA:00:00:00", "ip"=>"333.333.333.333", "interfaces_attributes"=>{"new_interfaces"=>{"_destroy"=>"false", "type"=>"Nic::Managed", "mac"=>"", "name"=>"", "domain_id"=>"", "ip"=>"", "provider"=>"IPMI"}}, "architecture_id"=>"2", "operatingsystem_id"=>"1", "provision_method"=>"build", "build"=>"1", "medium_id"=>"1", "ptable_id"=>"7", "disk"=>"", "root_pass"=>"[FILTERED]", "is_owned_by"=>"1-Users", "enabled"=>"1", "model_id"=>"", "comment"=>"", "overwrite"=>"false"}, "kt_environment_id"=>""}
Failed to save: Environment can't be blank

This error should have been propagated to ui.

Comment 2 Dominic Cleal 2014-07-09 10:09:32 UTC
I suspect this is to do with Katello's defacing of the environment field, as the error shows fine on a plain Foreman installation.

Comment 3 Brad Buckingham 2014-08-04 17:53:49 UTC
Created redmine issue http://projects.theforeman.org/issues/6919 from this bug

Comment 4 Brad Buckingham 2014-08-04 20:26:28 UTC
Proposed fix in Katello PR: 
https://github.com/Katello/katello/pull/4527

Comment 7 Kedar Bidarkar 2014-08-20 12:07:30 UTC
Created attachment 928780 [details]
puppet environment can't be blank

Comment 8 Kedar Bidarkar 2014-08-20 12:10:06 UTC
Tested with Sat6-GA-Snap5

=======================================================
Processing by HostsController#create as */*
  Parameters: {"utf8"=>"✓", "authenticity_token"=>"wKHsVOX1Qz4WtMyErXRiCKsgKw55bzkxrY01qXm956k=", "host"=>{"name"=>"dlink008", "organization_id"=>"1", "location_id"=>"2", "hostgroup_id"=>"", "compute_resource_id"=>"1", "environment_id"=>"", "content_source_id"=>"1", "puppet_ca_proxy_id"=>"1", "puppet_proxy_id"=>"1", "managed"=>"true", "progress_report_id"=>"[FILTERED]", "type"=>"Host::Managed", "compute_attributes"=>{"cpus"=>"1", "memory"=>"1073741824", "nics_attributes"=>{"new_nics"=>{"type"=>"bridge", "_delete"=>"", "bridge"=>"eth0", "model"=>"virtio"}, "0"=>{"type"=>"network", "_delete"=>"", "network"=>"foreman", "bridge"=>"eth0", "model"=>"virtio"}}, "volumes_attributes"=>{"new_volumes"=>{"pool_name"=>"default", "capacity"=>"10G", "allocation"=>"0G", "format_type"=>"raw", "_delete"=>""}, "0"=>{"pool_name"=>"default", "capacity"=>"10G", "allocation"=>"0G", "format_type"=>"raw", "_delete"=>""}}, "start"=>"1"}, "domain_id"=>"2", "realm_id"=>"1", "mac"=>"", "subnet_id"=>"1", "ip"=>"192.168.100.12", "interfaces_attributes"=>{"new_interfaces"=>{"_destroy"=>"false", "type"=>"Nic::Managed", "mac"=>"", "name"=>"", "domain_id"=>"", "ip"=>"", "provider"=>"IPMI"}}, "architecture_id"=>"1", "operatingsystem_id"=>"1", "provision_method"=>"build", "build"=>"1", "ptable_id"=>"7", "disk"=>"", "root_pass"=>"[FILTERED]", "is_owned_by"=>"3-Users", "enabled"=>"1", "model_id"=>"", "comment"=>"", "overwrite"=>"false"}, "kt_environment_id"=>"", "capabilities"=>"build image", "provider"=>"Libvirt"}
Processing by TasksController#show as */*
  Parameters: {"id"=>"3f4c16c3-053f-4ea9-a839-6e5b6c343518"}
  Rendered tasks/_list.html.erb (1.2ms)
Completed 200 OK in 29ms (Views: 11.5ms | ActiveRecord: 1.6ms)
Processing by TasksController#show as */*
  Parameters: {"id"=>"3f4c16c3-053f-4ea9-a839-6e5b6c343518"}
  Rendered tasks/_list.html.erb (0.2ms)
Completed 200 OK in 448ms (Views: 1.6ms | ActiveRecord: 2.6ms)
Processing by TasksController#show as */*
  Parameters: {"id"=>"3f4c16c3-053f-4ea9-a839-6e5b6c343518"}
  Rendered tasks/_list.html.erb (0.1ms)
Completed 200 OK in 12ms (Views: 1.3ms | ActiveRecord: 1.2ms)
Processing by TasksController#show as */*
  Parameters: {"id"=>"3f4c16c3-053f-4ea9-a839-6e5b6c343518"}
  Rendered tasks/_list.html.erb (0.1ms)
Completed 200 OK in 12ms (Views: 1.5ms | ActiveRecord: 1.2ms)
Failed to save: Environment can't be blank
^[[1;32mDeface:^[[0m 1 overrides found for 'hosts/_form'
^[[1;32mDeface:^[[0m 'hosts_update_environments_select' matched 1 times with 'code[erb-loud]:contains("select_f"):contains(":environment_id")'
  Rendered hosts/_progress.html.erb (1.4ms)
=================================================================


Installed Packages

    candlepin-0.9.23-1.el6_5.noarch
    candlepin-common-1.0.1-1.el6_5.noarch
    candlepin-scl-1-5.el6_4.noarch
    candlepin-scl-quartz-2.1.5-5.el6_4.noarch
    candlepin-scl-rhino-1.7R3-1.el6_4.noarch
    candlepin-scl-runtime-1-5.el6_4.noarch
    candlepin-selinux-0.9.23-1.el6_5.noarch
    candlepin-tomcat6-0.9.23-1.el6_5.noarch
    createrepo-0.9.9-21.2.pulp.el6sat.noarch
    elasticsearch-0.90.10-4.el6sat.noarch
    katello-1.5.0-28.el6sat.noarch
    katello-ca-1.0-1.noarch
    katello-certs-tools-1.5.6-1.el6sat.noarch
    katello-installer-0.0.59-1.el6sat.noarch
    m2crypto-0.21.1.pulp-10.el6sat.x86_64
    mod_wsgi-3.4-1.pulp.el6sat.x86_64
    pulp-katello-0.3-3.el6sat.noarch
    pulp-nodes-common-2.4.0-0.30.beta.el6sat.noarch
    pulp-nodes-parent-2.4.0-0.30.beta.el6sat.noarch
    pulp-puppet-plugins-2.4.0-0.30.beta.el6sat.noarch
    pulp-puppet-tools-2.4.0-0.30.beta.el6sat.noarch
    pulp-rpm-plugins-2.4.0-0.30.beta.el6sat.noarch
    pulp-selinux-2.4.0-0.30.beta.el6sat.noarch
    pulp-server-2.4.0-0.30.beta.el6sat.noarch
    python-gofer-qpid-1.3.0-1.el6sat.noarch
    python-isodate-0.5.0-1.pulp.el6sat.noarch
    python-kombu-3.0.15-12.pulp.el6sat.noarch
    python-pulp-bindings-2.4.0-0.30.beta.el6sat.noarch
    python-pulp-common-2.4.0-0.30.beta.el6sat.noarch
    python-pulp-puppet-common-2.4.0-0.30.beta.el6sat.noarch
    python-pulp-rpm-common-2.4.0-0.30.beta.el6sat.noarch
    python-qpid-0.22-14.el6sat.noarch
    python-qpid-qmf-0.22-37.el6.x86_64
    qpid-cpp-client-0.22-42.el6.x86_64
    qpid-cpp-server-0.22-42.el6.x86_64
    qpid-cpp-server-linearstore-0.22-42.el6.x86_64
    qpid-java-client-0.22-6.el6.noarch
    qpid-java-common-0.22-6.el6.noarch
    qpid-proton-c-0.7-1.el6.x86_64
    qpid-qmf-0.22-37.el6.x86_64
    qpid-tools-0.22-12.el6.noarch
    ruby193-rubygem-katello-1.5.0-82.el6sat.noarch
    rubygem-hammer_cli_katello-0.0.4-12.el6sat.noarch
    rubygem-smart_proxy_pulp-1.0.0-1.1.el6sat.noarch

Comment 9 Bryan Kearney 2014-09-11 12:18:51 UTC
This was delivered with Satellite 6.0 which was released on 10 September 2014.

Comment 10 Dhaval 2015-02-05 05:26:09 UTC
This is still issue for me.

Comment 11 Brad Buckingham 2015-08-17 17:46:36 UTC
Hi Dhaval,

On Satellite 6.1.1 (which was recently GA'ed), I am seeing the proper error displayed when the puppet environment is omitted during a "New Host".  I am attaching the screenshot of my scenario.

If you are not seeing the error on your configuration, would you mind creating a new BZ with the details?  If possible, please attach the screenshot and foreman-debug output.

Thanks!

Comment 12 Brad Buckingham 2015-08-17 17:47:24 UTC
Created attachment 1064022 [details]
Puppet Environment : error shown on Satellite 6.1.1 UI


Note You need to log in before you can comment on or make changes to this bug.