Bug 1113951 - Review Request: perl-App-GitHooks - Extensible plugins system for git hooks
Summary: Review Request: perl-App-GitHooks - Extensible plugins system for git hooks
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-27 10:23 UTC by David Dick
Modified: 2014-07-04 09:05 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-07-04 09:05:03 UTC
Type: ---
Embargoed:
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description David Dick 2014-06-27 10:23:04 UTC
Spec URL: http://ddick.fedorapeople.org/packages/perl-App-GitHooks.spec
SRPM URL: http://ddick.fedorapeople.org/packages/perl-App-GitHooks-1.0.8-1.fc20.src.rpm
Description: Extensible plugins system for git hooks
Fedora Account System Username: ddick

Comment 1 David Dick 2014-06-27 10:23:36 UTC
koji build

rawhide at http://koji.fedoraproject.org/koji/taskinfo?taskID=7082490

Comment 2 David Dick 2014-06-28 04:39:30 UTC
maybe hooks should be put under libexec instead of doc?

Comment 3 Petr Šabata 2014-06-30 14:03:34 UTC
The License tag is incorrect.  All the files require at least GPLv3.

`Devel::Cover' and `lib' are only used in App::GitHooks::Test DATA section which I don't see used anywhere.  Perhaps it's a dead code?

Hmm, the `examples' directory isn't really all that useful for packaging.  I'm okay with it not being included in favour of the hooks themselves.

Comment 4 David Dick 2014-07-01 10:57:35 UTC
(In reply to Petr Šabata from comment #3)
> The License tag is incorrect.  All the files require at least GPLv3.

fixed

> `Devel::Cover' and `lib' are only used in App::GitHooks::Test DATA section
> which I don't see used anywhere.  Perhaps it's a dead code?

agreed.  builds fine without these BRs at http://koji.fedoraproject.org/koji/taskinfo?taskID=7095757

fixed and uploaded.

Comment 5 Petr Šabata 2014-07-01 14:33:57 UTC
Check.  Approving.

Comment 6 David Dick 2014-07-03 07:20:20 UTC
New Package SCM Request
=======================
Package Name: perl-App-GitHooks
Short Description: Extensible plugins system for git hooks
Upstream URL: http://search.cpan.org/dist/App-GitHooks/
Owners: ddick
Branches: f20
InitialCC: perl-sig

Thanks Petr!

Comment 7 Gwyn Ciesla 2014-07-03 12:06:44 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.