Bug 1113953

+++ This bug was initially created as a clone of Bug #1112968 +++

Description of problem:

systemctl Fail to  stop neutron-openvswitch-agent  

Have tested on compute/networker 

Version-Release number of selected component (if applicable):

openstack-neutron-2014.1-34.el7ost.noarch
How reproducible:


Steps to Reproduce:
1.systemctl stop neutron-openvswitch-agent 
2.systemctl status neutron-openvswitch-agent 
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Jakub Libosvar on 2014-06-25 12:41:51 CEST ---

IIUC this bug is about that openvswitch-agent returns 1 on SIGTERM.

--- Additional comment from Ofer Blaut on 2014-06-25 14:25:12 CEST ---

Will the return code will impact HA ? PaceMaker ?

--- Additional comment from lpeer on 2014-06-25 14:27:13 CEST ---

This could be problematic for the HA support. We'll need to address that before releasing HA.

--- Additional comment from Ihar Hrachyshka on 2014-06-25 14:29:04 CEST ---

From systemd.service(5):

       SuccessExitStatus=
           Takes a list of exit status definitions that when returned by the
           main service process will be considered successful termination, in
           addition to the normal successful exit code 0 and the signals
           SIGHUP, SIGINT, SIGTERM and SIGPIPE. Exit status definitions can
           either be numeric exit codes or termination signal names, separated
           by spaces. Example: "SuccessExitStatus=1 2 8 SIGKILL", ensures that
           exit codes 1, 2, 8 and the termination signal SIGKILL are
           considered clean service terminations. This option may appear more
           than once in which case the list of successful exit statuses is
           merged. If the empty string is assigned to this option the list is
           reset, all prior assignments of this option will have no effect.


So we may patch that in dist-git without touching Neutron code itself. Anyway, it's wrong that the agent returns 1 on successful exit, so this should also be patched in u/s.

--- Additional comment from Jakub Libosvar on 2014-06-25 14:43:43 CEST ---

(In reply to Ihar Hrachyshka from comment #4)
> From systemd.service(5):
> 
>        SuccessExitStatus=
This is very dangerous. In case there is error in config file, ovs-agent exits with 1. Same applies when tunneling cannot be set. systemd would report success even though agent failed to start.

--- Additional comment from Ihar Hrachyshka on 2014-06-25 14:58:55 CEST ---

Fair enough. Reporting a failure on success is not any better than reporting success on failure.