Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1114613

Summary: [RFE] missing 'Remove' action in subtab disks->storage, for template's disk copies
Product: [oVirt] ovirt-engine Reporter: Gilad Chaplik <gchaplik>
Component: RFEsAssignee: Tal Nisan <tnisan>
Status: CLOSED WONTFIX QA Contact: Aharon Canan <acanan>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: ---CC: amureini, bugs, dfediuck, gklein, iheim, mgoldboi, rbalakri, srevivo, ykaul, ylavi
Target Milestone: ---Keywords: FutureFeature, Improvement, UserExperience
Target Release: ---Flags: ylavi: ovirt-future?
ylavi: planning_ack?
ylavi: devel_ack?
ylavi: testing_ack?
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-13 14:49:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
disks->storage none

Description Gilad Chaplik 2014-06-30 13:44:31 UTC
Created attachment 913406 [details]
disks->storage

Description of problem:
The flow is well hidden under templates->storage, imo should be in disk->storage as well

Comment 1 Tal Nisan 2014-08-31 12:06:28 UTC
Both are two different subtabs although they are both title "storage", the one under the disks main tab is a unified one for all disks type (template, vm and floating) which shows the actual storage domain along with their status, the one under template shows a tree view of the storage and the template disks residing on, if we decide to add the remove template disk option under the disks main tab it means that we have to change the storage subtab under it to be the same storage tree view as in the storage subtab under the template main tab, Einav, what is your opinion?

Comment 2 Einav Cohen 2014-09-20 00:15:44 UTC
(In reply to Tal Nisan from comment #1)
> Both are two different subtabs although they are both title "storage", the
> one under the disks main tab is a unified one for all disks type (template,
> vm and floating) which shows the actual storage domain along with their
> status, the one under template shows a tree view of the storage and the
> template disks residing on, if we decide to add the remove template disk
> option under the disks main tab it means that we have to change the storage
> subtab under it to be the same storage tree view as in the storage subtab
> under the template main tab, Einav, what is your opinion?

it will be more consistent, but may seem strange since each storage-domain tree-node will contain only one disk child-node (representing the disk that is selected on the main tab). 

example:
assume template1 contains 3 disks: disk1, disk2, and disk3. 
assume disk1 resides on the following storage domains: sd1, sd2
assume disk2 resides on the following storage domains: sd2, sd3
assume disk3 resides on the following storage domains: sd1, sd3

the templates main-tab -> storage sub-tab for template1 will look as follows:

- sd1
  - disk1
  - disk3
- sd2
  - disk1
  - disk2
- sd3
  - disk2
  - disk3

if a similar tree-view will be displayed in the disks main-tab -> storage sub-tab, this is how it would look for disk1:

- sd1
  - disk1
- sd2
  - disk1

so there is no real need to display the "disk1" child nodes here - it is enough simply to display:

- sd1
- sd2

and perform the "Remove" action on the storage-domains. 

my advice is to keep the view as is and add the action-button, but maybe not title it "Remove" (since you are not removing the storage domain; you are removing the disk 'instance' from the storage domain). so something like "Remove from Domain".

Comment 4 Yaniv Lavi 2016-07-13 14:49:57 UTC
Not seeing this happening for now. Please reopen if you think its still relevant.