Bug 1114682 - Review Request: python-OWSLib - Work with OGC map, feature, and coverage services
Summary: Review Request: python-OWSLib - Work with OGC map, feature, and coverage serv...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Eduardo Mayorga
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2014-06-30 15:56 UTC by Volker Fröhlich
Modified: 2015-07-08 17:05 UTC (History)
3 users (show)

Fixed In Version: python-OWSLib-0.9.0-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2014-08-29 02:03:10 UTC
e: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Volker Fröhlich 2014-06-30 15:56:10 UTC
Spec URL: http://www.geofrogger.net/review/python-OWSLib.spec
SRPM URL: http://www.geofrogger.net/review/python-OWSLib-0.8.7-1.fc19.src.rpm

Package for client programming with Open Geospatial Consortium (OGC) web
service (hence OWS) interface standards, and their related content models.

Fedora Account System Username: volter

This package is a dependency for QGIS 2.4.

Comment 1 Eduardo Mayorga 2014-06-30 23:48:27 UTC
Please correct this:

- python-setuptools-devel will be removed for the next release. Change that to python-setuptools

And also:

- This package provides a test suite, which BuildRequires pytest. You can (and should) add this at %check.

Comment 2 Volker Fröhlich 2014-07-01 14:52:45 UTC
Spec URL: http://www.geofrogger.net/review/python-OWSLib.spec
SRPM URL: http://www.geofrogger.net/review/python-OWSLib-0.8.7-2.fc19.src.rpm

Corrected BR

The test suite is not included in the tarball, thus can't be executed.

Comment 3 Eduardo Mayorga 2014-07-02 04:12:18 UTC
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.

Checking: python-OWSLib-0.8.7-2.fc20.noarch.rpm
python-OWSLib.noarch: W: invalid-url URL: http://geopython.github.io/OWSLib <urlopen error [Errno -2] Name or service not known>
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

Rpmlint (installed packages)
# rpmlint python-OWSLib
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
# echo 'rpmlint-done:'

python-OWSLib (rpmlib, GLIBC filtered):


Source checksums
http://pypi.python.org/packages/source/O/OWSLib/OWSLib-0.8.7.tar.gz :
  CHECKSUM(SHA256) this package     : a1d4e4d5985c15146befde5bb521ccd458f6d7caa58a099cf58669cc2c15c8dd
  CHECKSUM(SHA256) upstream package : a1d4e4d5985c15146befde5bb521ccd458f6d7caa58a099cf58669cc2c15c8dd

Have you queried upstream about tests? It would be useful for us to get them included in the tarball.


Comment 4 Volker Fröhlich 2014-07-02 05:54:40 UTC
I'll ask!

Comment 5 Volker Fröhlich 2014-07-02 06:37:29 UTC
New Package SCM Request
Package Name: python-OWSLib
Short Description: Client library for OGC web services
Upstream URL: http://geopython.github.io/OWSLib
Owners: volter
Branches: f20

Comment 6 Gwyn Ciesla 2014-07-02 10:11:37 UTC
Git done (by process-git-requests).

Comment 7 Eduardo Mayorga 2014-08-29 02:03:10 UTC
Closing this as it was already pushed to stable.


Comment 8 Dave Johansen 2015-06-13 22:50:50 UTC
Package Change Request
Package Name: python-OWSLib
New Branches: epel6 epel7
Owners: daveisfera
InitialCC: volter

Comment 9 Volker Fröhlich 2015-06-14 08:01:03 UTC
As the owner, I approve this change request.

Comment 10 Gwyn Ciesla 2015-06-14 13:26:12 UTC
Git done (by process-git-requests).

Comment 11 Fedora Update System 2015-06-15 02:40:05 UTC
python-OWSLib-0.9.0-1.el7 has been submitted as an update for Fedora EPEL 7.

Comment 12 Fedora Update System 2015-06-16 13:38:42 UTC
python-OWSLib-0.9.0-1.el6 has been submitted as an update for Fedora EPEL 6.

Comment 13 Fedora Update System 2015-07-08 17:04:36 UTC
python-OWSLib-0.9.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 14 Fedora Update System 2015-07-08 17:05:21 UTC
python-OWSLib-0.9.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository.

Note You need to log in before you can comment on or make changes to this bug.