Bug 1114924

Description of problem:
Possible missing string terminator in ioprocess logging. Some logging lines still contain garbage from previous logs.

I am temporarily filing this under the vdsm component because I couldn't find the appropriate one.

Version-Release number of selected component (if applicable):
python-ioprocess-0.5.0-2.el6_5.noarch
ioprocess-0.5.0-2.el6_5.x86_64

How reproducible:
100%

Steps to Reproduce:
1. use ioprocess (e.g. vdsm) with debug logging

Actual results:
Logging seems to contain garbage from the previous lines.

Expected results:
Logging should be clean.

Additional info:
Looking at lines 8, 9 and 10 it seems that string inside the parenthesis still contains garbage from a previous log (line 6). The same happens for line 14, 18, 20, 21, etc.
It seems that the string in the buffer used for the text inside the parenthesis is missing the terminator '\0'.

  1 OProcess::(_processLogs) Closing unrelated FDs...
  2 OProcess::(_processLogs) Closing unrelated fd no: 0 (pipe:[154531])
  3 OProcess::(_processLogs) Not closing FD 1 because it's in whitelist
  4 OProcess::(_processLogs) Not closing FD 2 because it's in whitelist
  5 OProcess::(_processLogs) Closing unrelated fd no: 3 (socket:[152767])
  6 OProcess::(_processLogs) Closing unrelated fd no: 4 (/var/log/vdsm/vdsm.log)
  7 OProcess::(_processLogs) Not closing FD 5 because it's the directory fd
  8 OProcess::(_processLogs) Closing unrelated fd no: 9 ([eventpoll]sm/vdsm.log)
  9 OProcess::(_processLogs) Closing unrelated fd no: 10 (socket:[152781]dsm.log)
 10 OProcess::(_processLogs) Closing unrelated fd no: 11 (socket:[152887]dsm.log)
 11 OProcess::(_processLogs) Closing unrelated fd no: 12 (/var/log/vdsm/mom.logg)
 12 OProcess::(_processLogs) Closing unrelated fd no: 13 (/proc/meminfo/mom.logg)
 13 OProcess::(_processLogs) Closing unrelated fd no: 14 (/proc/vmstato/mom.logg)
 14 OProcess::(_processLogs) Closing unrelated fd no: 15 (socket:[152836]om.logg)
 15 OProcess::(_processLogs) Closing unrelated fd no: 16 (/sys/kernel/mm/ksm/full_scans)
 16 OProcess::(_processLogs) Closing unrelated fd no: 17 (/sys/kernel/mm/ksm/pages_sharing)
 17 OProcess::(_processLogs) Closing unrelated fd no: 18 (pipe:[154528]m/ksm/pages_sharing)
 18 OProcess::(_processLogs) Closing unrelated fd no: 19 (/sys/kernel/mm/ksm/pages_unshared)
 19 OProcess::(_processLogs) Closing unrelated fd no: 20 (socket:[154526]ksm/pages_unshared)
 20 OProcess::(_processLogs) Closing unrelated fd no: 21 (pipe:[154528]6]ksm/pages_unshared)
 21 OProcess::(_processLogs) Closing unrelated fd no: 22 (/sys/kernel/mm/ksm/runes_unshared)
 22 OProcess::(_processLogs) Closing unrelated fd no: 23 (pipe:[154529]m/ksm/runes_unshared)
 23 OProcess::(_processLogs) Closing unrelated fd no: 24 (/sys/kernel/mm/ksm/pages_shareded)
 24 OProcess::(_processLogs) Closing unrelated fd no: 25 (/sys/kernel/mm/ksm/pages_to_scand)
 25 OProcess::(_processLogs) Closing unrelated fd no: 26 (/sys/kernel/mm/ksm/pages_volatile)
 26 OProcess::(_processLogs) Closing unrelated fd no: 27 (/sys/kernel/mm/ksm/sleep_millisecs)
 27 OProcess::(_processLogs) Closing unrelated fd no: 33 (socket:[152905]ksm/sleep_millisecs)
 28 OProcess::(_processLogs) Closing unrelated fd no: 34 (/proc/cpuinfo5]ksm/sleep_millisecs)
 29 OProcess::(_processLogs) Closing unrelated fd no: 35 (pipe:[152921]5]ksm/sleep_millisecs)
 30 OProcess::(_processLogs) Closing unrelated fd no: 38 (pipe:[152921]5]ksm/sleep_millisecs)
 31 OProcess::(_processLogs) Closing unrelated fd no: 39 (socket:[152936]ksm/sleep_millisecs)
 32 OProcess::(_processLogs) Not closing FD 40 because it's in whitelist
 33 OProcess::(_processLogs) Not closing FD 41 because it's in whitelist
 34 OProcess::(_processLogs) Closing unrelated fd no: 42 (pipe:[154530]6]ksm/sleep_millisecs)