Bug 1114950

Created attachment 913721 [details]
Reproducer source code

Description of problem:
When creating a javamail Session with provided custom Authenticator, class of this Auth. is used for loading /META-INF/javamail.default.providers and /META-INF/javamail.default.address.map resources. These resources located in the javamail jar will not be found when the Authenticator class uses different classloader (e.g. is supplied with user application).

However, this is not a big issue if user does not provide his own javamail.providers file, but if he does, he effectively bypasses the if section at line 907 causing only the specified providers to be loaded (the default providers are not loaded at all).

The code responsible is in javax.mail.Session#loadProviders(Class cl) at line 905:
  loadResource("/META-INF/javamail.default.providers", cl, loader);
and javax.mail.Session#loadAddressMap(Class cl) at line 1021:
  ladResource("/META-INF/javamail.default.address.map", cl, loader);

I don't think it makes sense to look for these defaults in the user application and not in the mail.jar, where they are located. Therefore, I would suggest changing the lines above to:
  loadResource("/META-INF/javamail.default.providers", this.getClass(), loader);
and
  loadResource("/META-INF/javamail.default.address.map", this.getClass(), loader);

I have built and tested it and it seems to solve the problem.


Version-Release number of selected component (if applicable):
mail-1.4.5-redhat-1.jar

Steps to Reproduce:
0. Build the reproducer attached- run "mvn clean package"
1. Deploy the reproducer
2. Go to http://localhost:8080/mail-reproducer/index.jsf
3. Click the button- this creates JavaMail session
4. In the log, observe that both resources were not found and defaults (from source code) are used.
5. Rename javamail.providersX to javamail.providers, build the reproducer go through steps 1. to 3. again.
6. Observe that only the specified dummy provider is registered and the defaults are not included.

Actual results:
Default providers are not loaded.

Expected results:
Default providers should be loaded at all times.