Bug 1114952 - Merge python3-chardet with python-chardet
Summary: Merge python3-chardet with python-chardet
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python3-chardet
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Orphan Owner
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-07-01 10:33 UTC by Miro Hrončok
Modified: 2014-07-02 16:55 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-07-02 16:55:43 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Miro Hrončok 2014-07-01 10:33:01 UTC
Previously, upstream of chardet kept separate codebase for Python 2 and 3. This has changed and they only keep one code for all.

I'm proposing to retire python3-chardet and build python3-chardet as a subpackage of python-chardet. The benefit is to keep things simple and have less work in future when updating.

I'm willing to do the necessary update of python-chardet if gained consent.

Comment 1 Thomas Spura 2014-07-02 14:55:44 UTC
(In reply to Miro Hrončok from comment #0)
> Previously, upstream of chardet kept separate codebase for Python 2 and 3.
> This has changed and they only keep one code for all.

Great!

> I'm proposing to retire python3-chardet and build python3-chardet as a
> subpackage of python-chardet. The benefit is to keep things simple and have
> less work in future when updating.

In principle, yes. I don't know the current state of the effort of using python3 as default. Maybe we would need to rename all python-* packages to python3-* and leave the python-* ones as "the ones using python2"?
Do you maybe know, how exactly this transition will go on?

> I'm willing to do the necessary update of python-chardet if gained consent.

I concur, please do the necessary update (if we won't have to re-review python3-chardet because of the above...).
Thanks! :)

Comment 2 Miro Hrončok 2014-07-02 15:06:37 UTC
(In reply to Thomas Spura from comment #1)
> Maybe we would need to rename all python-* packages to
> python3-* and leave the python-* ones as "the ones using python2"?
> Do you maybe know, how exactly this transition will go on?

I don't know exactly how the transition will work, but python- prefixed SRPMs are going to stay. Maybe both Python 2 and Python 3 packages would be a submodule of that  (rally just maybe), but I know that mergning python3-chardet and python-chardet to python-chardet is not a step aside.

Comment 3 Miro Hrončok 2014-07-02 15:07:55 UTC
s/submodule/subpackage

Comment 4 Thomas Spura 2014-07-02 15:13:24 UTC
(In reply to Miro Hrončok from comment #2)
> (In reply to Thomas Spura from comment #1)
> > Maybe we would need to rename all python-* packages to
> > python3-* and leave the python-* ones as "the ones using python2"?
> > Do you maybe know, how exactly this transition will go on?
> 
> I don't know exactly how the transition will work, but python- prefixed
> SRPMs are going to stay. Maybe both Python 2 and Python 3 packages would be
> a submodule of that  (rally just maybe), but I know that mergning
> python3-chardet and python-chardet to python-chardet is not a step aside.

Ok, them I'm all in.

Comment 5 Miro Hrončok 2014-07-02 15:14:39 UTC
Kushal is also in favor (confirmed on IRC)

Comment 6 Miro Hrončok 2014-07-02 16:05:06 UTC
Thomas, please go ahead and retire python3-chardet in pkgdb (I've done it in git):

$ pkgdb-cli orphan --retire python3-chardet master

Comment 8 Fedora Admin XMLRPC Client 2014-07-02 16:37:17 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 9 Thomas Spura 2014-07-02 16:38:05 UTC
(In reply to Miro Hrončok from comment #6)
> Thomas, please go ahead and retire python3-chardet in pkgdb (I've done it in
> git):
> 
> $ pkgdb-cli orphan --retire python3-chardet master

Done, thanks for working on it!

Comment 10 Miro Hrončok 2014-07-02 16:55:43 UTC
Thanks for your cooperation.


Note You need to log in before you can comment on or make changes to this bug.