Bug 1114990
| Summary: | Search: Clusters main tab is not sorted by name by default | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] oVirt | Reporter: | Allon Mureinik <amureini> | ||||||||
| Component: | ovirt-engine-webadmin | Assignee: | Eli Mesika <emesika> | ||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Pavel Stehlik <pstehlik> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | 3.5 | CC: | amureini, bazulay, bugs, ecohen, gklein, iheim, mgoldboi, rbalakri, sbonazzo, yeylon | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | 3.5.0 | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | infra | ||||||||||
| Fixed In Version: | ovirt-3.5.0-beta2 | Doc Type: | Bug Fix | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2014-10-17 12:34:23 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | Infra | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Allon Mureinik
2014-07-01 11:52:25 UTC
Created attachment 913731 [details]
Snapshot of wrongly sorted clusters
Additional info: this happens both in the System context and under a DC context. Created attachment 916187 [details]
screen-shots: Clusters are not sorted even if sorted explicitly
Created attachment 916188 [details]
rest-api Clusters are not sorted as well
the Clusters main tab should be sorted by name by default, based on the default sorting mentioned in SearchObjectAutoCompleter.java line ~329 [1]. however, it seems that something is wrong there and items don't get sorted. even when I try to explicitly sort by name (either asc or desc), I still get the non-sorted results (see attachment 916187 [details]). Note that the non-sorted results that I get for 'asc' are different than the unsorted results that I get for 'desc'. [specifically in my setup, the default page-size (i.e. the config's "SearchResultsLimit") is 5, not the default 100. shouldn't affect anything] in the rest-api, I am getting unsorted results as well (see attachment 916188 [details]), however I am not sure if the list of clusters is retrieved there via Search or not, so not sure if relevant here or not. the (unsorted) order of the items in the rest-api doesn't match the (unsorted) order of items in the GUI. [1] SearchObjectAutoCompleter.java, line ~329 ... put(SearchObjects.VDC_CLUSTER_OBJ_NAME, new EntitySearchInfo(new ClusterCrossRefAutoCompleter(), new ClusterConditionFieldAutoCompleter(), "vds_groups_view", "vds_groups_storage_domain", "vds_group_id", "name ASC ")); /* this is the default sorting for the Clusters search in case an explicit "sortby" is not mentioned in the Search string */ .... I was unable to reproduce on latest and I got the correct results from both UI and REST API. Will test also on the 3.5 branch Can not reproduce on 3.5 branch either (UI & API). Alon, can you recheck please if you can reproduce that (In reply to Eli Mesika from comment #7) > Can not reproduce on 3.5 branch either (UI & API). > Alon, can you recheck please if you can reproduce that Confirmed, I cannot reproduce with an engine built from source either from the latest master (commit 759ab746647acdf20256642d65dba10d95e1850d) or the latest ovirt-engine-3.5 branch (commit d8c81fe85e504bac006046e3c2fb6d21f3b96648). I believe that the following commit fixed this issue: commit 2c16f9ee91bea30ceb3c263e730ffb3b96cb3a4a Author: Alexander Wels <awels> Date: Wed Jun 4 09:25:33 2014 -0400 webadmin: cluster sorting - Implemented sorting in cluster main tab - Implemented sorting in cluster sub tabs. - Fixed bug that would cause invalid SQL to be generated when sorting. - Fixed bug that caused sorting to be ignored when updating hosts and VMs for clusters. Change-Id: Ib7b2d9938a7e9b7e32238a284c0ddca6568b3bdc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1119873 Signed-off-by: Alexander Wels <awels> This was merged to the ovirt-engine-3.5 on July 15th, after beta1 was released and this bug filed against it. Moving to MODIFIED based on the above info. Verified on ovirt-engine-3.5.0-0.0.master.20140722232058.git8e1babc.el6.noarch. oVirt 3.5 has been released and should include the fix for this issue. |