Spec URL: http://fsimonce.fedorapeople.org//ceph-deploy.spec SRPM URL: http://fsimonce.fedorapeople.org//ceph-deploy-1.5.6-1.fc21.src.rpm Description: An easy to use admin tool for deploy ceph storage clusters.
This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7098638
https://fedoraproject.org/wiki/Packaging:Python#Macros
Not the latest : https://pypi.python.org/pypi/ceph-deploy
Spec URL: http://fsimonce.fedorapeople.org//ceph-deploy.spec SRPM URL: http://fsimonce.fedorapeople.org//ceph-deploy-1.5.7-1.fc21.src.rpm
Not finished yet: 1. Source0: %{name}-%{version}.tar.xz Please use the full URL. 2. BuildRequires: python-devel -> BuildRequires: python2-devel 3. CEPH_DEPLOY_NO_VENDOR=1 %{__python} setup.py build -> CEPH_DEPLOY_NO_VENDOR=1 %{__python2} setup.py build 4. %{python_sitelib}/* -> %{python2_sitelib}/* -------------------------- Although RHEL6 is an important market of ceph indeed, you still need to care about macros: %if 0%{?rhel} && 0%{?rhel} <= 6 %{!?__python2: %global __python2 /usr/bin/python2} %{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} %endif 5. Requires: python-remoto >= 0.0.17 This is a new package in Fedora + EPEL(?/RHEL?), I don't think you need to specify the version.
(In reply to Christopher Meng from comment #5) > Not finished yet: > > 1. Source0: %{name}-%{version}.tar.xz There's a comment on how to fetch the sources. Anyway the downloaded tgz is not in the format of %{name}-%{version} (which is the preferred one for the setup command). I don't think it's worth the trouble to support the direct link and then have to tweak %setup to match what's downloadable. > Although RHEL6 is an important market of ceph indeed, you still need to care > about macros: > > %if 0%{?rhel} && 0%{?rhel} <= 6 > %{!?__python2: %global __python2 /usr/bin/python2} > %{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from > distutils.sysconfig import get_python_lib; print(get_python_lib())")} > %endif The spec file you just reviewed contained these macros so it should have been fine. The rest should be now fixed (build verified both on f21 and el6): Spec URL: http://fsimonce.fedorapeople.org//ceph-deploy.spec SRPM URL: http://fsimonce.fedorapeople.org//ceph-deploy-1.5.7-1.fc21.src.rpm
Swap with bug 1058090.
Christopher any update on this? Now that python-remoto has been built we can proceed with this one.
(In reply to Federico Simoncelli from comment #8) > Christopher any update on this? Now that python-remoto has been built we can > proceed with this one. I will review this tomorrow, as I can only get the RPM from since tomorrow's rawhide repo. Thanks.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 86 files have unknown license. Detailed output of licensecheck: Unknown or generated -------------------- ceph-deploy-1.5.7/ceph_deploy/__init__.py ceph-deploy-1.5.7/ceph_deploy/admin.py ceph-deploy-1.5.7/ceph_deploy/calamari.py ceph-deploy-1.5.7/ceph_deploy/cli.py ceph-deploy-1.5.7/ceph_deploy/cliutil.py ceph-deploy-1.5.7/ceph_deploy/conf/__init__.py ceph-deploy-1.5.7/ceph_deploy/conf/ceph.py ceph-deploy-1.5.7/ceph_deploy/conf/cephdeploy.py ceph-deploy-1.5.7/ceph_deploy/config.py ceph-deploy-1.5.7/ceph_deploy/connection.py ceph-deploy-1.5.7/ceph_deploy/exc.py ceph-deploy-1.5.7/ceph_deploy/forgetkeys.py ceph-deploy-1.5.7/ceph_deploy/gatherkeys.py ceph-deploy-1.5.7/ceph_deploy/hosts/__init__.py ceph-deploy-1.5.7/ceph_deploy/hosts/centos/__init__.py ceph-deploy-1.5.7/ceph_deploy/hosts/centos/install.py ceph-deploy-1.5.7/ceph_deploy/hosts/centos/mon/__init__.py ceph-deploy-1.5.7/ceph_deploy/hosts/centos/mon/create.py ceph-deploy-1.5.7/ceph_deploy/hosts/centos/pkg.py ceph-deploy-1.5.7/ceph_deploy/hosts/centos/uninstall.py ceph-deploy-1.5.7/ceph_deploy/hosts/common.py ceph-deploy-1.5.7/ceph_deploy/hosts/debian/__init__.py ceph-deploy-1.5.7/ceph_deploy/hosts/debian/install.py ceph-deploy-1.5.7/ceph_deploy/hosts/debian/mon/__init__.py ceph-deploy-1.5.7/ceph_deploy/hosts/debian/mon/create.py ceph-deploy-1.5.7/ceph_deploy/hosts/debian/pkg.py ceph-deploy-1.5.7/ceph_deploy/hosts/debian/uninstall.py ceph-deploy-1.5.7/ceph_deploy/hosts/fedora/__init__.py ceph-deploy-1.5.7/ceph_deploy/hosts/fedora/install.py ceph-deploy-1.5.7/ceph_deploy/hosts/fedora/mon/__init__.py ceph-deploy-1.5.7/ceph_deploy/hosts/fedora/mon/create.py ceph-deploy-1.5.7/ceph_deploy/hosts/fedora/uninstall.py ceph-deploy-1.5.7/ceph_deploy/hosts/remotes.py ceph-deploy-1.5.7/ceph_deploy/hosts/suse/__init__.py ceph-deploy-1.5.7/ceph_deploy/hosts/suse/install.py ceph-deploy-1.5.7/ceph_deploy/hosts/suse/mon/__init__.py ceph-deploy-1.5.7/ceph_deploy/hosts/suse/mon/create.py ceph-deploy-1.5.7/ceph_deploy/hosts/suse/pkg.py ceph-deploy-1.5.7/ceph_deploy/hosts/suse/uninstall.py ceph-deploy-1.5.7/ceph_deploy/install.py ceph-deploy-1.5.7/ceph_deploy/lib/__init__.py ceph-deploy-1.5.7/ceph_deploy/mds.py ceph-deploy-1.5.7/ceph_deploy/misc.py ceph-deploy-1.5.7/ceph_deploy/mon.py ceph-deploy-1.5.7/ceph_deploy/new.py ceph-deploy-1.5.7/ceph_deploy/osd.py ceph-deploy-1.5.7/ceph_deploy/pkg.py ceph-deploy-1.5.7/ceph_deploy/tests/conftest.py ceph-deploy-1.5.7/ceph_deploy/tests/directory.py ceph-deploy-1.5.7/ceph_deploy/tests/fakes.py ceph-deploy-1.5.7/ceph_deploy/tests/test_cli.py ceph-deploy-1.5.7/ceph_deploy/tests/test_cli_install.py ceph-deploy-1.5.7/ceph_deploy/tests/test_cli_mon.py ceph-deploy-1.5.7/ceph_deploy/tests/test_cli_new.py ceph-deploy-1.5.7/ceph_deploy/tests/test_cli_osd.py ceph-deploy-1.5.7/ceph_deploy/tests/test_conf.py ceph-deploy-1.5.7/ceph_deploy/tests/test_mon.py ceph-deploy-1.5.7/ceph_deploy/tests/test_remotes.py ceph-deploy-1.5.7/ceph_deploy/tests/unit/hosts/test_centos.py ceph-deploy-1.5.7/ceph_deploy/tests/unit/hosts/test_hosts.py ceph-deploy-1.5.7/ceph_deploy/tests/unit/test_calamari.py ceph-deploy-1.5.7/ceph_deploy/tests/unit/test_conf.py ceph-deploy-1.5.7/ceph_deploy/tests/unit/test_mon.py ceph-deploy-1.5.7/ceph_deploy/tests/unit/test_osd.py ceph-deploy-1.5.7/ceph_deploy/tests/unit/util/test_arg_validators.py ceph-deploy-1.5.7/ceph_deploy/tests/unit/util/test_constants.py ceph-deploy-1.5.7/ceph_deploy/tests/unit/util/test_paths.py ceph-deploy-1.5.7/ceph_deploy/tests/unit/util/test_pkg_managers.py ceph-deploy-1.5.7/ceph_deploy/tests/unit/util/test_templates.py ceph-deploy-1.5.7/ceph_deploy/util/arg_validators.py ceph-deploy-1.5.7/ceph_deploy/util/constants.py ceph-deploy-1.5.7/ceph_deploy/util/decorators.py ceph-deploy-1.5.7/ceph_deploy/util/log.py ceph-deploy-1.5.7/ceph_deploy/util/net.py ceph-deploy-1.5.7/ceph_deploy/util/paths/__init__.py ceph-deploy-1.5.7/ceph_deploy/util/paths/mon.py ceph-deploy-1.5.7/ceph_deploy/util/paths/osd.py ceph-deploy-1.5.7/ceph_deploy/util/pkg_managers.py ceph-deploy-1.5.7/ceph_deploy/util/ssh.py ceph-deploy-1.5.7/ceph_deploy/util/templates.py ceph-deploy-1.5.7/ceph_deploy/validate.py ceph-deploy-1.5.7/docs/source/conf.py ceph-deploy-1.5.7/scripts/build-debian.sh ceph-deploy-1.5.7/scripts/build-rpm.sh ceph-deploy-1.5.7/setup.py ceph-deploy-1.5.7/vendor.py [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: ceph-deploy-1.5.7-1.fc21.noarch.rpm ceph-deploy-1.5.7-1.fc21.src.rpm ceph-deploy.noarch: W: no-manual-page-for-binary ceph-deploy ceph-deploy.src:14: W: macro-in-comment %{name} ceph-deploy.src:14: W: macro-in-comment %{version} ceph-deploy.src: W: invalid-url Source0: ceph-deploy-1.5.7.tar.xz 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint ceph-deploy ceph-deploy.noarch: W: no-manual-page-for-binary ceph-deploy 1 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- ceph-deploy (rpmlib, GLIBC filtered): /usr/bin/python2 python(abi) python-remoto Provides -------- ceph-deploy: ceph-deploy Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -rvn ceph-deploy-1.5.7-1.fc21.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ------------------------------------------ 1. You could do somthing in the %check, I found some unit tests. 2. Not the latest version.
Spec URL: http://fsimonce.fedorapeople.org/ceph-deploy.spec SRPM URL: http://fsimonce.fedorapeople.org/ceph-deploy-1.5.8-1.fc21.src.rpm
PACKAGE APPROVED.
Extra: 1.5.9 is out... Annoying, please update in the SCM.
New Package SCM Request ======================= Package Name: ceph-deploy Short Description: Admin and deploy tool for Ceph Upstream URL: http://github.com/ceph/ceph-deploy Owners: fsimonce Branches: f21 InitialCC:
Git done (by process-git-requests).
First build here: http://koji.fedoraproject.org/koji/buildinfo?buildID=544835
Package Change Request ====================== Package Name: ceph-deploy New Branches: f19 f20 el6 epel7 Owners: ktdreyer fsimonce
For the record: One of the primary upstream developers for ceph-deploy is Travis Rhoden (FAS trhoden), and I've sponsored him in the packagers group in order to co-maintain this package with me. https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#Become_a_co-maintainer