Bug 1115525 - jsvc in different directories
Summary: jsvc in different directories
Keywords:
Status: CLOSED EOL
Alias: None
Product: JBoss Enterprise Web Server 2
Classification: JBoss
Component: unspecified
Version: 2.1.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: CR01
: 2.1.0
Assignee: Weinan Li
QA Contact: Libor Fuka
URL:
Whiteboard:
Depends On:
Blocks: 864715
TreeView+ depends on / blocked
 
Reported: 2014-07-02 14:10 UTC by Libor Fuka
Modified: 2019-06-13 12:09 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Previously in JBoss Enterprise Web Server, when using the Red Hat Enterprise Linux version, the jsvc binary was missing from the <filename class="directory">tomcat6/bin</filename> directory. For the Oracle Solaris version, jsvc was not available in the <filename class="directory">share/extras</filename> directory. As a result, when the JSVC environment variable was not set, the <filename>daemon.sh</filename> script in the <filename class="directory">tomcat{6,7}/bin</filename> directory sets the value of JSVC to <literal>$CATALINA_BASE/bin/jsvc</literal>, which is incorrect. This is fixed in JBoss Enterprise Web Server 2.1 and the jsvc binary file is available as expected in the <filename class="directory">tomcat6/bin</filename> directory for Red Hat Enterprise Linux and in the <filename class="directory">share/extras</filename> directory for Oracle Solaris.
Clone Of:
Environment:
Last Closed: 2019-06-13 12:09:56 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Libor Fuka 2014-07-02 14:10:59 UTC
Description of problem:
for RHEL:
=========
We have jsvc binary in extras directory and also in tomcat7/bin directory but we don't have jsvc in tomca6/bin.

for Solaris:
============
We don't have jsvc binary in share/extras directory 
we have it only in share/tomcat7/bin

daemon.sh script in tomcat6/bin and tomcat7/bin is setting JSVC="$CATALINA_BASE/bin/jsvc" if environment variable JSVC is not set.

Version-Release number of selected component (if applicable):
2.1.0-ER4


Expected results:
We should have jsvc binary in the same location through the platforms and tomcatX/daemon.sh scripts should reference jsvc binary in correct place.

Comment 2 Weinan Li 2014-07-10 04:45:50 UTC
Mladen, do you have any suggestions on this?

Comment 3 Mladen Turk 2014-07-10 05:06:44 UTC
For Solaris the jsvc binary is inside jboss-ews-2.1/sbin
The only thing we are missing is symlink for tomcat6/bin/jsvc which we have for tomcat7. The same should be done for RHEL's tomcat6.

Comment 4 Mladen Turk 2014-07-10 05:18:19 UTC
I have added symlink for tomcat6/bin/jsvc for Solaris.
Weinan could you do the same for RHEL?

Comment 5 Weinan Li 2014-07-10 06:12:06 UTC
(In reply to Mladen Turk from comment #4)
> I have added symlink for tomcat6/bin/jsvc for Solaris.
> Weinan could you do the same for RHEL?

Thanks for checking Mladen! I'll deal with the symlink for tc6 on rhel

Comment 6 Libor Fuka 2014-07-10 06:36:54 UTC
Weinan, please check all RHEL zips. The jsvc is also in extra directory nad in tomcat7/bin. It should be in one place (extra directory probabaly) and symlinks from tomcat7/bin and tomcat6/bin.
Thx

Comment 7 Weinan Li 2014-07-10 07:14:41 UTC
Mladen, could you please tell me how do you create the symlink?

If I create symlink with relative path, I found it won't be very helpful:

master:jboss-ews-2.1 weinanli$ ls -l tomcat6/bin/jsvc
lrwxr-xr-x  1 weinanli  staff  16 Jul 10 14:19 tomcat6/bin/jsvc -> tomcat7/bin/jsvc

Then users can only run jsvc in $JBOSS_EWS_HOME, other locations will fail.

IF I create a symlink with absolute path, I found it's hard to determine the absolute path during build time because we can't decide which directory will user put EWS in.

So maybe copy the 'jsvc' from tc7 into tc6 is better:

master:jboss-ews-2.1 weinanli$ cp tomcat7/bin/jsvc tomcat6/bin/jsvc
master:jboss-ews-2.1 weinanli$ find . -name jsvc
./extras/jsvc
./tomcat6/bin/jsvc
./tomcat7/bin/jsvc

wdyt?

Comment 8 Mladen Turk 2014-07-10 07:17:44 UTC
Inside TomcatX/bin directory I do
ln -s ../../../sbin/jsvc jsvc
So you can do something like
ln -s ../../../shared/extra/jsvc jsvc

Comment 10 Libor Fuka 2014-07-10 07:57:06 UTC
Its historic reason i think. We should not change it in last ER.

Comment 11 Weinan Li 2014-07-10 13:58:40 UTC
Patch added into jboss-ews:

+# BZ1115525
+rm -rf ./tomcat6/bin/jsvc
+rm -rf ./tomcat7/bin/jsvc
+
+tomcat_vers=("6" "7")
+for tomcat_ver in "${tomcat_vers[@]}"
+do
+       pushd tomcat${tomcat_ver}/bin
+       ln -s ../../extras/jsvc jsvc
+       popd
+done
+

Will be included in next release.

Comment 12 Michal Haško 2014-07-28 17:38:05 UTC
VERIFIED on:
jboss-ews-application-servers-2.1.0-CR2-RHEL5-i386.zip
jboss-ews-application-servers-2.1.0-CR2-RHEL5-x86_64.zip
jboss-ews-application-servers-2.1.0-CR2-RHEL6-i386.zip
jboss-ews-application-servers-2.1.0-CR2-RHEL6-x86_64.zip
jboss-ews-application-servers-2.1.0-CR2-RHEL7-ppc64.zip
jboss-ews-application-servers-2.1.0-CR2-RHEL7-x86_64.zip
jboss-ews-application-servers-2.1.0-CR2-sun10.i386.zip
jboss-ews-application-servers-2.1.0-CR2-sun10.sparc64.zip
jboss-ews-application-servers-2.1.0-CR2-sun10.x86_64.zip


Note You need to log in before you can comment on or make changes to this bug.