Bug 1115607 - Edit Domain dialogue box fails to resize for over 13 lines on the vertical
Summary: Edit Domain dialogue box fails to resize for over 13 lines on the vertical
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.4.0
Hardware: x86_64
OS: All
low
low
Target Milestone: ovirt-4.3.0
: 4.3.0
Assignee: shani
QA Contact: Evelina Shames
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-07-02 18:18 UTC by Robert McSwain
Modified: 2019-05-08 12:37 UTC (History)
11 users (show)

Fixed In Version: ovirt-engine-4.3.0_alpha
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-05-08 12:36:47 UTC
oVirt Team: Storage
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2019:1085 0 None None None 2019-05-08 12:37:29 UTC
oVirt gerrit 92122 0 master MERGED webadmin: Extend "Manage Domain" popup 2018-06-18 09:44:11 UTC

Description Robert McSwain 2014-07-02 18:18:20 UTC
Description of problem:
Upon "Edit Domain" of a storage domain with more than 13 lines (in this case LUNS), the resize of the dialogue box does not allow the user to view the remaining lines. The vertical scroll bar can be used but ideally it should resize the content as you resize the box.

Version-Release number of selected component (if applicable):
RHEVM 3.4.0-0.21

How reproducible:
100%

Additional info:
Screenshot added

Comment 2 Allon Mureinik 2014-07-29 08:34:12 UTC
The entire dialog is defined in hard-coded numbers of pixels, so fixing this will essentially require redoing the UI completely.

In light of the low priority, pushing out to 3.6.

Comment 6 Allon Mureinik 2017-06-13 13:01:02 UTC
Need to check how this behaves in 4.2 after the UI redesign

Comment 7 Yaniv Kaul 2017-12-03 21:04:50 UTC
(In reply to Allon Mureinik from comment #6)
> Need to check how this behaves in 4.2 after the UI redesign

Raz, can you check it?

Comment 8 Raz Tamir 2017-12-04 09:01:52 UTC
Hi,

Checked on rhvm-4.2.0-0.5.master.el7.

The original issue was that the resize of the dialog box is not allowing the user to view all the content but the scrolling down does.

In 4.2 the dialog box resize is disabled for all dialog boxes and the scrolling down in "Edit domain" is working.

Comment 9 Tal Nisan 2018-02-05 09:26:33 UTC
Shani,
You've been doing a lot of work on this dialog lately, can you please asses how complicated will it be to make this dialog resizable?

Comment 10 shani 2018-02-05 13:37:10 UTC
We used to have support for dialog resizing, which was enabled only for storage and disk dialogs (see: [1]). It was removed as part of the PF3 work [2], for lack of native support. However, the resize support was merely to enlarge the table horizontally, i.e. it won't expand the table's rows. So, solving this issue could be much more complicated, as it would mean some redesign of the entire luns table, as its dimensions are currently defined statically in IscsiStorageView.

@Alex - is it applicable to have the support back using the new infra for expanding the window horizontally and for future support for vertically when possible.

[1] http://i.imgur.com/nnMwcPh.png
[2] https://gerrit.ovirt.org/#/c/72391/

Comment 11 Alexander Wels 2018-02-05 13:41:54 UTC
No dialog resize support is not coming back

Comment 12 Yaniv Kaul 2018-03-15 09:51:10 UTC
(In reply to Alexander Wels from comment #11)
> No dialog resize support is not coming back

So why are we keeping this bug open?

Comment 13 Alexander Wels 2018-03-15 18:02:07 UTC
I don't know, maybe someone wants to redesign the dialog to solve the original issue of the information being presented in a form that would require re-sizing the dialog to make it all fit?

Comment 14 Tal Nisan 2018-06-05 13:36:08 UTC
Shani, there has been a few requests to make this dialog bigger, please see if this is possible

Comment 17 RHV bug bot 2018-12-10 15:13:35 UTC
WARN: Bug status (ON_QA) wasn't changed but the folowing should be fixed:

[Found non-acked flags: '{'rhevm-4.3-ga': '?'}', ]

For more info please contact: rhv-devops: Bug status (ON_QA) wasn't changed but the folowing should be fixed:

[Found non-acked flags: '{'rhevm-4.3-ga': '?'}', ]

For more info please contact: rhv-devops

Comment 18 RHV bug bot 2019-01-15 23:36:02 UTC
WARN: Bug status (ON_QA) wasn't changed but the folowing should be fixed:

[Found non-acked flags: '{'rhevm-4.3-ga': '?'}', ]

For more info please contact: rhv-devops: Bug status (ON_QA) wasn't changed but the folowing should be fixed:

[Found non-acked flags: '{'rhevm-4.3-ga': '?'}', ]

For more info please contact: rhv-devops

Comment 19 Evelina Shames 2019-01-30 15:10:41 UTC
Verified on Engine 4.3.0-0.5

Comment 21 errata-xmlrpc 2019-05-08 12:36:47 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2019:1085


Note You need to log in before you can comment on or make changes to this bug.