Spec URL: http://ddick.fedorapeople.org/packages/perl-SOCKS.spec SRPM URL: http://ddick.fedorapeople.org/packages/perl-SOCKS-0.03-1.fc20.src.rpm Description: SOCKS Perl module Fedora Account System Username: ddick
koji builds rawhide at http://koji.fedoraproject.org/koji/taskinfo?taskID=7103156 el6 at http://koji.fedoraproject.org/koji/taskinfo?taskID=7103170
Hi This is my informal review. I comment about the spec file etc. 1. Summary: SOCKS Perl module A detailed a little more explanation is necessary though a long explanation is unnecessary. For what is this used with what? 2. License: GPL+ or Artistic Whether Artistic is "Artistic 2.0" or "Artistic clarified"? https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing 3. Group: Development/Libraries Remove it, no need to keep it now. 4. Source0: http://www.cpan.org/modules/by-module/SOCKS/SOCKS-%{version}.tar.gz There is no source in the link. 5. BuildRequires: perl BuildRequires: perl(AutoLoader) BuildRequires: perl(Carp) BuildRequires: perl(Exporter) BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(IO::Socket) BuildRequires: perl(strict) BuildRequires: perl(vars) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) Are all necessary? The unnecessary should be erased. And, please add comments on explicit dependencies. 6. find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \; It is dangerous rm in %install. Can this be deleted? 7. %{_fixperms} $RPM_BUILD_ROOT/* Why is this necessary? Can this be deleted? 8. Installed file (/usr/share/doc/perl-SOCKS/example) depends on "/usr/local/bin/perl". Isn't /usr/bin/perl correct?
(In reply to NIWA Hideyuki from comment #2) > 5. BuildRequires: perl > BuildRequires: perl(AutoLoader) > BuildRequires: perl(Carp) > BuildRequires: perl(Exporter) > BuildRequires: perl(ExtUtils::MakeMaker) > BuildRequires: perl(IO::Socket) > BuildRequires: perl(strict) > BuildRequires: perl(vars) > Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo > $version)) > > Are all necessary? The unnecessary should be erased. > And, please add comments on explicit dependencies. > > 6. find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \; > > It is dangerous rm in %install. Can this be deleted? > > 7. %{_fixperms} $RPM_BUILD_ROOT/* > > Why is this necessary? Can this be deleted? Frankly speaking, you shouldn't review perl packages. Please read this first before doing any informal reviews: http://fedoraproject.org/wiki/Packaging:Perl
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Perl". Detailed output of licensecheck: Perl ---- SOCKS-0.03/lib/Net/SOCKS.pm [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/perl5/vendor_perl/auto/Net(perl-Net-Whois-IP, perl-Net-Telnet- Cisco, perl-Net-Lite-FTP, perl-Net-IPv4Addr), /usr/share/perl5/vendor_perl/Net(perl-Net-Daemon, perl-Test-TCP, perl- Net-SMTP-SSL, perl-Net-HTTP), /usr/share/perl5/vendor_perl/auto(perl- Inline, perl-File-ShareDir) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [!]: Package contains the mandatory BuildRequires and Requires:. [x]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [x]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: http://www.cpan.org/modules/by- module/SOCKS/SOCKS-0.03.tar.gz See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags [!]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. Note: Incorrect Requires : /usr/local/bin/perl See: http://fedoraproject.org/wiki/Packaging/Guidelines#FileDeps [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint Installation errors ------------------- No handlers could be found for logger "trace.__main__" INFO: mock.py version 1.1.39 starting... Start: init plugins INFO: selinux disabled Finish: init plugins Start: run Mock Version: 1.1.39 INFO: Mock Version: 1.1.39 Start: lock buildroot INFO: installing package(s): /home/rpmaker/Desktop/perl-SOCKS/results/perl-SOCKS-0.03-1.fc21.noarch.rpm ERROR: Command failed: # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-rawhide-i386/root/', '--releasever', '21', 'install', '/home/rpmaker/Desktop/perl-SOCKS/results/perl-SOCKS-0.03-1.fc21.noarch.rpm'] Error: Package: perl-SOCKS-0.03-1.fc21.noarch (/perl-SOCKS-0.03-1.fc21.noarch) Requires: /usr/local/bin/perl You could try using --skip-broken to work around the problem You could try running: rpm -Va --nofiles --nodigest Rpmlint ------- Checking: perl-SOCKS-0.03-1.fc21.noarch.rpm perl-SOCKS-0.03-1.fc21.src.rpm perl-SOCKS.noarch: E: invalid-dependency /usr/local/bin/perl perl-SOCKS.noarch: W: spelling-error %description -l en_US perldoc -> periodic perl-SOCKS.noarch: E: wrong-script-interpreter /usr/share/doc/perl-SOCKS/example /usr/local/bin/perl perl-SOCKS.noarch: W: doc-file-dependency /usr/share/doc/perl-SOCKS/example /usr/local/bin/perl perl-SOCKS.src: W: spelling-error %description -l en_US perldoc -> periodic perl-SOCKS.src: W: invalid-url Source0: http://www.cpan.org/modules/by-module/SOCKS/SOCKS-0.03.tar.gz HTTP Error 404: Not Found 2 packages and 0 specfiles checked; 2 errors, 4 warnings. Requires -------- perl-SOCKS (rpmlib, GLIBC filtered): /usr/local/bin/perl perl(:MODULE_COMPAT_5.18.2) perl(AutoLoader) perl(Carp) perl(Exporter) perl(IO::Socket) perl(Net::SOCKS) perl(strict) perl(vars) Provides -------- perl-SOCKS: perl(Net::SOCKS) perl-SOCKS Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -rvn perl-SOCKS-0.03-1.fc20.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Perl Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Corrected the hash bang line in example file, changed Source0 line to by author URL. Spec and SRPM uploaded. Applied patch follows; <code> $ diff -Naur old new diff -Naur old/perl-SOCKS.spec new/perl-SOCKS.spec --- old/perl-SOCKS.spec 2014-07-08 21:09:59.675017726 +1000 +++ new/perl-SOCKS.spec 2014-07-08 21:09:55.495960260 +1000 @@ -5,7 +5,7 @@ License: GPL+ or Artistic Group: Development/Libraries URL: http://search.cpan.org/dist/SOCKS/ -Source0: http://www.cpan.org/modules/by-module/SOCKS/SOCKS-%{version}.tar.gz +Source0: http://search.cpan.org/CPAN/authors/id/C/CL/CLINTDW/SOCKS-%{version}.tar.gz BuildArch: noarch BuildRequires: perl BuildRequires: perl(AutoLoader) @@ -27,6 +27,7 @@ %prep %setup -q -n SOCKS-%{version} +sed -i 's|#!/.*/bin/perl|#!/usr/bin/perl|' example %build %{__perl} Makefile.PL INSTALLDIRS=vendor </code>
You need to -x that example file. perl-SOCKS.noarch: W: doc-file-dependency /usr/share/doc/perl-SOCKS/example /usr/bin/perl
added the chmod. re-uploaded the spec and srpm. patch follows; --- old/perl-SOCKS.spec 2014-07-08 21:09:55.495960260 +1000 +++ new/perl-SOCKS.spec 2014-07-09 06:51:26.636754898 +1000 @@ -28,6 +28,7 @@ %prep %setup -q -n SOCKS-%{version} sed -i 's|#!/.*/bin/perl|#!/usr/bin/perl|' example +chmod -x example %build %{__perl} Makefile.PL INSTALLDIRS=vendor
PACKAGE APPROVED. Be aware of the f21 branch, you need to add f21 in the scm request.
New Package SCM Request ======================= Package Name: perl-SOCKS Short Description: SOCKS Perl module Upstream URL: http://search.cpan.org/dist/SOCKS/ Owners: ddick Branches: f20, f21, el6, epel7 InitialCC: perl-sig Thanks for the review Chris! Most appreciated.
Git done (by process-git-requests).
perl-SOCKS-0.03-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-SOCKS-0.03-1.el6
perl-SOCKS-0.03-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-SOCKS-0.03-1.fc20
perl-SOCKS-0.03-1.fc20 has been pushed to the Fedora 20 testing repository.
perl-SOCKS-0.03-1.fc20 has been pushed to the Fedora 20 stable repository.
perl-SOCKS-0.03-1.el6 has been pushed to the Fedora EPEL 6 stable repository.