Bug 1115950 - glfsheal: Improve the way in which we check the presence of replica volumes
Summary: glfsheal: Improve the way in which we check the presence of replica volumes
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: replicate
Version: 3.5.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ravishankar N
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: glusterfs-3.5.2
TreeView+ depends on / blocked
 
Reported: 2014-07-03 11:44 UTC by Ravishankar N
Modified: 2014-07-31 11:43 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.5.2beta1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-07-31 11:43:41 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Ravishankar N 2014-07-03 11:44:39 UTC
Description of problem:

    glfsh_validate_replicate_volume() used to check if AFR was the parent of
    all client xlators present in the graph. This need not always be true, for
    example, for user-serviceable-snapshots where the parent of snapd-client is
    snapview-client.

Comment 1 Anand Avati 2014-07-03 11:49:43 UTC
REVIEW: http://review.gluster.org/8229 (heal: fix the way we check the presence of AFR in glfsheal) posted (#1) for review on release-3.5 by Ravishankar N (ravishankar)

Comment 2 Anand Avati 2014-07-07 06:00:09 UTC
REVIEW: http://review.gluster.org/8229 (heal: fix the way we check the presence of AFR in glfsheal) posted (#2) for review on release-3.5 by Ravishankar N (ravishankar)

Comment 3 Anand Avati 2014-07-07 10:45:59 UTC
REVIEW: http://review.gluster.org/8229 (heal: fix the way we check the presence of AFR in glfsheal) posted (#3) for review on release-3.5 by Ravishankar N (ravishankar)

Comment 5 Anand Avati 2014-07-18 16:18:20 UTC
COMMIT: http://review.gluster.org/8229 committed in release-3.5 by Niels de Vos (ndevos) 
------
commit 09692a4c1645b0783ddaf83d264c3b148476f937
Author: Ravishankar N <ravishankar>
Date:   Thu Jul 3 16:47:14 2014 +0530

    heal: fix the way we check the presence of AFR in glfsheal
    
    Problem:
    glfsh_validate_replicate_volume() used to check if AFR was the parent of
    all client xlators present in the graph. This need not always be true, for
    example, for user-serviceable-snapshots where the parent of snapd-client is
    snapview-client.
    
    Fix:
    glfsh_validate_replicate_volume() returns true if atleast one client
    xlator has AFR as its parent. Also, AFR need not be its immediate
    parent, but be present somewhere in its parent ancestry.
    
    Change-Id: Id37ac88c3202bb2fdcae56e108adc461dc8a9a37
    BUG: 1115950
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/8229
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Reviewed-by: Niels de Vos <ndevos>

Comment 6 Niels de Vos 2014-07-21 15:42:04 UTC
The first (and last?) Beta for GlusterFS 3.5.2 has been released [1]. Please verify if the release solves this bug report for you. In case the glusterfs-3.5.2beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-devel/2014-July/041636.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 7 Niels de Vos 2014-07-31 11:43:41 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.2, please reopen this bug report.

glusterfs-3.5.2 has been announced on the Gluster Users mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-July/041217.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.