Red Hat Bugzilla – Bug 111606
editflagtypes.cgi: updating a flag has SQL that doesn't work on PgSQL
Last modified: 2013-06-23 22:57:37 EDT
There's some SQL in editflagtypes.cgi that's proprietary to MySQL --
it uses a comma in the FROM clause, which in MySQL means INNER JOIN
(according to justdave), and I'm not sure what it means in PostgreSQL,
but it doesn't work right.
Look for "FROM flags, bugs" in the file -- it's around there.
I fixed it (at least, theoretically) on my installation by changing
the "flags, bugs" to be:
(flags INNER JOIN bugs ON bugs.bug_id = flags.bug_id)
And removing that "bugs.bug_id = flags.bug_id" from the WHERE clause.
Steps to Reproduce:
1. Create a new flag, and hit "Save Changes."
2. Edit the flag, and hit "Save Changes."
Flag is updated.
Could you submit a patch please to this report?
Created attachment 96449 [details]
Change comma to INNER JOIN
This should be the same as what editflagtypes was previously trying to do, and
failing. I noticed that this was done correctly Flag.pm, but with a CROSS JOIN
that is probably unnecessary.
Note that this is also a general Mozilla Bugzilla issue:
Red Hat's current Bugzilla version is 2.18. I am moving all older open bugs to
this version. Any bugs against the older versions will need to be verified that
they are still bugs. This will help me also to sort them better.
Red Hat Bugzilla is now using version 3.2 of the Bugzilla codebase and therefore this bug will need to be re-verified against the new release. With the updated code this bug may no longer be relevant or may have been fixed in the new code.
Updating bug version to 3.2.