Bug 1116397 - Add a check in set_offload, set_ringparam and set_coalesce
Summary: Add a check in set_offload, set_ringparam and set_coalesce
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: python-ethtool
Version: 22
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Arnaldo Carvalho de Melo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-07-04 12:58 UTC by sumanth k
Modified: 2016-07-19 11:53 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-07-19 11:53:47 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch for exception handling of set_offload in pethtool (1.06 KB, patch)
2014-07-04 13:00 UTC, sumanth k
no flags Details | Diff

Description sumanth k 2014-07-04 12:58:30 UTC
Description of problem:
Add a check in set_offload, set_ringparam and set_coalesce - pethtool.py
In one of our lpar ppc64 , we get the following using ethtool .
#ethtool -K eth0 tso off. 
Cannot change tcp-segmentation-offload
Could not change any device features

But pethtool doesnt return any error and the exit code is 0. Make the user know
that tso offload cannot be set and return 1 just like ethtool.

Version-Release number of selected component (if applicable):


How reproducible:
everytime

Steps to Reproduce:
1. pethtool -K eth0 tso on 
2. returns error code of 0 even though it fails in lpar.
3. Let the user know that tso is not set

Actual results:


Expected results:
return code -1 and warning messages if tso is not set ... 

Additional info:

Comment 1 sumanth k 2014-07-04 13:00:05 UTC
Created attachment 914717 [details]
Patch for exception handling of set_offload in pethtool

sample patch ...Please review it

Comment 2 Jaroslav Reznik 2015-03-03 16:06:11 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle.
Changing version to '22'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22

Comment 3 Fedora End Of Life 2016-07-19 11:53:47 UTC
Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.