Bug 1117235

Hi Michal, could you please tell me which rpm you are using for the test(EL5/6/7)?

btw, Dustin is rebuilding c3p0 to fix 1117350. After it fixed, we need to ask David to rebuild hibernate4 to use them.

I saw two c3p0 jars:

[weli@dhcp-66-78-87 hibernate-release-4.2.14.SP1-redhat-1]$ find . -name *c3p0*.jar ./lib/optional/c3p0/c3p0-0.9.1.2.jar ./lib/optional/c3p0/hibernate-c3p0-4.2.14.SP1-redhat-1.jar


I believe the first one is copied from 'c3p0' package. David, could you please confirm this? If so, after Dustin fixed BZ 1117350, could you please rebuild hibernate4 to make the c3p0 in sync?

hibernate is built using MEAD now instead of Brew. so the jar contained in the zip is being pulled from the maven repository at build time rather than the RPM.

(In reply to Weinan Li from comment #1)
> Hi Michal, could you please tell me which rpm you are using for the
> test(EL5/6/7)?

I'm using:
c3p0-0.9.1.2-5.ep6.el5.noarch
c3p0-0.9.1.2-3.ep6.el6.noarch
c3p0-0.9.1.2-3.ep6.el7.noarch

Hi Dave, could you please help to rebuild hiberante4 on el6 with updated c3p0:

c3p0-0.9.1.2-4.ep6.el6 https://brewweb.devel.redhat.com/buildinfo?buildID=368821

Dustin has helped to rebuild it to remove javadoc files for another bug. Please assign back to me after it's done and I'll rebuild jboss-ews with updated hibernate el6.

(In reply to Michal Haško from comment #0)
> /usr/share/java/c3p0-0.9.1.2.jar from c3p0-0.9.1.2 rpm must be binary
> equivalent (md5sum) with lib/optional/c3p0/c3p0-0.9.1.2.jar from hibernate
> zip.

Currently 'hibernate4' is built using mead, which will use c3p0 on el6 arch. And then we *wrap* the 'hibernate4' builds into 'hibernate-eap6' el5/6/7. Though we have hibernate4-eap6 on el5/6/7, they are just wrappers of 'hiberante4' built from el6 arch. So hibernate4-eap6 el5/6/7 will contain the jars from el6 buildroot.

The result is that in el5/7 erratas the c3p0 will be different from the zip bundle, because c3p0 in zip bundle is from el6 arch.

As I understand this is not a problem. Permaine, how do EAP solve such kind of issue?

I believe QE has a way to compare jars that are not MEAD builds, like c3p0 in this case where it is built on each of RHEL 5, 6 and 7 using ant. We still have a component or two in EAP which are built using ant. The jars has to be compared other than md5sum.

Thanks for the info Permaine! Here are some more info from Dave:

> Hibernate is built using mead, so the c3p0 jar at build time would come from
> the EAP maven repository [0]. It looks like the jar from the c3p0 rpm build isn't 
> deployed to the maven repository, so a rebuild would just be pulling in the same 
> dependencies as before.  The hibernate4 and hibernate4-eap6 RPMs just list c3p0 as
> a runtime requirement, so, if I understand correctly, the new c3p0 RPM should be pulled
> in at install time without a rebuild, correct?
> 
> With that being said, should the c3p0 jar from the RPM be deployed to the maven repository
> or should we be doing a separate c3p0 build to deploy to the maven repo? I assume the jar 
> that is currently there is just a binary import.
> 
> [0] http://download.eng.bos.redhat.com/brewroot/repos/jb-eap-6-rhel-6-build/latest/maven/c3p0/c3p0/0.9.1.2/

Do you think this is a problem or it's expected?

As per our irc conversation, please create -repolib subpackage in c3p0 so that the jars will be uploaded to the MEAD repo for hibernate to pick up.

Dustin is helping on it. Thank you very much Dustin! Please assign back to me after it's done and I'll ask Dave to rebuild hibernate.

Thanks Dave!

I saw dwalluck has a newer build of c3p0 here: https://brewweb.devel.redhat.com/buildinfo?buildID=370299

Which has c3p0-0.9.1.2-redhat-1.jar. Is this the one used during hibernate4 build process?

btw, seems I can't find the c3p0 usages in hibernate4 build log, could you please tell me the link of the correct log that I could check the c3p0 version used during build process?

dwalluck has helped us to build c3p0 el[567]. The rpm erratas are all updated with latest c3p0.

I've asked David to update hibernate for us today. I'll update the CR2 zip bundle after this is ready next week.

Please note the hibernate builds el[567] only use c3p0 on el6 to build, that means the rpm c3p0 el[57] will be different from the one in zip bundle. As Permaine said, we need some other methods to binary compare them.

VERIFIED on
CR2 hibernate-dist.zip
c3p0-0.9.1.2-8_redhat_1.ep6.el6.noarch

(based on comment#22 el5 and el7 c3p0.jar from rpm and zip are not identical)

because of bz1124812 we have to revert c3p0 in erratas:

c3p0-0.9.1.2-3.ep6.el7

David is helping to fix this. It need to be fixed post 2.1.0.GA

Builds were being done separately on RHEL 5, 6, and 7.

I have put in a request to change the build process so that the zip and all RHEL versions will use the exact same jar once bug #1124812 is resolved.

Dear Michal and others, I think this one has slipped through the cracks. Could you take a look at it and close it? Thanks.

As far as I remember, this is a known issue. This was the reason for all the respins before we released 2.1.0. We must not close it, we need to fix it in 3.0.0.

Thanks for updating the Target Release then.

This should be fixed in 3.0.0-CR3.1. It needs final verification.
So probably no info in Release notes.

Okay, removed from JWS3 release notes.

VERIFIED with JWS 3.0.0 CR3.1