Bug 1117241 - backport 'gluster volume status --xml' issues
Summary: backport 'gluster volume status --xml' issues
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: cli
Version: 3.5.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Niels de Vos
QA Contact:
URL:
Whiteboard:
Depends On: 1046020
Blocks: 1061211 glusterfs-3.5.2
TreeView+ depends on / blocked
 
Reported: 2014-07-08 11:14 UTC by Bala.FA
Modified: 2015-11-23 02:58 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.5.2beta1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-07-31 11:43:48 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Bala.FA 2014-07-08 11:14:36 UTC
Currently fix of https://bugzilla.redhat.com/show_bug.cgi?id=1046020 is not available in the release.

This blocks glusterfs usage in ovirt. Respective bz is https://bugzilla.redhat.com/show_bug.cgi?id=1061211

Please backport this patch to next release.

Comment 1 Anand Avati 2014-07-18 17:49:19 UTC
REVIEW: http://review.gluster.org/8334 (cli: Fix xml output for volume status) posted (#1) for review on release-3.5 by Niels de Vos (ndevos)

Comment 2 Anand Avati 2014-07-21 07:11:26 UTC
COMMIT: http://review.gluster.org/8334 committed in release-3.5 by Niels de Vos (ndevos) 
------
commit d5f72dc49604aec2643d92a1b4e321c532ef8d05
Author: Niels de Vos <ndevos>
Date:   Fri Jul 18 19:05:26 2014 +0200

    cli: Fix xml output for volume status
    
    The XML output for volume status was malformed when one of the nodes is
    down, leading to outputs like
    -------
              <node>
                 <node>
                   <hostname>NFS Server</hostname>
                   <path>localhost</path>
                   <peerid>63ca3d2f-8c1f-4b84-b797-b4baddab81fb</peerid>
                   <status>1</status>
                   <port>2049</port>
                   <pid>2130</pid>
                 </node>
    -----
    
    This was happening because we were starting the <node> element before
    determining if node was present, and were not closing it or clearing it
    when not finding the node in the dict.
    
    To fix this, the <node> element is only started once a node has been
    found in the dict.
    
    Cherry picked from commit 2ba42d07eb967472227eb0a93e4ca2cac7a197b5:
    > Change-Id: I6b6205f14b27a69adb95d85db7b48999aa48d400
    > BUG: 1046020
    > Signed-off-by: Kaushal M <kaushal>
    > Reviewed-on: http://review.gluster.org/6571
    > Reviewed-by: Aravinda VK <avishwan>
    > Reviewed-by: Krishnan Parthasarathi <kparthas>
    > Tested-by: Gluster Build System <jenkins.com>
    > Reviewed-by: Vijay Bellur <vbellur>
    
    Change-Id: I6b6205f14b27a69adb95d85db7b48999aa48d400
    BUG: 1117241
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/8334
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaushal M <kaushal>

Comment 3 Niels de Vos 2014-07-21 15:42:10 UTC
The first (and last?) Beta for GlusterFS 3.5.2 has been released [1]. Please verify if the release solves this bug report for you. In case the glusterfs-3.5.2beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-devel/2014-July/041636.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 4 Niels de Vos 2014-07-31 11:43:48 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.2, please reopen this bug report.

glusterfs-3.5.2 has been announced on the Gluster Users mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-July/041217.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.