Created attachment 916467 [details] vdsm+engine logs Description of problem: Vdsm Fails Deactivation and activation of direct Luns disks in a case that the operations were executed while Vm was up. from engine's logs: 2014-07-08 18:35:26,756 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HotPlugDiskVDSCommand] (org.ovirt.thread.pool-8-thread-31) [171e306f] Command HotPlugDiskVDSCommand(HostName = vdsc, HostId = 13380241-87fa-46ce-8201-43eab9ce35d9, vmId=b7a5e3b6-0704-4f74-9135-81a9a45ac109, diskId = 296f6024-ba37-45c9-ba9a-78988781ab8a) execution failed. Exception: VDSErrorException: VDSGenericException: VDSErrorException: Failed to HotPlugDiskVDS, error = internal error unable to execute QEMU command 'device_add': Device 'virtio-blk-pci' could not be initialized, code = 45 vdsm's logs: hread-65::DEBUG::2014-07-08 18:37:25,238::vm::3746::vm.Vm::(hotplugDisk) vmId=`b7a5e3b6-0704-4f74-9135-81a9a45ac109`::Hotplug disk xml: <disk device="lun" snapshot="no" type="block"> <address bus="0x00" domain="0x0000" function="0x0" slot="0x05" type="pci"/> <source dev="/dev/mapper/360060160f4a03000fd65675991dbe311"/> <target bus="virtio" dev="vdu"/> <serial></serial> <driver cache="none" error_policy="stop" io="native" name="qemu" type="raw"/> </disk> Thread-65::DEBUG::2014-07-08 18:37:25,368::libvirtconnection::143::root::(wrapper) Unknown libvirterror: ecode: 1 edom: 10 level: 2 message: internal error unable to execute QEMU command 'device_add': Device 'virtio-blk-pci' could not be initialized Thread-65::ERROR::2014-07-08 18:37:25,369::vm::3754::vm.Vm::(hotplugDisk) vmId=`b7a5e3b6-0704-4f74-9135-81a9a45ac109`::Hotplug failed Traceback (most recent call last): File "/usr/share/vdsm/virt/vm.py", line 3752, in hotplugDisk self._dom.attachDevice(driveXml) File "/usr/share/vdsm/virt/vm.py", line 604, in f ret = attr(*args, **kwargs) File "/usr/lib64/python2.6/site-packages/vdsm/libvirtconnection.py", line 111, in wrapper ret = f(*args, **kwargs) File "/usr/lib64/python2.6/site-packages/libvirt.py", line 399, in attachDevice if ret == -1: raise libvirtError ('virDomainAttachDevice() failed', dom=self) libvirtError: internal error unable to execute QEMU command 'device_add': Device 'virtio-blk-pci' could not be initialized Thread-65::DEBUG::2014-07-08 18:37:25,369::BindingXMLRPC::1114::vds::(wrapper) return vmHotplugDisk with {'status': {'message': "internal error unable to execute QEMU command 'device_add': Device 'virtio-blk-pci' could not be initialized", 'code': 45}} Version-Release number of selected component (if applicable): alpha2 How reproducible: 100% Steps to Reproduce: 1.have a vm with direct Lun attached to it 2.run vm 3.deactivate and then activate it's disk|or disks(several Luns) Actual results: activating fails with Exceptions Expected results: operation should be successful or should not be aloud Additional info:
correction: this bug happens on mounted disks (direct-Lun,File) virtio disks Steps to Reproduce: 1.have a vm with a direct-Lun,nfs virtio disk 2.run vm 3.deactivate and then activate the disk
(In reply to Ori from comment #1) > correction: this bug happens on mounted disks (direct-Lun,File) virtio disks > Steps to Reproduce: > 1.have a vm with a direct-Lun,nfs virtio disk How can a direct LUN be NFS? What am I missing?
Allon,I don't suggest that direct Luns are NFS,I am merely making a note that it seems the bug's reproduction consists from a mutual part at the initialization of both(maybe the mount part). there's a bug belong to activation of virtio iscsi disks BZ #1117179 ,but ERROR's out put is different
There's a need for further documentation in case of HotPlugging disks to guest without OS