Spec URL: https://raw.githubusercontent.com/fabiand/imgbased-spec/imgbased-0.1-0.1/imgbased.spec SRPM URL: http://fedorapeople.org/~fabiand/imgbased/imgbased-0.1-0.1.git20140708.804811f.fc19.src.rpm Description: imgbased provides a specific management method to derive writable file-system layers from read-only base images. It also takes care that the layer which shall be used can be selected at boot time. In a nutshell this works by: * having a boot partition * and having a default LVM volume group (HostVG) * which has a thinpool * each base is kept in a read-only thin logical volume in the thinpool * for each base at least one writable layer, which is a thin logical volume, is created in the thinpool * for each layer a boot entry is created which can be used to boot in a specific layer Fedora Account System Username: fabiand
I could not yet build in koji, I've lost my client certificate, but here you go with a local build: $ rpmlint imgbased imgbased.spec /home/fdeutsch/rpmbuild/SRPMS/imgbased-0.1-0.1.git20140708.804811f.fc19.src.rpm /home/fdeutsch/rpmbuild/RPMS/noarch/imgbased-0.1-0.1.git20140708.804811f.fc19.noarch.rpm /home/fdeutsch/rpmbuild/RPMS/noarch/imgbased-kickstarts-0.1-0.1.git20140708.804811f.fc19.noarch.rpm imgbased.noarch: W: spelling-error Summary(en_US) rootfs -> roots, roofs, root's imgbased.noarch: W: spelling-error %description -l en_US thinpool -> thin pool, thin-pool, Whirlpool imgbased.src: W: spelling-error Summary(en_US) rootfs -> roots, roofs, root's imgbased.src: W: spelling-error %description -l en_US thinpool -> thin pool, thin-pool, Whirlpool imgbased.noarch: W: spelling-error Summary(en_US) rootfs -> roots, roofs, root's imgbased.noarch: W: spelling-error %description -l en_US thinpool -> thin pool, thin-pool, Whirlpool 4 packages and 1 specfiles checked; 0 errors, 6 warnings. Some more app specific infos can be found here: https://github.com/fabiand/imgbased/blob/master/README.md
Hello Fabian, Here my initial feedback: 1) Include BuildRequires: python-pexpect (During the build, it required it) 2) Please split BuildRequires per requirement, not as single line. BuildRequires: pylint BuildRequires: pyflakes BuildRequires: python-pep8
Hey Douglas, thanks for the feedback. I've updated the spec accordingly. Spec URL: https://raw.githubusercontent.com/fabiand/imgbased-spec/imgbased-0.1-0.2/imgbased.spec SRPM URL: http://fedorapeople.org/~fabiand/imgbased/imgbased-0.1-0.2.git20140708.804811f.fc19.src.rpm
An update: python-pexpect only existed on my machine … Spec URL: https://raw.githubusercontent.com/fabiand/imgbased-spec/imgbased-0.1-0.3/imgbased.spec SRPM URL: http://fedorapeople.org/~fabiand/imgbased/imgbased-0.1-0.3.git20140708.804811f.fc19.src.rpm
In F20 pexpect got obsoleted by python-pexpect / review request https://bugzilla.redhat.com/878612 I won't use conditionals in the spec, but I will update the package name in the specific branches after it got merged.
Okay, removed (half-baked) py3 support and added a conditional for the pexpect pkg name. Spec URL: https://raw.githubusercontent.com/fabiand/imgbased-spec/imgbased-0.1-0.4/imgbased.spec SRPM URL: http://fedorapeople.org/~fabiand/imgbased/imgbased-0.1-0.4.git20140708.804811f.fc19.src.rpm
Added automake/-conf Spec URL: https://raw.githubusercontent.com/fabiand/imgbased-spec/imgbased-0.1-0.5/imgbased.spec SRPM URL: http://fedorapeople.org/~fabiand/imgbased/imgbased-0.1-0.5.git20140708.804811f.fc19.src.rpm
Hi Fabian, Your package looks good, I would recommend: - add %dir to avoid "No known owner" - add COPYING file with the license of program in %doc
Added automake/-conf Spec URL: https://raw.githubusercontent.com/fabiand/imgbased-spec/imgbased-0.1-0.6/imgbased.spec SRPM URL: http://fedorapeople.org/~fabiand/imgbased/imgbased-0.1-0.6.git20140714.8679e61.fc19.src.rpm
Well, I did not add automake+-conf, but I own the datadir now and added a LICENSE file.
Anything else?
Move upstream spec into subdir, to prevent review-tools complains. Spec URL: https://raw.githubusercontent.com/fabiand/imgbased-spec/imgbased-0.1-0.7/imgbased.spec SRPM URL: http://fedorapeople.org/~fabiand/imgbased/imgbased-0.1-0.7.git20140721.bb25471.fc19.src.rpm
Another respin to pickup a sane sourcefile (passing travis again) Spec URL: https://raw.githubusercontent.com/fabiand/imgbased-spec/imgbased-0.1-0.8/imgbased.spec SRPM URL: http://fedorapeople.org/~fabiand/imgbased/imgbased-0.1-0.8.git20140721.71b82f3.fc19.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "Unknown or generated". 7 files have unknown license. Detailed output of licensecheck in /home/fedora/1117463-imgbased/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 122880 bytes in 28 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in imgbased- kickstarts [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: imgbased-0.1-0.8.git20140721.71b82f3.fc20.noarch.rpm imgbased-kickstarts-0.1-0.8.git20140721.71b82f3.fc20.noarch.rpm imgbased-0.1-0.8.git20140721.71b82f3.fc20.src.rpm imgbased.noarch: W: spelling-error Summary(en_US) rootfs -> roots, roofs, root's imgbased.noarch: W: spelling-error %description -l en_US thinpool -> thin pool, thin-pool, Whirlpool imgbased.src: W: spelling-error Summary(en_US) rootfs -> roots, roofs, root's imgbased.src: W: spelling-error %description -l en_US thinpool -> thin pool, thin-pool, Whirlpool 3 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint imgbased-kickstarts imgbased imgbased.noarch: W: spelling-error Summary(en_US) rootfs -> roots, roofs, root's imgbased.noarch: W: spelling-error %description -l en_US thinpool -> thin pool, thin-pool, Whirlpool 2 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- imgbased-kickstarts (rpmlib, GLIBC filtered): lorax imgbased (rpmlib, GLIBC filtered): /bin/bash lvm2 python(abi) Provides -------- imgbased-kickstarts: imgbased-kickstarts imgbased: imgbased Source checksums ---------------- https://github.com/fabiand/imgbased/archive/71b82f3c0f5720dd4eb372630d6e01a08bf32b7e/imgbased-0.1.git20140721.71b82f3.tar.gz : CHECKSUM(SHA256) this package : cd638778346e746e1db04dc1b9334adbcdcbc5894ba8d20072ece97d42b93ea7 CHECKSUM(SHA256) upstream package : cd638778346e746e1db04dc1b9334adbcdcbc5894ba8d20072ece97d42b93ea7 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1117463 Buildroot used: fedora-20-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
New Package SCM Request ======================= Package Name: imgbased Short Description: Tools to work with an image based rootfs Upstream URL: https://github.com/fabiand/imgbased/ Owners: fabiand Branches: f19 f20 f21 InitialCC:
Git done (by process-git-requests).
Thanks a lot everybody!