Bug 1118273 - Review Request: php-horde-Horde-OpenXchange - Open-Xchange Connector
Summary: Review Request: php-horde-Horde-OpenXchange - Open-Xchange Connector
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Haïkel Guémar
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2014-07-10 10:39 UTC by Remi Collet
Modified: 2016-08-14 16:25 UTC (History)
2 users (show)

Fixed In Version: php-horde-Horde-OpenXchange-1.0.0-1.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2014-08-01 06:06:24 UTC
Type: ---
karlthered: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Comment 1 Remi Collet 2014-07-10 10:40:38 UTC
I will clean EL-5 stuff after import.

This is a new optional dependency of Horde / Nag / Turba / Kronolith

I prefer to keep CamelCase name for consistency with other horde packages.

Comment 2 Haïkel Guémar 2014-07-21 15:14:05 UTC
Since this package complies with Fedora general and PHP specific guidelines, I hereby approve it into Fedora Packages Collection. Please go forward with the scm request. 

I took packager comments into account, I have full confidence that Remi will cleanup thel EL-5 after import

Note that there's no license file included in sources, please file a ticket upstream about it

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[-]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 6 files have unknown license. Detailed output of
     licensecheck in /home/haikel/1118273-php-horde-Horde-
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[-]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[-]: Buildroot is not present
     Note: Buildroot: present but not needed
[-]: Package has no %clean section with rm -rf %{buildroot} (or
     Note: %clean present but not required
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

[!]: Run phpci static analyze on all php files.
     Note: phpcompatinfo not found. Install php-bartlett-PHP-CompatInfo
     package to get a more comprehensive php review.
     See: url: undefined

Checking: php-horde-Horde-OpenXchange-1.0.0-1.fc20.noarch.rpm
php-horde-Horde-OpenXchange.noarch: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

Rpmlint (installed packages)
# rpmlint php-horde-Horde-OpenXchange
php-horde-Horde-OpenXchange.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
# echo 'rpmlint-done:'

php-horde-Horde-OpenXchange (rpmlib, GLIBC filtered):


Source checksums
http://pear.horde.org/get/Horde_OpenXchange-1.0.0.tgz :
  CHECKSUM(SHA256) this package     : 3accdc56ef86b2c22cf6b11a069883d4001ae03e2b93dbd9b8a8a84a65e256ac
  CHECKSUM(SHA256) upstream package : 3accdc56ef86b2c22cf6b11a069883d4001ae03e2b93dbd9b8a8a84a65e256ac

Comment 3 Remi Collet 2014-07-21 15:18:54 UTC
Thanks again for the review !

New Package SCM Request
Package Name: php-horde-Horde-OpenXchange
Short Description: Open-Xchange Connector
Upstream URL: http://www.horde.org/
Owners: remi
Branches: f20 f21 el6 epel7

Comment 4 Gwyn Ciesla 2014-07-21 15:34:16 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2014-07-22 07:22:49 UTC
php-horde-Horde-OpenXchange-1.0.0-1.el6 has been submitted as an update for Fedora EPEL 6.

Comment 6 Fedora Update System 2014-07-22 07:22:55 UTC
php-horde-Horde-OpenXchange-1.0.0-1.fc20 has been submitted as an update for Fedora 20.

Comment 7 Fedora Update System 2014-07-22 18:09:20 UTC
php-horde-Horde-OpenXchange-1.0.0-1.el6 has been pushed to the Fedora EPEL 6 testing repository.

Comment 8 Fedora Update System 2014-08-01 06:06:24 UTC
php-horde-Horde-OpenXchange-1.0.0-1.fc20 has been pushed to the Fedora 20 stable repository.

Comment 9 Fedora Update System 2014-08-07 11:45:24 UTC
php-horde-Horde-OpenXchange-1.0.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository.

Note You need to log in before you can comment on or make changes to this bug.