Bug 1119197 - Review Request: gnushogi - Shogi (Japanese Chess) AI engine
Review Request: gnushogi - Shogi (Japanese Chess) AI engine
Status: NEW
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
unspecified Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On:
Blocks: FE-NEEDSPONSOR
  Show dependency treegraph
 
Reported: 2014-07-14 05:04 EDT by Chen Chen
Modified: 2014-07-24 16:22 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)
gnushogi.spec (3rd submit) (1.56 KB, text/x-rpm-spec)
2014-07-15 05:48 EDT, Chen Chen
no flags Details
SRPM (3rd submit) (458.91 KB, application/x-rpm)
2014-07-16 05:29 EDT, Chen Chen
no flags Details
gnushogi.spec (1.58 KB, text/x-rpm-spec)
2014-07-17 05:31 EDT, Chen Chen
no flags Details
gnushogi-1.4.2-1.fc20.src.rpm (377.58 KB, application/x-rpm)
2014-07-17 05:32 EDT, Chen Chen
no flags Details
xshogi.spec (765 bytes, text/x-rpm-spec)
2014-07-17 05:33 EDT, Chen Chen
no flags Details
xshogi-1.4.2-1.fc20.src.rpm (252.45 KB, application/x-rpm)
2014-07-17 05:34 EDT, Chen Chen
no flags Details

  None (edit)
Description Chen Chen 2014-07-14 05:04:22 EDT
Spec URL: https://dl.dropboxusercontent.com/u/56671522/gnushogi.spec
SRPM URL: https://dl.dropboxusercontent.com/u/56671522/gnushogi-20140714git29cc00c-1.fc20.src.rpm

Description:
GNU shogi is a program that plays shogi, the Japanese version of chess, against a human (or computer) opponent.
GNU Shogi proper is only the AI engine, and you will likely want to use a GUI frontend (XBoard, for example) to be more comfortable.
(This is a snapshot from git version, which has decent autotools support and recognize xboard protocol)

Fedora Account System Username: aflyhorse
Comment 1 Chen Chen 2014-07-14 05:31:41 EDT
Ouch, I forgot this etiquette:
this is my first package, and I am seeking a sponsor.
Comment 2 Chen Chen 2014-07-15 03:36:48 EDT
Following the advice of upstream maintainer (Thanks Yann)
I made some update to the package. The links in the first post were unlinked and here is the new version:

Spec URL: https://dl.dropboxusercontent.com/u/56671522/gnushogi.spec 
SRPM URL: https://dl.dropboxusercontent.com/u/56671522/gnushogi-1.4.2%2B-1.20140714gitf1d6e23.fc20.src.rpm
Comment 3 Christopher Meng 2014-07-15 03:44:55 EDT
The second spec is even worse than the initial submitted one.
Comment 4 Chen Chen 2014-07-15 04:15:32 EDT
Because I seperated my patch from the original git snapshot.

My patch involved tweaking the configure.ac, thus cause a full "autoreconf" in %prep stage and pulled in a long list of build dependency. The build dependency list is generated via auto-buildrequires (https://apps.fedoraproject.org/packages/auto-buildrequires)

Koji Build output:
http://koji.fedoraproject.org/koji/taskinfo?taskID=7142190
http://koji.fedoraproject.org/koji/taskinfo?taskID=7142198
Comment 5 Christopher Meng 2014-07-15 04:37:29 EDT
(In reply to Chen Chen from comment #4)
> Because I seperated my patch from the original git snapshot.

You should use a released tarball from the official website, then rebase your patch. No comments around there, I don't know where you got the sources.

Your source0 contains no URL and as a result it's untrusted. Please use the full link.

> My patch involved tweaking the configure.ac, thus cause a full "autoreconf"
> in %prep stage and pulled in a long list of build dependency. The build
> dependency list is generated via auto-buildrequires
> (https://apps.fedoraproject.org/packages/auto-buildrequires)

That tool is a crap nowadays, and that long list generated is also a crap. You need to know what gnushogi needs for the building, not let tool teach you how to find the dependencies. Don't be sloppy.

Also your patch only invokes the check of the texinfo and it doesn't make sense to me that such a horrendous list of BRs should be pulled in, it's wrong. Please read carefully:

https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2

> Koji Build output:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=7142190
> http://koji.fedoraproject.org/koji/taskinfo?taskID=7142198

Successful build indicates nothing as the package you sent here doesn't match the guideline.

And your name also caught my eyes as well, just a note to ensure that please use your real name here if possible in most cases.
Comment 6 Chen Chen 2014-07-15 05:46:52 EDT
(In reply to Christopher Meng from comment #5)
> (In reply to Chen Chen from comment #4)
> > Because I seperated my patch from the original git snapshot.
> 
> You should use a released tarball from the official website, then rebase
> your patch. No comments around there, I don't know where you got the sources.
> 
> Your source0 contains no URL and as a result it's untrusted. Please use the
> full link.

I don't think use the released tarball is a good idea:
a) It doesn't talk to modern xboard, but use an outdated xshogi as GUI. xshogi is a years old folk of xboard.
b) The tarball also needs "autoreconf" on f20. The autotoolchain in tarball is too old and doesn't honor "make install DESTDIR="

I've updated the spec and added source in comments according to https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Using_Revision_Control

> Also your patch only invokes the check of the texinfo and it doesn't make
> sense to me that such a horrendous list of BRs should be pulled in, it's
> wrong. Please read carefully:
> 
> https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2

Thanks for the link. I've eliminated them in my 3rd submission in attachment.
 
> And your name also caught my eyes as well, just a note to ensure that please
> use your real name here if possible in most cases.

This is my real name. I can email you a photocopy of my passport if you want.
Comment 7 Chen Chen 2014-07-15 05:48:47 EDT
Created attachment 918089 [details]
gnushogi.spec (3rd submit)
Comment 8 Chen Chen 2014-07-16 05:29:04 EDT
Created attachment 918361 [details]
SRPM (3rd submit)

http://koji.fedoraproject.org/koji/taskinfo?taskID=7142468
Comment 9 Chen Chen 2014-07-17 05:31:06 EDT
Created attachment 918647 [details]
gnushogi.spec

After some struggle I decided to use the released tarball as initial package. So the package is splitted into two: gnushogi and xshogi.

http://koji.fedoraproject.org/koji/taskinfo?taskID=7156120
Comment 10 Chen Chen 2014-07-17 05:32:03 EDT
Created attachment 918648 [details]
gnushogi-1.4.2-1.fc20.src.rpm
Comment 11 Chen Chen 2014-07-17 05:33:30 EDT
Created attachment 918649 [details]
xshogi.spec

The xshogi is the X-11 front-end of GNU Shogi.

http://koji.fedoraproject.org/koji/taskinfo?taskID=7156126
Comment 12 Chen Chen 2014-07-17 05:34:12 EDT
Created attachment 918650 [details]
xshogi-1.4.2-1.fc20.src.rpm
Comment 13 Yann Dirson 2014-07-24 16:22:35 EDT
(In reply to Christopher Meng from comment #5)
> You need to know what gnushogi needs for the building, not let tool teach
> you how to find the dependencies. Don't be sloppy.

You can also get a look at the build-deps I used for the debian package.

Note You need to log in before you can comment on or make changes to this bug.