Red Hat Bugzilla – Bug 1119947
Review Request: makepp - Compatible but reliable and improved replacement for make
Last modified: 2016-08-03 10:42:57 EDT
Spec URL: http://os.inf.tu-dresden.de/~jsteckli/tmp/makepp.spec SRPM URL: http://os.inf.tu-dresden.de/~jsteckli/tmp/makepp-2.0.98.5-1.fc20.src.rpm Description: Makepp, a build program which has a number of features that allow for reliable builds and simpler build files, is a drop-in replacement for GNU make. It supports almost all of the syntax that GNU make supports, and can be used with makefiles produced by utilities such as automake. It is called makepp (or make++) because it was designed with special support for C++, which has since been extended to other languages like Swig or embedded SQL. Fedora Account System Username: boelthorn This is my first review request and I need a sponsor. Koji builds this just fine: http://koji.fedoraproject.org/koji/taskinfo?taskID=7147760
Thanks for packaging it.
*** Bug 1001452 has been marked as a duplicate of this bug. ***
A quick look at the spec file: > %doc To be deleted. An empty %doc line makes no sense. It's a no-op. > %{_bindir}/* Sort of sloppy packaging, because this would include anything in the package and would even accept a missing %{_bindir}/%{name} executable. Please be a little more explicit about which files to include, also to increase clearness/comprehensibility of the spec file. A compromise would be to do %{_bindir}/%{name}* %{_bindir}/mpp* with the caveat that it would also not fail for an absent %{_bindir}/%{name} file (or other files people expect to be available). Ideal would be to either spell out all files you never want to be missing, or to add a guard that verifies whether e.g. %{buildroot}%{_bindir}/%{name} is available. The %install or %check section is suitable for that. > %{_mandir}/* Here the brevity leads to including too many subdirs of %{_mandir}, which belong into the "filesystem" package already and must not be included in your package: https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership > %{_datadir}/makepp/* > %{_defaultdocdir}/makepp/* https://fedoraproject.org/wiki/Packaging:UnownedDirectories
Julian, are you still interrested in? You provided no response to Michael comment. If there will be no response, then this review will be closed.
Please close. Unfortunately, I don't have the time to pursue this further.