This RFE is about adding a support for IO quality of service tuning parameters.
Those are going to be used by the oVirt 3.5 engine.
The actual parameters we want to control are:
And we will store them directly in the device description (VDSM already supports that when the disk is attached) and as upper and lower bounds in the metadata section for future MoM routine to use.
We will add some new API calls to VM for that - updateVmPolicy, setIoTune, getIoTunePolicy plus the necessary data collection to getStats.
+++ This bug was initially created as a clone of Bug #1085049 +++
With this feature we can limit a VM's blkio resource consumption.
We'd like to set up the following:
- weight (blkio.weight in blkio cgroup)
- weight_device (blkio.weight_device in blkio cgroup)
- total_bytes_sec (block_set_io_throttle command in qemu monitor)
- read_bytes_sec (block_set_io_throttle command in qemu monitor)
- write_bytes_sec (block_set_io_throttle command in qemu monitor)
- total_iops_sec (block_set_io_throttle command in qemu monitor)
- read_iops_sec (block_set_io_throttle command in qemu monitor)
- write_iops_sec (block_set_io_throttle command in qemu monitor)
--- Additional comment from Sven Kieske on 2014-04-08 03:49:14 EDT ---
Would this just work with virtio-blk or also with virtio-scsi?
--- Additional comment from Scott Herold on 2014-04-23 15:51:48 EDT ---
RE: Comment 1, I need to defer to Gilad on how this was implemented. The libvirt documentation leads me to believe that at the libvirt level, the settings are controller agnostic: http://libvirt.org/formatdomain.html#elementsDisks and are implemented at an individual disk level, not controller level. In fact, in the libvirt documentation, the following is quoted: "Any device that looks like a disk, be it a floppy, harddisk, cdrom, or paravirtualized driver is specified via the disk element." This leads me to believe it should also be compatible with the paravirtualized virtio-scsi devices as well.
--- Additional comment from Doron Fediuck on 2014-05-13 22:16:40 EDT ---
(In reply to Scott Herold from comment #2)
> RE: Comment 1, I need to defer to Gilad on how this was implemented.
The iotune element doc states:
Currently, the only tuning available is Block I/O throttling for qemu.
Eric, care to shed some light on current status?
ie- what happens when type='network' and protocol is iscsi?
--- Additional comment from Eric Blake on 2014-07-03 08:47:39 EDT ---
(In reply to Doron Fediuck from comment #3)
> (In reply to Scott Herold from comment #2)
> > RE: Comment 1, I need to defer to Gilad on how this was implemented.
> The iotune element doc states:
> Currently, the only tuning available is Block I/O throttling for qemu.
> Eric, care to shed some light on current status?
> ie- what happens when type='network' and protocol is iscsi?
At the libvirt level, there are two separate throttling points. One is <blkiotune> at the top <domain> level, which can only throttle things via cgroups on the host at the host block device level. Because it is done on host block devices, it is not very fine-grained (if a guest has more than one <disk> mapped as files, but both files live on the same block device, then you cannot throttle them independently), and limited in what it can throttle (a type='network' <disk> element has no corresponding block device on the host, so it can't be throttled). The other is <iotune> at the <disk> level, which throttles solely based on qemu command line arguments. At this level, the throttling is enforced by qemu, and theoretically works on ANY guest device. But you'd have to ask the qemu folks to make sure it does the throttling you are interested in; also be aware that <blkiotune> was implemented first, and <iotune> later, so it may be a matter of which throttling points have been backported to the qemu/libvirt combo you are using.
oVirt 3.5 has been released and should include the fix for this issue.
The relevant patches have NOT been taken into vdsm's ovirt-3.5 branch yet. This feature is NOT in 3.5.0.
This is an automated message:
This bug should be fixed in oVirt 3.5.1 RC1, moving to QA
oVirt 3.5.1 has been released. If problems still persist, please make note of it in this bug report.