1120646 – rfc.sh transfers patches with whitespace problems without warning [provide coding guidelines check]

Bug 1120646 - rfc.sh transfers patches with whitespace problems without warning [provide coding guidelines check]

Summary: rfc.sh transfers patches with whitespace problems without warning [provide co...

Keywords:
Status:	CLOSED CURRENTRELEASE
Alias:	None
Product:	GlusterFS
Classification:	Community
Component:	unclassified
Sub Component:
Version:	pre-release
Hardware:	Unspecified
OS:	Unspecified
Priority:	unspecified
Severity:	unspecified
Target Milestone:	---
Assignee:	bugs@gluster.org
QA Contact:
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2014-07-17 10:40 UTC by Anders Blomdell
Modified:	2015-05-14 17:42 UTC (History)
CC List:	3 users (show)
Fixed In Version:	glusterfs-3.7.0
Clone Of:
Environment:
Last Closed:	2015-05-14 17:26:21 UTC
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Embargoed:
Dependent Products:

Attachments	(Terms of Use)

Description Anders Blomdell 2014-07-17 10:40:44 UTC

Description of problem:

When pushing patches with rfc.sh, sloppy programmers might easily
submit patches with bogus whitespace in them, therby consuming
valuable reviewer bandwidth.

Version-Release number of selected component (if applicable):

v3.5qa2-760-ge291ce0

Comment 1 Anand Avati 2014-07-17 10:43:12 UTC

REVIEW: http://review.gluster.org/8325 (Check if the review going up contains possibly invalid whitespace.) posted (#1) for review on master by Anders Blomdell (anders.blomdell.se)

Comment 2 Anand Avati 2014-07-17 12:39:46 UTC

REVIEW: http://review.gluster.org/8325 (Check if the review going up contains possibly invalid whitespace.) posted (#2) for review on master by Anders Blomdell (anders.blomdell.se)

Comment 3 Anand Avati 2014-07-17 12:42:21 UTC

REVIEW: http://review.gluster.org/8325 (Check if the review going up contains possibly invalid whitespace.) posted (#3) for review on master by Anders Blomdell (anders.blomdell.se)

Comment 4 Anand Avati 2014-07-17 15:18:19 UTC

REVIEW: http://review.gluster.org/8325 (Check if the review going up contains possibly invalid whitespace.) posted (#4) for review on master by Anders Blomdell (anders.blomdell.se)

Comment 5 Anand Avati 2014-07-17 15:20:05 UTC

REVIEW: http://review.gluster.org/8325 (Check if the review for invalid whitespace.) posted (#5) for review on master by Anders Blomdell (anders.blomdell.se)

Comment 6 Anand Avati 2014-07-17 15:30:06 UTC

REVIEW: http://review.gluster.org/8325 (Check the review for invalid whitespace.) posted (#6) for review on master by Anders Blomdell (anders.blomdell.se)

Comment 7 Anand Avati 2014-07-17 15:42:31 UTC

REVIEW: http://review.gluster.org/8325 (Check the review for invalid whitespace.) posted (#7) for review on master by Anders Blomdell (anders.blomdell.se)

Comment 8 Anand Avati 2014-07-17 15:56:03 UTC

REVIEW: http://review.gluster.org/8325 (Check the review for invalid whitespace.) posted (#8) for review on master by Anders Blomdell (anders.blomdell.se)

Comment 9 Anders Blomdell 2014-07-30 10:57:42 UTC

I suggest this http://review.gluster.org/#/c/8181/ since it's much more comprehensive.

Comment 10 Anand Avati 2014-07-30 16:58:09 UTC

REVIEW: http://review.gluster.org/8181 (extras/checkpatch.pl: linux kernel style patch verification) posted (#5) for review on master by Anders Blomdell (anders.blomdell.se)

Comment 11 Anand Avati 2014-07-31 07:54:16 UTC

REVIEW: http://review.gluster.org/8181 (extras/checkpatch.pl: linux kernel style patch verification) posted (#6) for review on master by Harshavardhana (harsha)

Comment 12 Anand Avati 2014-08-01 16:36:04 UTC

REVIEW: http://review.gluster.org/8181 (extras/checkpatch.pl: linux kernel style patch verification) posted (#7) for review on master by Harshavardhana (harsha)

Comment 13 Anand Avati 2014-08-01 17:07:35 UTC

REVIEW: http://review.gluster.org/8181 (extras/checkpatch.pl: linux kernel style patch verification) posted (#8) for review on master by Anders Blomdell (anders.blomdell.se)

Comment 14 Anand Avati 2014-08-02 17:52:40 UTC

REVIEW: http://review.gluster.org/8181 (extras/checkpatch.pl: linux kernel style patch verification) posted (#9) for review on master by Harshavardhana (harsha)

Comment 15 Anand Avati 2014-08-02 17:54:28 UTC

REVIEW: http://review.gluster.org/8181 (extras/checkpatch.pl: linux kernel style patch verification) posted (#10) for review on master by Harshavardhana (harsha)

Comment 16 Anand Avati 2014-08-02 18:04:28 UTC

REVIEW: http://review.gluster.org/8181 (extras/checkpatch.pl: linux kernel style patch verification) posted (#11) for review on master by Harshavardhana (harsha)

Comment 17 Anand Avati 2014-08-02 19:51:21 UTC

REVIEW: http://review.gluster.org/8181 (extras/checkpatch.pl: linux kernel style patch verification) posted (#12) for review on master by Harshavardhana (harsha)

Comment 18 Anand Avati 2014-08-02 20:01:50 UTC

REVIEW: http://review.gluster.org/8181 (extras/checkpatch.pl: linux kernel style patch verification) posted (#13) for review on master by Harshavardhana (harsha)

Comment 19 Anand Avati 2014-08-04 07:58:23 UTC

REVIEW: http://review.gluster.org/8181 (extras/checkpatch.pl: linux kernel style patch verification) posted (#14) for review on master by Harshavardhana (harsha)

Comment 20 Anand Avati 2014-08-07 08:24:23 UTC

REVIEW: http://review.gluster.org/8181 (extras/checkpatch.pl: linux kernel style patch verification) posted (#15) for review on master by Harshavardhana (harsha)

Comment 21 Anand Avati 2014-09-02 04:57:44 UTC

REVIEW: http://review.gluster.org/8181 (extras/checkpatch.pl: linux kernel style patch verification) posted (#16) for review on master by Harshavardhana (harsha)

Comment 22 Anand Avati 2014-09-02 08:06:45 UTC

REVIEW: http://review.gluster.org/8181 (extras/checkpatch.pl: linux kernel style patch verification) posted (#17) for review on master by Harshavardhana (harsha)

Comment 23 Anand Avati 2014-09-02 20:25:34 UTC

REVIEW: http://review.gluster.org/8181 (extras/checkpatch.pl: linux kernel style patch verification) posted (#18) for review on master by Harshavardhana (harsha)

Comment 24 Anand Avati 2014-09-02 20:26:40 UTC

REVIEW: http://review.gluster.org/8181 (extras/checkpatch.pl: linux kernel style patch verification) posted (#19) for review on master by Harshavardhana (harsha)

Comment 25 Anand Avati 2014-09-02 20:31:04 UTC

REVIEW: http://review.gluster.org/8181 (extras/checkpatch.pl: linux kernel style patch verification) posted (#20) for review on master by Harshavardhana (harsha)

Comment 26 Anand Avati 2014-09-03 18:16:18 UTC

REVIEW: http://review.gluster.org/8181 (extras/checkpatch.pl: linux kernel style patch verification) posted (#21) for review on master by Harshavardhana (harsha)

Comment 27 Anand Avati 2014-09-04 08:48:20 UTC

REVIEW: http://review.gluster.org/8181 (extras/checkpatch.pl: linux kernel style patch verification) posted (#22) for review on master by Anders Blomdell (anders.blomdell.se)

Comment 28 Anand Avati 2014-09-06 03:45:41 UTC

REVIEW: http://review.gluster.org/8181 (extras/checkpatch.pl: linux kernel style patch verification) posted (#23) for review on master by Harshavardhana (harsha)

Comment 29 Anand Avati 2014-09-06 03:51:01 UTC

REVIEW: http://review.gluster.org/8181 (extras/checkpatch.pl: linux kernel style patch verification) posted (#24) for review on master by Harshavardhana (harsha)

Comment 30 Anand Avati 2014-09-18 19:55:30 UTC

COMMIT: http://review.gluster.org/8181 committed in master by Harshavardhana (harsha) 
------
commit c788a7784d8526b72714d60bac6e1e09ae985a84
Author: Harshavardhana <harsha>
Date:   Wed Jun 25 21:22:49 2014 -0700

    extras/checkpatch.pl: linux kernel style patch verification
    
    This is to bring in adherence to coding policy, prior to patch
    submission for review.
    
     - no tabs
     - no whitespace
     - indentation (linux style) etc.
    
    This is in the interest at large for the GlusterFS codebase
    to be more cleaner and readable.
    
    ./rfc.sh - now supports running this for all patches diverged
    from "origin/master" revision.
    
    NOTE: One should take this as a handle for good guidelines and
    never use it as a tool for correctness, use common-sense in all
    the cases ;-)
    
    Change-Id: Ib9a5ed207cde152cb92b8d38cec83e8ce9ef7f28
    BUG: 1120646
    Signed-off-by: Harshavardhana <harsha>
    Reviewed-on: http://review.gluster.org/8181
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anders Blomdell <anders.blomdell.se>

Comment 31 Anand Avati 2014-09-22 18:02:30 UTC

REVIEW: http://review.gluster.org/8811 (extras/checkpatch.pl: update coding guidelines script) posted (#1) for review on master by Harshavardhana (harsha)

Comment 32 Anand Avati 2014-09-23 19:29:21 UTC

COMMIT: http://review.gluster.org/8811 committed in master by Harshavardhana (harsha) 
------
commit 2288fec13e5fa8f1b2493fd75e35f748460b2039
Author: Harshavardhana <harsha>
Date:   Mon Sep 22 10:59:37 2014 -0700

    extras/checkpatch.pl: update coding guidelines script
    
    - Allow 'quoted string split across lines' since its a
      GlusterFS common practice
    - Remove a useless "+" - perl 5.20 complains with following
      warning "Useless use of greediness modifier '+'"
    
    Change-Id: Ibaf276ec84757b3ecc3e6db7f5e720b8e8a12dff
    BUG: 1120646
    Signed-off-by: Harshavardhana <harsha>
    Reviewed-on: http://review.gluster.org/8811
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 33 Anand Avati 2014-09-23 19:47:14 UTC

REVIEW: http://review.gluster.org/8813 (build: remove warnings for recommended style) posted (#3) for review on master by Jeff Darcy (jdarcy)

Comment 34 Anand Avati 2014-09-23 19:48:22 UTC

REVIEW: http://review.gluster.org/8813 (build: remove warnings for recommended style) posted (#4) for review on master by Jeff Darcy (jdarcy)

Comment 35 Anand Avati 2014-09-23 21:30:17 UTC

COMMIT: http://review.gluster.org/8813 committed in master by Harshavardhana (harsha) 
------
commit 6e8ad12fbac943336f9eb8d97bf2e0bedb9fb225
Author: Jeff Darcy <jdarcy>
Date:   Mon Sep 22 16:48:50 2014 -0400

    build: remove warnings for recommended style
    
    Specifically:
    
     * space before function arguments
    
     * brace around single statement
    
    Ideally we would *reverse* these tests so they warn under the exact
    opposite conditions, but that would mean learning the internals of a
    script written in a defective language with cryptic variable names and
    too few comments.  Life's too short.  For now, just cutting down on some
    of the spam (which might obscure more serious issues) should suffice.
    
    BUG: 1120646
    Change-Id: I5ec684d0d788a34f29af9b1761743c8860973993
    Signed-off-by: Jeff Darcy <jdarcy>
    Reviewed-on: http://review.gluster.org/8813
    Reviewed-by: Harshavardhana <harsha>
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: Harshavardhana <harsha>

Comment 36 Anand Avati 2014-10-13 22:21:20 UTC

REVIEW: http://review.gluster.org/8927 (Revert "extras: reverse test for '}' vs. following 'else' placement") posted (#1) for review on master by Harshavardhana (harsha)

Comment 37 Anand Avati 2014-10-14 13:43:41 UTC

COMMIT: http://review.gluster.org/8927 committed in master by Niels de Vos (ndevos) 
------
commit 7808d4b7892ccd80bcabb1253ee359a64c51c612
Author: Harshavardhana <harsha>
Date:   Mon Oct 13 15:19:35 2014 -0700

    Revert "extras: reverse test for '}' vs. following 'else' placement"
    
    This reverts commit 0a8371bdfdd88e662d09def717cc0b822feb64e8.
    
    Change-Id: I946f449ad213cea70fbbd9cd3951f5838b9f82e5
    BUG: 1120646
    Signed-off-by: Harshavardhana <harsha>
    Reviewed-on: http://review.gluster.org/8927
    Reviewed-by: Jeff Darcy <jdarcy>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Niels de Vos <ndevos>

Comment 38 Anand Avati 2015-03-05 13:44:35 UTC

REVIEW: http://review.gluster.org/9813 (checkpatch: Update tree) posted (#1) for review on master by Kaushal M (kaushal)

Comment 39 Niels de Vos 2015-05-14 17:26:21 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 40 Niels de Vos 2015-05-14 17:35:29 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 41 Niels de Vos 2015-05-14 17:37:50 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 42 Niels de Vos 2015-05-14 17:42:42 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Note You need to log in before you can comment on or make changes to this bug.