Spec URL: https://github.com/projectatomic/golang-googlecode-gogoprotobuf-package Fedora Account System Username: walters Note: this is a fork of golang-googlecode-goprotobuf
Hi, I'd like to do this review. I haven't been able to get a full fedora-review to run against this, but building things by hand and running rpmlint brings up a few places to start. - Spec URL - Please point it to the actual spec file - SRPM URL - missing, please provide - Description - missing, not as important as the previous two. - Source: -- You don't have to tar it up by hand. You can have the source be Source0: https://gogoprotobuf.googlecode.com/archive/%{commit}.tar.gz -- Setup would then be %setup -q -n gogoprotobuf-%{shortcommit} - Changelog: -- There is no version in the changelog, should be * Thu Jul 17 2014 Colin Walters <walters> 0.7.gitd228c1a
Created attachment 921098 [details] tweaks on spec Comments about the attached patch: * remove macro boilerplate * fix arches for devel and exclusive arch * add version to golang * include all the rest of the libraries that are required * publish the import'able paths as Provides
(In reply to Troy Dawson from comment #1) > Hi, > I'd like to do this review. Sorry, I didn't see your comment since I didn't refresh the page. Feel free to take the review. You're welcome to review my comments as well ;-)
(In reply to Vincent Batts from comment #3) > (In reply to Troy Dawson from comment #1) > > Hi, > > I'd like to do this review. > > Sorry, I didn't see your comment since I didn't refresh the page. Feel free > to take the review. You're welcome to review my comments as well ;-) After reviewing your comments, I think you know more packaging the golang packages than I. I'll let you take it.
Hi, Colin, from spec file:13 # I produced this tarball with "git archive" Source0: %{name}-%{commit}.tar.gz can you give a rationale for this? Eventually a sequence of commands used to create this archive? Thanks
Now I see, there is no release, thus no valid source address Pull request with changes from Vincent and rpmlint created. Eric: https://github.com/projectatomic/golang-googlecode-gogoprotobuf-package/pull/1
Thanks Troy, Source0: https://gogoprotobuf.googlecode.com/archive/%{commit}.tar.gz applied.
Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-googlecode-gogoprotobuf/golang-googlecode-gogoprotobuf.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-googlecode-gogoprotobuf/golang-googlecode-gogoprotobuf-0-0.7.gitd228c1a.fc21.src.rpm Description: A fork of goprotobuf with several extra features $ rpmlint /root/rpmbuild/SRPMS/golang-googlecode-gogoprotobuf-0-0.7.gitd228c1a.fc21.src.rpm /root/rpmbuild/RPMS/x86_64/golang-googlecode-gogoprotobuf-0-0.7.gitd228c1a.fc21.x86_64.rpm /root/rpmbuild/RPMS/x86_64/golang-googlecode-gogoprotobuf-devel-0-0.7.gitd228c1a.fc21.x86_64.rpm golang-googlecode-gogoprotobuf.spec golang-googlecode-gogoprotobuf.src: W: spelling-error Summary(en_US) goprotobuf -> protoplasm golang-googlecode-gogoprotobuf.src: W: spelling-error %description -l en_US goprotobuf -> protoplasm golang-googlecode-gogoprotobuf.x86_64: W: spelling-error Summary(en_US) goprotobuf -> protoplasm golang-googlecode-gogoprotobuf.x86_64: W: spelling-error %description -l en_US goprotobuf -> protoplasm golang-googlecode-gogoprotobuf.x86_64: W: unstripped-binary-or-object /usr/bin/protoc-gen-gogo golang-googlecode-gogoprotobuf.x86_64: E: statically-linked-binary /usr/bin/protoc-gen-gogo golang-googlecode-gogoprotobuf.x86_64: W: no-manual-page-for-binary protoc-gen-gogo golang-googlecode-gogoprotobuf-devel.x86_64: W: spelling-error Summary(en_US) goprotobuf -> protoplasm golang-googlecode-gogoprotobuf-devel.x86_64: W: spelling-error %description -l en_US goprotobuf -> protoplasm 3 packages and 1 specfiles checked; 1 errors, 8 warnings. Initial commit by Colin Walters Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7592027 Package was not building on noarch architecture in koji, removed noarch from ExclusiveArch
Changes applied Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-googlecode-gogoprotobuf/golang-googlecode-gogoprotobuf.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-googlecode-gogoprotobuf/golang-googlecode-gogoprotobuf-0-0.8.gitd228c1a.fc21.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7633600
LGTM. Specfile follows golang package draft guidelines: https://fedoraproject.org/wiki/PackagingDrafts/Go
New Package SCM Request ======================= Package Name: golang-googlecode-gogoprotobuf Short Description: A fork of goprotobuf with several extra features Upstream URL: https://code.google.com/p/gogoprotobuf/ Owners: jchaloup lsm5 vbatts Branches: f21 f20 f19 el6 InitialCC: golang-sig
Git done (by process-git-requests).
golang-googlecode-gogoprotobuf-0-0.8.gitd228c1a.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-googlecode-gogoprotobuf-0-0.8.gitd228c1a.fc21
golang-googlecode-gogoprotobuf-0-0.8.gitd228c1a.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-gogoprotobuf-0-0.8.gitd228c1a.fc20
Package Change Request ====================== Package Name: golang-googlecode-gogoprotobuf New Branches: epel7 Owners: tdawson
golang-googlecode-gogoprotobuf-0-0.8.gitd228c1a.fc21 has been pushed to the Fedora 21 stable repository.
golang-googlecode-gogoprotobuf-0-0.8.gitd228c1a.fc20 has been pushed to the Fedora 20 stable repository.
golang-googlecode-gogoprotobuf-0-0.10.gitbc946d0.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-gogoprotobuf-0-0.10.gitbc946d0.fc20
golang-googlecode-gogoprotobuf-0-0.10.gitbc946d0.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-googlecode-gogoprotobuf-0-0.10.gitbc946d0.fc21
golang-googlecode-gogoprotobuf-0-0.10.gitbc946d0.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-gogoprotobuf-0-0.10.gitbc946d0.el6
golang-googlecode-gogoprotobuf-0-0.10.gitbc946d0.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
golang-googlecode-gogoprotobuf-0-0.10.gitbc946d0.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
golang-googlecode-gogoprotobuf-0-0.10.gitbc946d0.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.