Spec URL: http://cern.ch/straylen/rpms/rubygem-gyoku/rubygem-gyoku.spec
SRPM URL: http://cern.ch/straylen/rpms/rubygem-gyoku/rubygem-gyoku-1.1.1-1.fc20.src.rpm
Gyoku translates Ruby Hashes to XML.
Fedora Account System Username: stevetraylen
Let me review it.
- Mock build was failed.
$ mock -r fedora-rawhide-x86_64 rubygem-gyoku-1.1.1-1.fc20.src.rpm
Error: nothing provides rubygem(tins) >= 1.6.0 needed by rubygem-coveralls-0.8.10-1.fc24.noarch
The srpm file requires rubygem-coveralls in the spec file.
> BuildRequires: rubygem-coveralls
But it is not good that the package requires coverage modules such as rubygem-coveralls, simplecov, also bundler.
So, you can remove below lines in the spec file.
> Requires: rubygem(builder)
> BuildRequires: rubygem(coveralls)
> BuildRequires: rubygem(simplecov)
And replace spec/spec_helper.rb by the using sed command in %check section, not to run coverage.
See other package's spec files for reference:
- Unfortunately after your review request, the time has passed.
The gyoku latest version became 1.3.1 from 1.1.1.
You should update the version in rpm.
 To check other spec files, I used below way.
You can see rpm-specs-latest.tar.xz file at http://pkgs.fedoraproject.org/repo
This file includes all the latest spec files.
Downloaded the file.
Then to find the spec files that are using coverage module, using "sed" to replace, and new.
tar xf rpm-specs-latest.tar.xz
find . -name "rubygem-*" | xargs grep -l "sed -i" \
| xargs grep -l "cov" \
| xargs grep -A 10 "^%changelog"
(In reply to Jun Aruga from comment #1)
> Hi, Steve.
> Let me review it.
> - Mock build was failed.
> $ mock -r fedora-rawhide-x86_64 rubygem-gyoku-1.1.1-1.fc20.src.rpm
> Error: nothing provides rubygem(tins) >= 1.6.0 needed by
This is actually issue of Coveralls. But it seems that the yesterdays build (http://koji.fedoraproject.org/koji/buildinfo?buildID=743095) should fix that issue.
Also, looking at the .spec file, I'll note here a few random tips:
Use the %license macro, drop the unnecessary conditionals, use a wildcard for exclusion of the dot files.
So old, can't remember by why I wanted it. Apologies for the lack of response.