Description of problem:
We have a PR to address two issues to make the install a bit more robust in failure situations.
1. If anything goes wrong with yum, the install aborts immediately. The PR is to retry 3 times in case the failure is just something temporary.
2. If the rsync ssh key download fails, perhaps due to a timing issue, then the admin probably won't notice that it didn't work until they try to move a gear. The PR is to retry for 10 minutes.
Please test https://github.com/openshift/openshift-extras/pull/397
There is a mistake in openshift.sh from https://github.com/openshift/openshift-extras/pull/397, so transfer the bug status to ASSIGNED.
In function install_rsync_pub_key(), the while loop isn't executed due to wrong syntax in "while [ `date +%s` < $END ];".
I tested It should be "while [[ `date +%s` < $END ]]",then the loop can make sense.
Thanks, sorry about that.
Also, -lt is the correct operator to use here.
PR updated, please re-try.