Bug 1121556 - Data Center downgrade should not be allowed if it implies downgrading the storage format
Summary: Data Center downgrade should not be allowed if it implies downgrading the sto...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-core
Version: 3.4
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 3.5.2
Assignee: Amit Aviram
QA Contact: Ori Gofen
URL:
Whiteboard: storage
Depends On:
Blocks: 1193058 1196662 1197441
TreeView+ depends on / blocked
 
Reported: 2014-07-21 08:29 UTC by Allon Mureinik
Modified: 2016-05-26 01:48 UTC (History)
8 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-04-29 06:19:40 UTC
oVirt Team: Storage
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 35790 0 master MERGED core: Limitation addition for downgrading DC's compatible version. Never
oVirt gerrit 37478 0 ovirt-engine-3.5 MERGED core: Limitation addition for downgrading DC's compatible version. Never

Description Allon Mureinik 2014-07-21 08:29:42 UTC
Description of problem:
Downgrading a DC's compatibility version was introduced in oVirt 3.4 (see bug 1057029).
However, an additional validation is missing to make sure the DC isn't downgraded to a DC which supports a different storage format.

Without this validation, the implication is that you could, for example, theoretically create a 3.5 DC, have a 3.5 host connect to it and create a storage pool, and then downgrade it to a 3.0 DC while keeping the V3 storage format. This would mean you now have a 3.0 DC that 3.0 hosts can't connect to.

Note: This restriction should only apply if the DC has storage domains in it (i.e., if a storage pool was created).

Version-Release number of selected component (if applicable):
3.4.2 (see bug 1057029)

How reproducible:
100%

Steps to Reproduce:
1. Create a 3.5 DC
2. Create a 3.5 Cluster
3. Connect a host to the cluster
4. Create the first storage domain (implicitly creates the pool).

Attempt to downgrade the DC to 3.4: should succeed

Attempt to downgrade the DC to 3.0:
- In the UI, there should be no such option
- In REST API, you should get a canDoAction() error.

Comment 1 Eyal Edri 2015-02-26 12:33:13 UTC
this ovirt bug was fixed during 3.5.1 cycle and is included in the build, and therefore should be verified.

Comment 2 Ori Gofen 2015-03-19 09:13:43 UTC
verified on vt14: 
* From Rhevm-UI the option that downgrades the DC to 3.0 exists, but the action is blocked with CDA
* From Rest the operation is also blocked with CDA, with Error message:
"Cannot edit Data Center. This action will cause storage format downgrading which is not supported. The following storage domains cannot be downgraded: FCp_1,
FCp."

Comment 3 Eyal Edri 2015-04-29 06:19:40 UTC
ovirt 3.5.2 was GA'd. closing current release.


Note You need to log in before you can comment on or make changes to this bug.