Description of problem: On any system page the host names now contain end of lines code. Which when copying make copy and paste difficult. Before Beaker 0.17.0 this was not the case. Version-Release number of selected component (if applicable): How reproducible: 100% Steps to Reproduce: 1. Copy a name from a system page 2. Paste it in a terminal or any editor. 3. Actual results: ~]$ echo ~]$ deleted-01 -bash: deleted-01: command not found in vim with :set list on 1 $ 2 deleted-01$ 3 $ Expected results: Additional info:
This sounds like a regression rather than an RFE to me - marked accordingly.
That said, the page source still shows "<h1>FQDN</h1>" for me. I also don't see the behaviour of including a lineending when copying the text in Firefox 30 on Fedora 20.
Andrew, can you tell us exactly what piece of text you are copying from the system page, and how? Is it possible this is a change in behaviour of the browser? There were no changes in the system page template from Beaker 0.16 -> 0.17 (aside from the overall theme stuff). I do notice that if I triple-click on the system page heading, to select the FQDN, it copies it with a leading and trailing newline. I'm not sure why though (there are no newlines in the <h1/> element as Nick mentioned), and I'm not sure if that is a new behaviour or not.
I was selecting with click-and-drag and copying with Ctrl-C and didn't see any problems with spurious newlines.
Ah, yes, if I triple-click, then I get the spurious newlines. This looks relevant: https://bugzilla.mozilla.org/show_bug.cgi?id=819266 According to that, we're getting the newlines because triple-click is selecting the whole div, not just the header: <div class="page-header"> <h1>deleted-01</h1> </div> Changing the template to remove the newlines from the div would likely eliminate the behaviour: <div class="page-header"><h1>deleted-01</h1></div> Kind of annoying that FF isn't automatically stripping the surrounding whitespace from the selection, though.
I suggest just tweaking the template as part of the new system page changes: https://git.beaker-project.org/cgit/beaker/tree/Server/bkr/server/templates/system.kid?h=new-system-page#n47
On Gerrit: http://gerrit.beaker-project.org/#/c/3253/ Cheers, Matt Jia
Thanks I just tested this on devel and it works great
Beaker 0.18.0 has been released.