Spec URL: http://data-strzibny.rhcloud.com/obs/rubygem-font-awesome-rails.spec SRPM URL: http://data-strzibny.rhcloud.com/obs/rubygem-font-awesome-rails-4.1.0.0-1.fc22.src.rpm Description: A font-awesome icon font library for the Rails asset pipeline. Fedora Account System Username: jstribny
* rpmlint about E: script-without-shebang - There are some files with executable permission (including image files) which should not have. Please modify permission. * %license - Now we prefer to use %license for licensing files. * Unneeded Requires / Provides for rubygem related packages - As rubygem releated Requires /Provides dependencies are automatically generated on F-21 and above, writing these explicitly is no more needed. ! Latest version - (not a blocker) please consider to upgrade to the latest 4.2.0.0
* rpmlint about E: script-without-shebang --> Fixed * %license --> Fixed * Unneeded Requires / Provides for rubygem related packages --> I know about that, but there is only one require and it's not on RubyGem, therefor it's not generated * ! Latest version --> This is not possible if I want to reuse the files from already ready fontawesome-fonts package from fedora. It needs to have the same version. I can do updates only when fontawesome-fonts do them. Spec URL: http://data-strzibny.rhcloud.com/obs/rubygem-font-awesome-rails.spec SRPM URL: http://data-strzibny.rhcloud.com/obs/rubygem-font-awesome-rails-4.1.0.0-2.fc22.src.rpm
(In reply to Josef Stribny from comment #2) > * Unneeded Requires / Provides for rubygem related packages > --> I know about that, but there is only one require and it's not on > RubyGem, therefor it's not generated - Well, (for sure I redownloaded and) actually your -1.fc22.src.rpm contains -------------------------------- 13 Requires: ruby(release) 14 Requires: ruby(rubygems) 15 Requires: rubygem(railties) >= 3.2 16 Requires: rubygem(railties) < 5.0 27 Provides: rubygem(%{gem_name}) = %{version} -------------------------------- Perhaps you once created srpm, and the later you modified your spec file and uploaded them seperately... -2.fc22.src.rpm does not contain these, so it is okay. > * ! Latest version > --> This is not possible if I want to reuse the files from already ready > fontawesome-fonts package from fedora. It needs to have the same version. I > can do updates only when fontawesome-fonts do them. - Well, then version dependency should also be specified for "Requires: fontawesome-fonts". - By the way, you can ping fontawesome-fonts to upgrade it, or you can offer co-maintainership for that. Well some more comments for -2: * rubygem-font-awesome-rails-doc.noarch: E: non-executable-script /usr/share/gems/gems/font-awesome-rails-4.1.0.0/Rakefile 0644L /usr/bin/env - First of all, I wonder if shebang is needed for Rakefile... Please either * remove shebang * or make this have executable permission * or remove Rakefile at all (usually Rakefile is alike "makefile" for autotools based packages, and usually we don't include makefile or so in binary rpm - also see below) * Shipping test suite - Ruby guideline requests not to package test suite in binary rpm (like autotools based rpm): https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites See "Do not ship tests"
> Well, then version dependency should also be specified for "Requires: fontawesome-fonts". True, done. > I wonder if shebang is needed for Rakefile... Since it is part of -doc, no, I removed it. > * Shipping test suite I ship tests when upstream ships them. Spec URL: http://data-strzibny.rhcloud.com/obs/rubygem-font-awesome-rails.spec SRPM URL: http://data-strzibny.rhcloud.com/obs/rubygem-font-awesome-rails-4.1.0.0-3.fc22.src.rpm
Sorry for LOOOOONG delay. Will review again.
Josef, would you update srpm to 4.2.0.0?
Mamoru, as I wrote earlier I have to stay intact with the fontawesome dep[0]. Should I drop it and bundle the fonts instead? I though we will now on at least try not to duplicate fonts and JS if we can. [0] http://koji.fedoraproject.org/koji/packageinfo?packageID=17584
(In reply to Josef Stribny from comment #7) > Mamoru, > > as I wrote earlier I have to stay intact with the fontawesome dep[0]. Well, just I have forgotton that reason. Thanks for reminder. Now reviewing...
Oops... Error: Package: rubygem-font-awesome-rails-4.1.0.0-3.fc22.noarch (/rubygem-font-awesome-rails-4.1.0.0-3.fc22.noarch) Requires: fontawesome-fonts >= 4.1.0.0 Available: fontawesome-fonts-4.0.3-1.fc21.noarch (fedora) fontawesome-fonts = 4.0.3-1.fc21 Installing: fontawesome-fonts-4.1.0-1.fc21.noarch (local) fontawesome-fonts = 4.1.0-1.fc21 You could try using --skip-broken to work around the problem You could try running: rpm -Va --nofiles --nodigest Because: $ rpmdev-vercmp "4.1.0.0" "4.1.0" 4.1.0.0 > 4.1.0 Requires: fontawesome-fonts >= 4.1.0.0 cannot be satisfied by fontawesome-fonts-4.1.0-1.fc21 . Please modify this.
Spec URL: http://data-strzibny.rhcloud.com/obs/rubygem-font-awesome-rails.spec SRPM URL: http://data-strzibny.rhcloud.com/obs/rubygem-font-awesome-rails-4.1.0.0-4.fc22.src.rpm Oh yes, done.
Okay. -------------------------------------------------------- This package (rubygem-font-awesome-rails) is APPROVED by mtasaka --------------------------------------------------------
Thanks. New Package SCM Request ======================= Package Name: rubygem-font-awesome-rails Short Description: An asset gemification of the font-awesome icon font library Upstream URL: https://github.com/bokmann/font-awesome-rails Owners: jstribny Branches: f21 InitialCC:
Git done (by process-git-requests).
Thanks.