1122973 – missing pci address for vga devices

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1122973 - missing pci address for vga devices

Summary: missing pci address for vga devices

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	libvirt
Sub Component:
Version:	7.0
Hardware:	ppc64
OS:	Unspecified
Priority:	unspecified
Severity:	unspecified
Target Milestone:	rc
Target Release:	7.1
Assignee:	Libvirt Maintainers
QA Contact:	Virtualization Bugs
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:	1122979
TreeView+	depends on / blocked

Reported:	2014-07-24 13:44 UTC by Francesco Romani
Modified:	2015-11-19 02:05 UTC (History)
CC List:	13 users (show)
Fixed In Version:	libvirt-1.2.7-1.el7
Doc Type:	Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:	2015-03-05 07:41:36 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)
example xml to be fed to virsh createxml (3.44 KB, text/xml) 2014-07-24 13:44 UTC, Francesco Romani	no flags	Details
View All

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2015:0323	0	normal	SHIPPED_LIVE	Low: libvirt security, bug fix, and enhancement update	2015-03-05 12:10:54 UTC

Description Francesco Romani 2014-07-24 13:44:11 UTC

Created attachment 920542 [details]
example xml to be fed to virsh createxml

Description of problem:
When creating a domain with a VGA video device, the device doesn't get a pci address in the XML domain representation:

relevant snippet:
    <video>
      <model type='vga' vram='32768' heads='1'/>
      <alias name='video0'/>
    </video>


However, on x86_64, this happens:
    <video>
      <model type='vga' vram='32768' heads='1'/>
      <alias name='video0'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
    </video>


Input XML for both cases is

...
  <devices>
    ...
     <video>
       <model heads="1" type="vga" vram="32768"/>
     </video>
    ...
  </devices>
...

Version-Release number of selected component (if applicable):
libvirt-1.1.3-1.pkvm2_1.17.3.ppc64


How reproducible:
100% of times in my experiments


Steps to Reproduce:
1. create a domain with a vga device
2. get back the xml representation from libvirt (virsh dumpxml...)
3.

Actual results:
the vga device has not an address element, unlike x86_64


Expected results:
the vga device has not an address element, unlike x86_64


Additional info:
example domain XML attached

Comment 2 Ján Tomko 2014-07-24 14:31:43 UTC

This has been fixed upstream by:
commit 54e4d9d081e816b35a097ddd2596899cc3846b1a
Author:     Vitor de Lima <vitor.lima.br>
AuthorDate: 2013-11-06 14:13:54 -0200
Commit:     Laine Stump <laine>
CommitDate: 2013-11-08 12:48:32 +0200

    qemu: assign PCI address to primary video card
    
    When adding support for Q35 guests, the code to assign a PCI address
    to the primary video card was moved into Q35 and i440fx(PIIX3)
    specific functions, but no fallback was kept for other machine types
    that might have a video card.
    
    This patch remedies that by assigning a PCI address to the primary
    video card if it does not have any kind of address.  In particular,
    this fixes issues with pseries guests.
    
    Signed-off-by: Vitor de Lima <vitor.lima.br>
    Signed-off-by: Laine Stump <laine>

git describe: v1.1.4-57-g54e4d9d contains: v1.2.0-rc1~106

Comment 6 Luyao Huang 2014-12-08 01:11:11 UTC

Verify this bug with libvirt-1.2.8-10.el7.ppc64:
1. prepare a guest xml with vga video:
# cat test3.xml
     <video>
       <model heads="1" type="vga" vram="32768"/>
     </video>

2. create it :

# virsh create test3.xml 
Domain test3-lhuang created from test3.xml

3.check the xml:
# virsh dumpxml test3-lhuang
    <video>
      <model type='vga' vram='32768' heads='1'/>
      <alias name='video0'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
    </video>

Also test with define and start, no issue found.

Check the code: in src/qemu/qemu_command.c

 2249     /* Assign a PCI slot to the primary video card if there is not an
 2250      * assigned address. */
 2251     if (def->nvideos > 0 &&
 2252         def->videos[0]->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) {
 2253         if (virDomainPCIAddressReserveNextSlot(addrs, &def->videos[0]->info,
 2254                                                flags) < 0)
 2255             goto error;
 2256     }

Comment 8 errata-xmlrpc 2015-03-05 07:41:36 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-0323.html

Note You need to log in before you can comment on or make changes to this bug.