Bug 1123327 - Make CONFIG_LOG_BUF_SHIFT bigger on arm64 [NEEDINFO]
Summary: Make CONFIG_LOG_BUF_SHIFT bigger on arm64
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: kernel
Version: rawhide
Hardware: aarch64
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kernel Maintainer List
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-07-25 10:21 UTC by Richard W.M. Jones
Modified: 2014-10-21 18:58 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-10-21 18:58:35 UTC
rjones: needinfo? (kernel-maint)


Attachments (Terms of Use)

Description Richard W.M. Jones 2014-07-25 10:21:31 UTC
Description of problem:

On x86-64:
CONFIG_LOG_BUF_SHIFT=18

On ARM64:
CONFIG_LOG_BUF_SHIFT=14

This is annoying because messages scroll off the log buffer
very easily :-(

ARM64 machines have plenty of memory, so there seems no reason
why we shouldn't have a larger log buffer.

The patch is trivial:

diff --git a/config-arm64 b/config-arm64
index be0c3cb..b7e7bf1 100644
--- a/config-arm64
+++ b/config-arm64
@@ -45,7 +45,7 @@ CONFIG_HZ=100
 
 CONFIG_KVM=y
 CONFIG_KVM_ARM_MAX_VCPUS=8
-CONFIG_LOG_BUF_SHIFT=14
+CONFIG_LOG_BUF_SHIFT=18
 
 CONFIG_NFS_ACL_SUPPORT=y
 CONFIG_NFS_COMMON=y

Version-Release number of selected component (if applicable):

kernel-3.16.0-0.rc6.git1.1.fc22

Comment 1 Richard W.M. Jones 2014-07-25 10:22:43 UTC
Actually I think the patch is to remove that line completely
so it inherits from config-generic.

Comment 2 Josh Boyer 2014-07-25 12:05:20 UTC
(In reply to Richard W.M. Jones from comment #1)
> Actually I think the patch is to remove that line completely
> so it inherits from config-generic.

Right.  Adding the ARM guys on CC to weigh in.

Comment 4 Richard W.M. Jones 2014-10-21 10:12:03 UTC
This is a -1 line patch.  What can I do to get this actioned?  Can
I just push the fix myself?

diff --git a/config-arm64 b/config-arm64
index 29a2436..bdcc9b9 100644
--- a/config-arm64
+++ b/config-arm64
@@ -42,7 +42,6 @@ CONFIG_HZ=100
 
 CONFIG_KVM=y
 CONFIG_KVM_ARM_MAX_VCPUS=8
-CONFIG_LOG_BUF_SHIFT=14
 
 CONFIG_NFS_ACL_SUPPORT=y
 CONFIG_NFS_COMMON=y

Comment 5 Josh Boyer 2014-10-21 12:23:28 UTC
I'll change it in today's rawhide build.


Note You need to log in before you can comment on or make changes to this bug.