Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1123768

Summary:	mem_acct : Check return value of xlator_mem_acct_init()
Product:	[Community] GlusterFS	Reporter:	Humble Chirammal <hchiramm>
Component:	core	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	high
Version:	mainline	CC:	gluster-bugs
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-05-14 17:26:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Humble Chirammal 2014-07-28 08:33:08 UTC

Description of problem:


Glusterfs code does not check  xlator_mem_acct_init()
return in some places, thus fails to capture wrong memory accounting
initialization. 

Version-Release number of selected component (if applicable):


GlusterFS 3.5

How reproducible:

N/A

Steps to Reproduce:

N/A

Actual results:


Expected results:

It should check the return for failures/success.

Comment 1 Anand Avati 2014-08-06 11:31:25 UTC

REVIEW: http://review.gluster.org/7728 (mem_acct : Check return value of xlator_mem_acct_init()) posted (#8) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 2 Anand Avati 2014-08-06 11:35:47 UTC

REVIEW: http://review.gluster.org/7728 (mem_acct : Check return value of xlator_mem_acct_init()) posted (#9) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 3 Anand Avati 2014-09-19 09:07:08 UTC

REVIEW: http://review.gluster.org/7728 (mem_acct : Check return value of xlator_mem_acct_init()) posted (#10) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 4 Anand Avati 2014-09-19 09:20:51 UTC

REVIEW: http://review.gluster.org/7728 (mem_acct : Check return value of xlator_mem_acct_init()) posted (#11) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 5 Anand Avati 2014-11-12 09:32:41 UTC

REVIEW: http://review.gluster.org/7728 (mem_acct : Check return value of xlator_mem_acct_init().) posted (#12) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 6 Anand Avati 2014-11-15 18:13:16 UTC

COMMIT: http://review.gluster.org/7728 committed in master by Vijay Bellur (vbellur) 
------
commit 656711d935000c161012c25340dbd65a59999dc3
Author: Humble Chirammal <hchiramm>
Date:   Fri May 9 15:30:04 2014 +0530

    mem_acct : Check return value of xlator_mem_acct_init().
    
    some code does not check xlator_mem_acct_init()
    return, thus fails to capture wrong memory accounting
    initialization. This patch fix the same.
    
    Change-Id: I01eab19d6cef472afd850b0f964132c01523492a
    BUG: 1123768
    Signed-off-by: Humble Chirammal <hchiramm>
    Reviewed-on: http://review.gluster.org/7728
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

Comment 7 Niels de Vos 2015-05-14 17:26:50 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 8 Niels de Vos 2015-05-14 17:35:30 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 9 Niels de Vos 2015-05-14 17:37:52 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 10 Niels de Vos 2015-05-14 17:42:55 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user