Bug 1123778

FYI the problem is bigger:

./python/examples/api/spout -c 1 "amq.fanout;{node:{type:queue}}"

should send a message to _queue_, but if there is no such queue, it sends the message to the _exchange_ :-/

Scenario A: expected results should be just with "action:access" and no "action:publish", as publish is for queue object (and in our case, the message is discarded by the exchange due to no route/binding).

Scenario B: proper ACL file content should be:

acl allow-log all access all
acl allow-log all create queue
acl deny-log all all

(two typos were there)

Btw. it is questonable if queue query in Scenario B can't be done (/me to think about it and ask gsim).

Apart of that, I have a patch:

Index: python/qpid/messaging/driver.py
===================================================================
--- python/qpid/messaging/driver.py	(revision 1617701)
+++ python/qpid/messaging/driver.py	(working copy)
@@ -122,9 +122,9 @@
 
     self.destinations = {}
 
-  def write_query(self, query, handler):
+  def write_query(self, query, handler, obj):
     id = self.sent
-    self.write_cmd(query, lambda: handler(self.results.pop(id)))
+    self.write_cmd(query, lambda: handler(self.results.pop(id), obj))
 
   def apply_overrides(self, cmd, overrides):
     for k, v in overrides.items():
@@ -1012,36 +1012,46 @@
       except KeyError:
         pass
 
-    args = []
-    def do_result(r):
-      args.append(r)
-    def do_action(r):
-      do_result(r)
-      er, qr = args
-      if node_type == "topic" and not er.not_found:
+    args = {"topic":None, "queue":None}
+    def do_result(r, obj):
+      args[obj] = r
+    def do_action(r, obj):
+      do_result(r, obj)
+      er = args["topic"]
+      qr = args["queue"]
+
+      if node_type == "topic" and er and not er.not_found:
         type, subtype = "topic", er.type
-      elif node_type == "queue" and qr.queue:
+      elif node_type == "queue" and qr and qr.queue:
         type, subtype = "queue", None
-      elif er.not_found and not qr.queue:
+      elif (er and er.not_found) and qr and not qr.queue:
         type, subtype = None, None
-      elif qr.queue:
+      elif (qr and qr.queue):
         if node_type == "topic" and force:
           type, subtype = None, None
         else:
           type, subtype = "queue", None
-      elif not er.not_found:
+      elif (er and not er.not_found):
         if node_type == "queue" and force:
           type, subtype = None, None
         else:
           type, subtype = "topic", er.type
+      elif er:
+        type, subtype = "topic", er.type
       else:
-        type, subtype = "topic", er.type
+        type, subtype = None, None
       if type is not None:
         self.address_cache[name] = (type, subtype)
       action(type, subtype)
-    sst.write_query(ExchangeQuery(name), do_result)
-    sst.write_query(QueueQuery(name), do_action)
 
+    if (node_type is None):
+      sst.write_query(ExchangeQuery(name), do_result, "topic")
+      sst.write_query(QueueQuery(name), do_action, "queue")
+    elif (node_type == "topic"):
+      sst.write_query(ExchangeQuery(name), do_action, "topic")
+    else:
+      sst.write_query(QueueQuery(name), do_action, "queue")
+
   def declare(self, sst, lnk, action, create_node):
     name = lnk.name
     props = lnk.options.get("node", {})

Created attachment 926687 [details]
Patch proposal

Patch proposal (before running automated tests)

Created attachment 927455 [details]
Patch proposal (not 100% ideal)

Better patch that fixes almost everything.

What it fixes:
- scenario A
- scenario B subcase "access:topic"
- spout -c 1 "amq.fanout;{node:{type:queue}}" (raises "qpid.messaging.exceptions.NotFound: no such queue: amq.fanout")

What it does not fix:
- scenario B subcase "access:queue"

The Python client is quite tighten to get in advance the knowledge of queue/topic objects on the broker, hence requiring the access ACLs checks. It can be limited only to accessing the type mentioned in address string as I did. Fixing the remaining scenario would require changing a lot of code I am not courage enough to do (dont want to infest a regression there).

Zdenek, could you please run your tests if there is no regression? Upstream automated tests went fine.

I've launched the tests, but I'm afraid that your patch is tailored for the upstream python only. Firstly it don't apply same as previous one: 
#patch:
78:  def declare(self, sst, lnk, action, create_node):
#python-qpid-0.22-17 driver.py:
1021:  def declare(self, sst, lnk, action)

secondly because of the runtime error:

  Traceback (most recent call last):
    File "/usr/lib/python2.6/site-packages/qpid/messaging/driver.py", line 660, in write
      op.dispatch(self)
    File "/usr/lib/python2.6/site-packages/qpid/ops.py", line 84, in dispatch
      getattr(target, handler)(self, *args)
    File "/usr/lib/python2.6/site-packages/qpid/messaging/driver.py", line 780, in do_session_completed
      sst.actions.pop(sst.min_completion)()
    File "/usr/lib/python2.6/site-packages/qpid/messaging/driver.py", line 126, in <lambda>
      self.write_cmd(query, lambda: handler(self.results.pop(id), obj))
  TypeError: do_action() takes no arguments (2 given)

Created attachment 937991 [details]
Patch proposal for 0.22 downstream

Patch proposal for python-qpid-0.22-18.el6.noarch.

Zdenek, could you pls. run the tests?

(In reply to Zdenek Kraus from comment #5)
> I've launched the tests, but I'm afraid that your patch is tailored for the
> upstream python only. Firstly it don't apply same as previous one: 
> #patch:
> 78:  def declare(self, sst, lnk, action, create_node):
> #python-qpid-0.22-17 driver.py:
> 1021:  def declare(self, sst, lnk, action)
> 
> secondly because of the runtime error:
> 
>   Traceback (most recent call last):
>     File "/usr/lib/python2.6/site-packages/qpid/messaging/driver.py", line
> 660, in write
>       op.dispatch(self)
>     File "/usr/lib/python2.6/site-packages/qpid/ops.py", line 84, in dispatch
>       getattr(target, handler)(self, *args)
>     File "/usr/lib/python2.6/site-packages/qpid/messaging/driver.py", line
> 780, in do_session_completed
>       sst.actions.pop(sst.min_completion)()
>     File "/usr/lib/python2.6/site-packages/qpid/messaging/driver.py", line
> 126, in <lambda>
>       self.write_cmd(query, lambda: handler(self.results.pop(id), obj))
>   TypeError: do_action() takes no arguments (2 given)

That was a typo in the patch, attached is now correct version.

I can confirm that the patch fixes the issue described.

Created attachment 1038103 [details]
Updated patch to pass all python tests

Several python tests were failing with the original patch.

Committed http://svn.apache.org/viewvc?view=revision&revision=1685116

This was tested on RHEL 6 i686 & x86_64, RHEL 7 x86_64 with following packages:

python-qpid-0.34-1
python-qpid-qmf-0.34-1
qpid-cpp-client-0.34-1
qpid-cpp-client-devel-0.34-1
qpid-cpp-debuginfo-0.34-1
qpid-cpp-server-0.34-1
qpid-java-client-0.32-2
qpid-java-common-0.32-2
qpid-java-example-0.32-2
qpid-jms-client-0.2.0-2
qpid-jms-client-docs-0.2.0-2
qpid-jms-client-examples-0.2.0-2
qpid-jms-client-maven-repo-0.2.0-2
qpid-proton-c-0.9-4
qpid-proton-java-0.9.1-2
qpid-proton-java-maven-repo-0.9.1-2
qpid-qmf-0.34-1
qpid-tools-0.34-1


fix works as expected.

->VERIFIED

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2015-1879.html