In many places where we fail to get the right value we log it as "non interactive user" in AuditLogDirector.java. It's very confusing, it should say "unknown" or" N/A", even "NULL" would better than this
well it was "UNKNOWN" but seems like a wrong fix for bug 922520 caused this, changing the global value used everywhere for something that is correct only to a subset of cases.
pls fix bug 922520 in a different way and revert back to "UNKNOWN" for the generic logger
It is an internal system-process running, so using SYSTEM/OVIRT-ENGINE/INTERNAL looks like the right thing here. Thoughts?
(In reply to Oved Ourfali from comment #3) not in all cases. Sometimes it just means an empty NULL value (not)coming from VDSM/guest-agent for example I believe UNKNOWN is the most universal
(In reply to Michal Skrivanek from comment #4) > (In reply to Oved Ourfali from comment #3) > not in all cases. Sometimes it just means an empty NULL value (not)coming > from VDSM/guest-agent for example > I believe UNKNOWN is the most universal Which makes it kinda system operation. I don't want to get in the loop of the UNKNOWN entry again. Either we change to something with more meaning, or leave it as non-interactive user... which is what it is....
(In reply to Oved Ourfali from comment #5) I prefer "Application list: UNKNOWN" rather than "Application List: Non-Interactive user";-) The point here is that what Douglas fixed was this specific case where it wasn't really unknown, so we should have added a specific log message with different wording for that one case. We can add all the specific cases, e.g. "Applist: empty" or such, for now anything's better than non-interactive user for all but that one case.
(In reply to Michal Skrivanek from comment #6) > (In reply to Oved Ourfali from comment #5) > I prefer "Application list: UNKNOWN" rather than "Application List: > Non-Interactive user";-) > > The point here is that what Douglas fixed was this specific case where it > wasn't really unknown, so we should have added a specific log message with > different wording for that one case. > We can add all the specific cases, e.g. "Applist: empty" or such, for now > anything's better than non-interactive user for all but that one case. Why not fixing this specific use-case as well? Not to print it if it is empty?
that's what I'm saying, sure, fix them all…but there are other places like this (not sure how many). But again there should be no "default" like Non-interactive user anywhere - either eliminate it completely which might be tricky or put back Unknown or N/A or NULL or something
(In reply to Michal Skrivanek from comment #8) > that's what I'm saying, sure, fix them all…but there are other places like > this (not sure how many). But again there should be no "default" like > Non-interactive user anywhere - either eliminate it completely which might > be tricky or put back Unknown or N/A or NULL or something Do you have other use-cases in which "SYSTEM" won't do?
Don't know, it's a "UNKNOWN_VARIABLE_VALUE" so it can be anywhere. I just see it frequently in guest agent's app list and/or user name, and sometimes during migration (I think during reruns), there are probably many other cases, it's always a mistake as the variable in the message we log is null
OK. I see what you mean. For some reason I thought it is only used when referred to User.... didn't understand it is generic. My bad. Will fix it.
some examples to take into consideration: "VM xp-1 configuration was updated by Non interactive user." above its good, but the next 2 doesn't make sense, probably the previous "unknown" was good.. "Host dubi.tlv.redhat.com cannot access the Storage Domain(s) Non interactive user attached to the Data Center omer. Setting Host state to Non-Operational." "Migration failed due to Error: Fatal error during migration. Trying to migrate to another Host (VM: f19-testday, Source: ziggy.tlv.redhat.com, Destination: Non interactive user)." previously it was: "VM external-f19-ci1 was created by <UNKNOWN>."
(In reply to Omer Frenkel from comment #12) > some examples to take into consideration: > "VM xp-1 configuration was updated by Non interactive user." > > above its good, but the next 2 doesn't make sense, probably the previous > "unknown" was good.. > > "Host dubi.tlv.redhat.com cannot access the Storage Domain(s) Non > interactive user attached to the Data Center omer. Setting Host state to > Non-Operational." > > "Migration failed due to Error: Fatal error during migration. Trying to > migrate to another Host (VM: f19-testday, Source: ziggy.tlv.redhat.com, > Destination: Non interactive user)." > > previously it was: > "VM external-f19-ci1 was created by <UNKNOWN>." I think <UNKNOWN> fits all. Don't see the use in now splitting different "unknown" values per domain of interest.
rhev 3.5.0 was released. closing.