1123908 – block.c: multiwrite_merge() truncates overlapping requests

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1123908 - block.c: multiwrite_merge() truncates overlapping requests

Summary: block.c: multiwrite_merge() truncates overlapping requests

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	qemu-kvm-rhev
Sub Component:
Version:	7.1
Hardware:	Unspecified
OS:	Unspecified
Priority:	unspecified
Severity:	unspecified
Target Milestone:	rc
Target Release:	---
Assignee:	Stefan Hajnoczi
QA Contact:	Virtualization Bugs
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2014-07-28 15:32 UTC by Stefan Hajnoczi
Modified:	2015-03-05 09:48 UTC (History)
CC List:	7 users (show)
Fixed In Version:	qemu-kvm-rhev-2.1.2-4.el7
Doc Type:	Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:	2015-03-05 09:48:45 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Launchpad	1343827	0	None	None	None	Never
Red Hat Product Errata	RHSA-2015:0624	0	normal	SHIPPED_LIVE	Important: qemu-kvm-rhev security, bug fix, and enhancement update	2015-03-05 14:37:36 UTC

Description Stefan Hajnoczi 2014-07-28 15:32:34 UTC

Description of problem:
When two write requests overlap, multiwrite_merge() may truncate the longer request.

See upstream bug report for details:
https://bugs.launchpad.net/qemu/+bug/1343827

Tasks:
1. Write qemu-iotests test case that demonstrates the problem.
2. Develop multiwrite_merge() fix that makes the test pass.

Comment 2 Stefan Hajnoczi 2014-10-03 15:56:07 UTC

Backport posted.

Comment 5 Miroslav Rezanina 2014-10-20 07:29:38 UTC

Fix included in qemu-kvm-rhev-2.1.2-4.el7

Comment 7 Shaolong Hu 2014-10-29 11:32:55 UTC

Reproduced by git checkout qemu-kvm-rhev-2.1.2-3.el7:

1.
git checkout qemu-kvm-rhev-2.1.2-3.el7

./configure && make

cd test/qemu-iotests/

./check 100
QEMU          -- /root/qemu-kvm/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64
QEMU_IMG      -- /root/qemu-kvm/tests/qemu-iotests/../../qemu-img
QEMU_IO       -- /root/qemu-kvm/tests/qemu-iotests/../../qemu-io 
QEMU_NBD      -- /root/qemu-kvm/tests/qemu-iotests/../../qemu-nbd
IMGFMT        -- raw
IMGPROTO      -- file
PLATFORM      -- Linux/x86_64 localhost 3.10.0-187.el7.x86_64
SOCKET_SCM_HELPER -- /root/qemu-kvm/tests/qemu-iotests/socket_scm_helper

100         - output mismatch (see 100.out.bad)
--- /root/qemu-kvm/tests/qemu-iotests/100.out	2014-10-29 19:28:03.640004106 +0800
+++ 100.out.bad	2014-10-29 19:28:17.518715688 +0800
@@ -32,6 +32,7 @@
 == verify pattern ==
 read 1024/1024 bytes at offset 0
 1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
+Pattern verification failed at offset 3072, 1024 bytes
 read 1024/1024 bytes at offset 3072
 1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 read 4096/4096 bytes at offset 4096
@@ -45,6 +46,7 @@
 == verify pattern ==
 read 1024/1024 bytes at offset 0
 1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
+Pattern verification failed at offset 3072, 1024 bytes
 read 1024/1024 bytes at offset 3072
 1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 read 4096/4096 bytes at offset 4096
Failures: 100
Failed 1 of 1 tests


Verified on qemu-kvm-rhev-2.1.2-5.el7:

git checkout qemu-kvm-rhev-2.1.2-5.el7

repeat the above test:

# ./check 100
QEMU          -- /root/qemu-kvm/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64
QEMU_IMG      -- /root/qemu-kvm/tests/qemu-iotests/../../qemu-img
QEMU_IO       -- /root/qemu-kvm/tests/qemu-iotests/../../qemu-io 
QEMU_NBD      -- /root/qemu-kvm/tests/qemu-iotests/../../qemu-nbd
IMGFMT        -- raw
IMGPROTO      -- file
PLATFORM      -- Linux/x86_64 localhost 3.10.0-187.el7.x86_64
SOCKET_SCM_HELPER -- /root/qemu-kvm/tests/qemu-iotests/socket_scm_helper

100        
Passed all 1 tests

Comment 9 errata-xmlrpc 2015-03-05 09:48:45 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-0624.html

Note You need to log in before you can comment on or make changes to this bug.