Spec URL: https://fedorapeople.org/~jskarvad/amprd/amprd.spec SRPM URL: https://fedorapeople.org/~jskarvad/amprd/amprd-1.4-1.fc20.src.rpm Description: An user-space IPIP encapsulation daemon with automatic RIPv2 multicast processing and multiple tunnel support for the ampr network. All RIPv2 processing, encapsulation, decapsulation and routing happens inside the daemon and it offers one or more virtual TUN interfaces to the system for your 44net traffic. Fedora Account System Username: jskarvad
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "*No copyright* GPL (v2 or later) (with incorrect FSF address)", "*No copyright* GPL (v3 or later)", "Unknown or generated". 14 files have unknown license. Detailed output of licensecheck in /home/jsynacek/work/reviews/amprd/1124482-amprd/licensecheck.txt [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: amprd-1.4-1.fc22.x86_64.rpm amprd-1.4-1.fc22.src.rpm amprd.x86_64: W: spelling-error Summary(en_US) ampr -> amp, ramp, amps amprd.x86_64: W: spelling-error %description -l en_US multicast -> Multics, simulcast amprd.x86_64: W: spelling-error %description -l en_US ampr -> amp, ramp, amps amprd.x86_64: W: spelling-error %description -l en_US decapsulation -> encapsulation, decapitation, depopulation amprd.x86_64: E: incorrect-fsf-address /usr/share/doc/amprd/README amprd.x86_64: W: no-manual-page-for-binary amprd amprd.src: W: spelling-error Summary(en_US) ampr -> amp, ramp, amps amprd.src: W: spelling-error %description -l en_US multicast -> Multics, simulcast amprd.src: W: spelling-error %description -l en_US ampr -> amp, ramp, amps amprd.src: W: spelling-error %description -l en_US decapsulation -> encapsulation, decapitation, depopulation 2 packages and 0 specfiles checked; 1 errors, 9 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint amprd amprd.x86_64: W: spelling-error Summary(en_US) ampr -> amp, ramp, amps amprd.x86_64: W: spelling-error %description -l en_US multicast -> Multics, simulcast amprd.x86_64: W: spelling-error %description -l en_US ampr -> amp, ramp, amps amprd.x86_64: W: spelling-error %description -l en_US decapsulation -> encapsulation, decapitation, depopulation amprd.x86_64: E: incorrect-fsf-address /usr/share/doc/amprd/README amprd.x86_64: W: no-manual-page-for-binary amprd 1 packages and 0 specfiles checked; 1 errors, 5 warnings. # echo 'rpmlint-done:' Requires -------- amprd (rpmlib, GLIBC filtered): /bin/sh config(amprd) libc.so.6()(64bit) rtld(GNU_HASH) systemd Provides -------- amprd: amprd amprd(x86-64) config(amprd) Source checksums ---------------- http://www.yo2loj.ro/hamprojects/amprd-1.4.tgz : CHECKSUM(SHA256) this package : 326ac7fac09b9810a48c8cc658fcacf975a6afb033a6c9dbd56cd9c516a2976e CHECKSUM(SHA256) upstream package : 326ac7fac09b9810a48c8cc658fcacf975a6afb033a6c9dbd56cd9c516a2976e Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -b 1124482 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
According to the author, FSF address correction has been communicated to upstream. No problem. Specfile defines %global ldflags_harden, but uses _ldflags_harden in LDFLAGS. Licenses are OK. Manual check of source files and resulting package looks sane, no problems spotted.
(In reply to Jan Synacek from comment #2) Thanks for the review, new vesion: Spec URL: https://fedorapeople.org/~jskarvad/amprd/amprd.spec SRPM URL: https://fedorapeople.org/~jskarvad/amprd/amprd-1.4-2.fc20.src.rpm
All seems fine now. ACCEPTing.
New Package SCM Request ======================= Package Name: amprd Short Description: An user-space IPIP encapsulation daemon for the ampr network Upstream URL: http://www.yo2loj.ro/hamprojects/ Owners: jskarvad Branches: f20 f21 InitialCC:
Git done (by process-git-requests).
(In reply to Jon Ciesla from comment #6) > Git done (by process-git-requests). Thanks.
amprd-1.4-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/amprd-1.4-2.fc21
amprd-1.4-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/amprd-1.4-2.fc20
amprd-1.4-2.fc20 has been pushed to the Fedora 20 stable repository.
amprd-1.4-2.fc21 has been pushed to the Fedora 21 stable repository.