Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1124858

Summary: building on EPEL-5 fails with unittest/dht_layout_mock.c
Product: [Community] GlusterFS Reporter: Niels de Vos <ndevos>
Component: buildAssignee: Niels de Vos <ndevos>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, gluster-bugs
Target Milestone: ---Keywords: EasyFix, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.7.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-05-14 17:26:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
build.log from http://copr-be.cloud.fedoraproject.org/results/devos/glusterfs/epel-5-i386/glusterfs-3.7dev-0.34.git67a6f40.autobuild/build.log none

Description Niels de Vos 2014-07-30 13:18:01 UTC 
Created attachment 922581 [details]
build.log from http://copr-be.cloud.fedoraproject.org/results/devos/glusterfs/epel-5-i386/glusterfs-3.7dev-0.34.git67a6f40.autobuild/build.log

Description of problem:
EPEL-5 (both x86_64 and i386) fail with the following error:

  CC     dht_layout_unittest-dht_layout_mock.o
unittest/dht_layout_mock.c:77:2: error: no newline at end of file
make[5]: *** [dht_layout_unittest-dht_layout_mock.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [all-recursive] Error 1
make[3]: *** [all-recursive] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

Version-Release number of selected component (if applicable):
current master branch

How reproducible:
100%

Steps to Reproduce:
1. start a build on EPEL-5 (RHEL-5, CentOS-5 and the like)

Actual results:
Failure while compiling a test case.

Expected results:
Compiling should succeed.

Additional info:
Comment 1 Anand Avati 2014-07-30 13:25:11 UTC 
REVIEW: http://review.gluster.org/8392 (build: fix compile issue in unittest on EPEL-5) posted (#1) for review on master by Niels de Vos (ndevos)
Comment 2 Anand Avati 2014-07-30 15:28:11 UTC 
COMMIT: http://review.gluster.org/8392 committed in master by Niels de Vos (ndevos) 
------
commit 60f2e231bbf4daef11793710bb69bdfbcfca89a1
Author: Niels de Vos <ndevos>
Date:   Wed Jul 30 15:19:38 2014 +0200

    build: fix compile issue in unittest on EPEL-5
    
    When building the current master branch on EPEL-5, the following error
    is observed:
    
          CC     dht_layout_unittest-dht_layout_mock.o
        unittest/dht_layout_mock.c:77:2: error: no newline at end of file
        make[5]: *** [dht_layout_unittest-dht_layout_mock.o] Error 1
        make[5]: *** Waiting for unfinished jobs....
    
    EPEL-5 has this gcc:
    
        $ gcc --version
        gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-54)
    
    The fix is simple enough, dht_layout_unittest-dht_layout_mock.c should
    have a line ending.
    
    BUG: 1124858
    Change-Id: I8ca7a1699fd1c35694073b9577f94ae525854713
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/8392
    Reviewed-by: Lalatendu Mohanty <lmohanty>
    Reviewed-by: Humble Devassy Chirammal <humble.devassy>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Luis Pabon <lpabon>
Comment 3 Niels de Vos 2015-05-14 17:26:51 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user
Comment 4 Niels de Vos 2015-05-14 17:35:30 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user
Comment 5 Niels de Vos 2015-05-14 17:37:52 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user
Comment 6 Niels de Vos 2015-05-14 17:42:55 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user