Bug 1125379 - RFE: Better support in --scm-enable for repositories with a depth greater than 1
Summary: RFE: Better support in --scm-enable for repositories with a depth greater than 1
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: mock
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Miroslav Suchý
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-07-31 17:14 UTC by Eric Schnoebelen
Modified: 2018-08-18 11:29 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:


Attachments (Terms of Use)
Patch to add the desired features to mock (2.01 KB, patch)
2014-07-31 17:14 UTC, Eric Schnoebelen
no flags Details | Diff

Description Eric Schnoebelen 2014-07-31 17:14:48 UTC
Created attachment 923009 [details]
Patch to add the desired features to mock

Description of problem:

The SCM integration within mock makes some specific assumptions about the nature of the SCM repository.  Unfortunately, the product repository I am building out of does not follow the assumption that all buildable elements of a repository are at level one.

Version-Release number of selected component (if applicable):
1.1.41

How reproducible:
Using SCM integration, attempt to check out and build an item two more levels below the top of the SCM tree.

Steps to Reproduce:
1. enable SCM integration
2. use a source repository more than two levels deep (we use CVS as the VCS)
   mock -r <> --scm-enable --scm-option branch=branch --scm-option package=Products/Group-A/product-a

Actual results:
mock starts by complaining it cannot create it's work directory, based on the SCM_PKG name (--scm-option package)

Expected results:
 Desired Results:
  A clean build, using the SCM integration


Additional info:
The attached patch resolves the issue for us, converting the multi-level path in to a single directory element for the temporary directory (in get_sources()); correcting an assumption about how to rename the checked out directory later in the same routine.  And finally, it adds a feature to trim the SCM_PKG down to the last element of the path, for use as in the specification file name

Comment 1 Eric Schnoebelen 2015-03-13 23:42:32 UTC
This issue still exists in 1.2.7, and the patch continues to  apply cleanly.


Note You need to log in before you can comment on or make changes to this bug.